f59abb161c
Use del_timer_sync() instead of del_timer() to make sure the timer won't be running when we return from parport_wait_event(), because this would crash due to destruction of timer_list. This is untested and just based on a code review. Just think about the following sequence of events: - add_timer() - down_interruptible() is interrupted by a signal. - we enter the timer callback handler on another CPU. - del_timer(), but the timer callback is still running. - eturn from parport_wait_even, which destroys the automatic variable "timer" while the callback is running on another CPU. [akpm@linux-foundation.org: coding-style fixes] Signed-off-by: Michael Buesch <mb@bu3sch.de> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> |
||
|---|---|---|
| .. | ||
| BUGS-parport | ||
| ChangeLog | ||
| daisy.c | ||
| ieee1284_ops.c | ||
| ieee1284.c | ||
| Kconfig | ||
| Makefile | ||
| multiface.h | ||
| parport_amiga.c | ||
| parport_atari.c | ||
| parport_ax88796.c | ||
| parport_cs.c | ||
| parport_gsc.c | ||
| parport_gsc.h | ||
| parport_ip32.c | ||
| parport_mfc3.c | ||
| parport_pc.c | ||
| parport_serial.c | ||
| parport_sunbpp.c | ||
| probe.c | ||
| procfs.c | ||
| share.c | ||
| TODO-parport | ||