David Woodhouse 1f6ea6e511 solos-pci: Fix race condition in tasklet RX handling ... We were seeing faults in the solos-pci receive tasklet when packets arrived for a VCC which was currently being closed: [18842.727906] EIP: [<e082f490>] br2684_push+0x19/0x234 [br2684] SS:ESP 0068:dfb89d14 [18845.090712] [<c13ecff3>] ? do_page_fault+0x0/0x2e1 [18845.120042] [<e082f490>] ? br2684_push+0x19/0x234 [br2684] [18845.153530] [<e084fa13>] solos_bh+0x28b/0x7c8 [solos_pci] [18845.186488] [<e084f711>] ? solos_irq+0x2d/0x51 [solos_pci] [18845.219960] [<c100387b>] ? handle_irq+0x3b/0x48 [18845.247732] [<c10265cb>] ? irq_exit+0x34/0x57 [18845.274437] [<c1025720>] tasklet_action+0x42/0x69 [18845.303247] [<c102643f>] __do_softirq+0x8e/0x129 [18845.331540] [<c10264ff>] do_softirq+0x25/0x2a [18845.358274] [<c102664c>] _local_bh_enable_ip+0x5e/0x6a [18845.389677] [<c102666d>] local_bh_enable+0xb/0xe [18845.417944] [<e08490a8>] ppp_unregister_channel+0x32/0xbb [ppp_generic] [18845.458193] [<e08731ad>] pppox_unbind_sock+0x18/0x1f [pppox] This patch uses an RCU-inspired approach to fix it. In the RX tasklet's find_vcc() function we first refuse to use a VCC which already has the ATM_VF_READY bit cleared. And in the VCC close function, we synchronise with the tasklet to ensure that it can't still be using the VCC before we continue and allow the VCC to be destroyed. Signed-off-by: David Woodhouse <David.Woodhouse@intel.com> Tested-by: Nathan Williams <nathan@traverse.com.au> Cc: stable@kernel.org Signed-off-by: David S. Miller <davem@davemloft.net>		2010-08-07 23:02:59 -07:00
..
.gitignore
adummy.c
ambassador.c	atm: Convert pci_table entries to PCI_VDEVICE (if PCI_ANY_ID is used)	2010-07-15 19:05:18 -07:00
ambassador.h
atmtcp.c
eni.c	atm: Convert pci_table entries to PCI_VDEVICE (if PCI_ANY_ID is used)	2010-07-15 19:05:18 -07:00
eni.h
firestream.c	atm: Convert pci_table entries to PCI_VDEVICE (if PCI_ANY_ID is used)	2010-07-15 19:05:19 -07:00
firestream.h
fore200e.c
fore200e.h
he.c	atm: Convert pci_table entries to PCI_VDEVICE (if PCI_ANY_ID is used)	2010-07-15 19:05:19 -07:00
he.h
horizon.c
horizon.h
idt77105.c
idt77105.h
idt77252_tables.h
idt77252.c	atm: Convert pci_table entries to PCI_VDEVICE (if PCI_ANY_ID is used)	2010-07-15 19:05:20 -07:00
idt77252.h
iphase.c
iphase.h
Kconfig
lanai.c
Makefile
midway.h
nicstar.c	drivers: atm: don't use private copy of hex_to_bin()	2010-07-23 12:50:49 -07:00
nicstar.h
nicstarmac.c
nicstarmac.copyright
solos-attrlist.c
solos-pci.c	solos-pci: Fix race condition in tasklet RX handling	2010-08-07 23:02:59 -07:00
suni.c	atm/suni.c: call atm_dev_signal_change() when signal changes.	2010-07-09 00:09:23 -07:00
suni.h
tonga.h
uPD98401.h
uPD98402.c
uPD98402.h
zatm.c	atm: Convert pci_table entries to PCI_VDEVICE (if PCI_ANY_ID is used)	2010-07-15 19:05:21 -07:00
zatm.h
zeprom.h