Greg Thelen 2bff24a370 memcg: fix multiple large threshold notifications ... A memory cgroup with (1) multiple threshold notifications and (2) at least one threshold >=2G was not reliable. Specifically the notifications would either not fire or would not fire in the proper order. The __mem_cgroup_threshold() signaling logic depends on keeping 64 bit thresholds in sorted order. mem_cgroup_usage_register_event() sorts them with compare_thresholds(), which returns the difference of two 64 bit thresholds as an int. If the difference is positive but has bit[31] set, then sort() treats the difference as negative and breaks sort order. This fix compares the two arbitrary 64 bit thresholds returning the classic -1, 0, 1 result. The test below sets two notifications (at 0x1000 and 0x81001000): cd /sys/fs/cgroup/memory mkdir x for x in 4096 2164264960; do cgroup_event_listener x/memory.usage_in_bytes $x | sed "s/^/$x listener:/" & done echo $$ > x/cgroup.procs anon_leaker 500M v3.11-rc7 fails to signal the 4096 event listener: Leaking... Done leaking pages. Patched v3.11-rc7 properly notifies: Leaking... 4096 listener:2013:8:31:14:13:36 Done leaking pages. The fixed bug is old. It appears to date back to the introduction of memcg threshold notifications in v2.6.34-rc1-116-g2e72b6347c94 "memcg: implement memory thresholds" Signed-off-by: Greg Thelen <gthelen@google.com> Acked-by: Michal Hocko <mhocko@suse.cz> Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com> Acked-by: Johannes Weiner <hannes@cmpxchg.org> Cc: <stable@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>		2013-09-11 15:58:15 -07:00
..
backing-dev.c	mm/backing-dev.c: check user buffer length before copying data to the related user buffer	2013-09-11 15:58:03 -07:00
balloon_compaction.c
bootmem.c	mm: kill free_all_bootmem_node()	2013-07-03 16:07:39 -07:00
bounce.c	Merge branch 'for-3.10/core' of git://git.kernel.dk/linux-block	2013-05-08 10:13:35 -07:00
cleancache.c	mm: cleancache: clean up cleancache_enabled	2013-04-30 17:04:01 -07:00
compaction.c	mm: compaction: do not compact pgdat for order-0	2013-09-11 15:57:55 -07:00
debug-pagealloc.c
dmapool.c
fadvise.c	teach SYSCALL_DEFINE<n> how to deal with long long/unsigned long long	2013-03-03 22:46:22 -05:00
failslab.c
filemap_xip.c	lift sb_start_write() out of ->write()	2013-04-09 14:12:56 -04:00
filemap.c	direct-io: Handle O_(D)SYNC AIO	2013-09-04 09:23:46 -04:00
fremap.c	mm: save soft-dirty bits on file pages	2013-08-13 17:57:48 -07:00
frontswap.c	frontswap: fix incorrect zeroing and allocation size for frontswap_map	2013-06-12 16:29:46 -07:00
highmem.c
huge_memory.c	mm/huge_memory.c: fix potential NULL pointer dereference	2013-09-11 15:57:19 -07:00
hugetlb_cgroup.c	cgroup: pass around cgroup_subsys_state instead of cgroup in file methods	2013-08-08 20:11:24 -04:00
hugetlb.c	mm: prepare to remove /proc/sys/vm/hugepages_treat_as_movable	2013-09-11 15:57:49 -07:00
hwpoison-inject.c	mm/hwpoison-inject.c: change permission of corrupt-pfn/unpoison-pfn to 0200	2013-09-11 15:58:11 -07:00
init-mm.c
internal.h	mm: vmscan: fix do_try_to_free_pages() livelock	2013-09-11 15:58:01 -07:00
interval_tree.c
Kconfig	Merge remote-tracking branch 'origin/next' into kvm-ppc-next	2013-08-29 00:41:59 +02:00
Kconfig.debug
kmemcheck.c
kmemleak-test.c
kmemleak.c	mm: replace strict_strtoul() with kstrtoul()	2013-09-11 15:57:11 -07:00
ksm.c	mm: replace strict_strtoul() with kstrtoul()	2013-09-11 15:57:11 -07:00
maccess.c
madvise.c	mm/madvise.c:madvise_hwpoison(): remove local `ret'	2013-09-11 15:58:13 -07:00
Makefile	zswap: add to mm/	2013-07-10 18:11:34 -07:00
memblock.c	memblock, numa: binary search node id	2013-09-11 15:57:51 -07:00
memcontrol.c	memcg: fix multiple large threshold notifications	2013-09-11 15:58:15 -07:00
memory_hotplug.c	mm: memory-hotplug: enable memory hotplug to handle hugepage	2013-09-11 15:57:48 -07:00
memory-failure.c	mm/memory-failure.c: fix bug triggered by unpoisoning empty zero page	2013-09-11 15:58:12 -07:00
memory.c	mm: migrate: add hugepage migration code to move_pages()	2013-09-11 15:57:48 -07:00
mempolicy.c	mbind: add BUG_ON(!vma) in new_vma_page()	2013-09-11 15:57:50 -07:00
mempool.c	mm/mempool.c: convert kmalloc_node(...GFP_ZERO...) to kzalloc_node(...)	2013-09-11 15:58:14 -07:00
migrate.c	mm: vmscan: fix do_try_to_free_pages() livelock	2013-09-11 15:58:01 -07:00
mincore.c	swap: make each swap partition have one address_space	2013-02-23 17:50:17 -08:00
mlock.c	mm: munlock: manual pte walk in fast path instead of follow_page_mask()	2013-09-11 15:58:01 -07:00
mm_init.c	mm: tune vm_committed_as percpu_counter batching size	2013-07-03 16:07:32 -07:00
mmap.c	mm/mmap: remove unnecessary assignment	2013-09-11 15:58:13 -07:00
mmu_context.c	mm: remove old aio use_mm() comment	2013-05-07 18:38:27 -07:00
mmu_notifier.c	treewide: relase -> release	2013-06-28 14:34:33 +02:00
mmzone.c	mm: rename page struct field helpers	2013-02-23 17:50:18 -08:00
mprotect.c
mremap.c	mm/mremap.c: call pud_free() after fail calling pmd_alloc()	2013-09-11 15:58:03 -07:00
msync.c
nobootmem.c	mm: concentrate modification of totalram_pages into the mm core	2013-07-03 16:07:33 -07:00
nommu.c	mm: remove free_area_cache	2013-07-10 18:11:34 -07:00
oom_kill.c	mm/oom_kill: remove weird use of ERR_PTR()/PTR_ERR().	2013-07-15 11:25:05 +09:30
page_alloc.c	mm: correct the comment about the value for buddy _mapcount	2013-09-11 15:58:06 -07:00
page_cgroup.c
page_io.c	mm: remove compressed copy from zram in-memory	2013-07-03 16:07:26 -07:00
page_isolation.c	mm: memory-hotplug: enable memory hotplug to handle hugepage	2013-09-11 15:57:48 -07:00
page-writeback.c	mm/page-writeback.c: add strictlimit feature	2013-09-11 15:58:04 -07:00
pagewalk.c	mm/pagewalk.c: walk_page_range should avoid VM_PFNMAP areas	2013-05-24 16:22:53 -07:00
percpu-km.c
percpu-vm.c
percpu.c
pgtable-generic.c	mm: move pgtable related functions to right place	2013-09-11 15:57:30 -07:00
process_vm_access.c	Fix: compat_rw_copy_check_uvector() misuse in aio, readv, writev, and security keys	2013-03-12 11:05:45 -07:00
quicklist.c
readahead.c	readahead: make context readahead more conservative	2013-09-11 15:57:39 -07:00
rmap.c	s390/mm: implement software referenced bits	2013-08-29 13:20:11 +02:00
shmem.c	shm_mnt is as longterm as it gets, TYVM...	2013-09-03 22:50:27 -04:00
slab_common.c	Merge branch 'slab/for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/penberg/linux	2013-07-14 15:14:29 -07:00
slab.c	kernel: delete __cpuinit usage from all core kernel files	2013-07-14 19:36:59 -04:00
slab.h	memcg: check that kmem_cache has memcg_params before accessing it	2013-08-28 19:26:38 -07:00
slob.c	Merge branch 'slab/for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/penberg/linux	2013-07-14 15:14:29 -07:00
slub.c	mm: replace strict_strtoul() with kstrtoul()	2013-09-11 15:57:11 -07:00
sparse-vmemmap.c	sparse-vmemmap: specify vmemmap population range in bytes	2013-04-29 15:54:35 -07:00
sparse.c	mm/sparse: introduce alloc_usemap_and_memmap	2013-09-11 15:58:01 -07:00
swap_state.c	swap: avoid read_swap_cache_async() race to deadlock while waiting on discard I/O completion	2013-06-12 16:29:45 -07:00
swap.c	mm: fix aio performance regression for database caused by THP	2013-09-11 15:57:55 -07:00
swapfile.c	swap: make cluster allocation per-cpu	2013-09-11 15:57:17 -07:00
truncate.c	mm: teach truncate_inode_pages_range() to handle non page aligned ranges	2013-05-27 23:32:35 -04:00
util.c	swap: clean-up #ifdef in page_mapping()	2013-09-11 15:57:31 -07:00
vmalloc.c	mm/vmalloc: use wrapper function get_vm_area_size to caculate size of vm area	2013-09-11 15:58:02 -07:00
vmpressure.c	Merge branch 'for-3.12' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup	2013-09-03 18:25:03 -07:00
vmscan.c	mm: vmscan: fix do_try_to_free_pages() livelock	2013-09-11 15:58:01 -07:00
vmstat.c	mm: vmscan: fix do_try_to_free_pages() livelock	2013-09-11 15:58:01 -07:00
zbud.c	mm/zbud: fix some trivial typos in comments	2013-09-11 15:57:35 -07:00
zswap.c	mm/zswap.c: get swapper address_space by using macro	2013-09-11 15:57:08 -07:00