commit 04b7762e37c95d9b965d16bb0e18dbd1fa2e2861 upstream. Before these changes elan_suspend() would only disable the regulator when device_may_wakeup() returns false; whereas elan_resume() would unconditionally enable it, leading to an enable count imbalance when device_may_wakeup() returns true. This triggers the "WARN_ON(regulator->enable_count)" in regulator_put() when the elan_i2c driver gets unbound, this happens e.g. with the hot-plugable dock with Elan I2C touchpad for the Asus TF103C 2-in-1. Fix this by making the regulator_enable() call also be conditional on device_may_wakeup() returning false. Signed-off-by: Hans de Goede <hdegoede@redhat.com> Link: https://lore.kernel.org/r/20220131135436.29638-2-hdegoede@redhat.com Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
||
---|---|---|
.. | ||
alps.c | ||
alps.h | ||
amimouse.c | ||
appletouch.c | ||
atarimouse.c | ||
bcm5974.c | ||
byd.c | ||
byd.h | ||
cyapa_gen3.c | ||
cyapa_gen5.c | ||
cyapa_gen6.c | ||
cyapa.c | ||
cyapa.h | ||
cypress_ps2.c | ||
cypress_ps2.h | ||
elan_i2c_core.c | ||
elan_i2c_i2c.c | ||
elan_i2c_smbus.c | ||
elan_i2c.h | ||
elantech.c | ||
elantech.h | ||
focaltech.c | ||
focaltech.h | ||
gpio_mouse.c | ||
hgpk.c | ||
hgpk.h | ||
inport.c | ||
Kconfig | ||
lifebook.c | ||
lifebook.h | ||
logibm.c | ||
logips2pp.c | ||
logips2pp.h | ||
Makefile | ||
maplemouse.c | ||
navpoint.c | ||
pc110pad.c | ||
psmouse-base.c | ||
psmouse-smbus.c | ||
psmouse.h | ||
pxa930_trkball.c | ||
rpcmouse.c | ||
sentelic.c | ||
sentelic.h | ||
sermouse.c | ||
synaptics_i2c.c | ||
synaptics_usb.c | ||
synaptics.c | ||
synaptics.h | ||
touchkit_ps2.c | ||
touchkit_ps2.h | ||
trackpoint.c | ||
trackpoint.h | ||
vmmouse.c | ||
vmmouse.h | ||
vsxxxaa.c |