android_kernel_xiaomi_sm8350/arch/um
Paolo 'Blaisorblade' Giarrusso 71c8d4c3aa [PATCH] uml: fix spinlock recursion and sleep-inside-spinlock in error path
In this error path, when the interface has had a problem, we call dev_close(),
which is disallowed for two reasons:

*) takes again the UML internal spinlock, inside the ->stop method of this
   device
*) can be called in process context only, while we're in interrupt context.

I've also thought that calling dev_close() may be a wrong policy to follow,
but it's not up to me to decide that.

However, we may end up with multiple dev_close() queued on the same device.
But the initial test for (dev->flags & IFF_UP) makes this harmless, though -
and dev_close() is supposed to care about races with itself.  So there's no
harm in delaying the shutdown, IMHO.

Something to mark the interface as "going to shutdown" would be appreciated,
but dev_deactivate has the same problems as dev_close(), so we can't use it
either.

Signed-off-by: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
Cc: Jeff Dike <jdike@addtoit.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
2006-01-18 19:20:21 -08:00
..
drivers [PATCH] uml: fix spinlock recursion and sleep-inside-spinlock in error path 2006-01-18 19:20:21 -08:00
include [PATCH] uml: use setjmp/longjmp instead of sigsetjmp/siglongjmp 2006-01-18 19:20:20 -08:00
kernel [PATCH] uml: TT mode softint fixes 2006-01-18 19:20:20 -08:00
os-Linux [PATCH] uml: implement soft interrupts 2006-01-18 19:20:20 -08:00
scripts [PATCH] uml: arch/um/scripts/Makefile.rules - remove duplicated code 2005-12-18 11:19:44 -08:00
sys-i386 [PATCH] uml: move LDT creation 2006-01-18 19:20:18 -08:00
sys-ia64
sys-ppc
sys-x86_64 [PATCH] uml: fix missing KBUILD_BASENAME 2006-01-11 18:42:09 -08:00
config.release
defconfig
Kconfig [PATCH] uml: update Kconfig help 2006-01-11 18:42:09 -08:00
Kconfig.char
Kconfig.debug
Kconfig.i386 [PATCH] uml: fixups for "reuse i386 cpu-specific tuning" 2005-11-13 18:14:14 -08:00
Kconfig.net
Kconfig.scsi
Kconfig.x86_64 [PATCH] uml: fix "reuse i386 cpu optimizations" 2005-10-30 17:37:16 -08:00
Makefile [PATCH] uml: move headers to arch/um/include 2006-01-18 19:20:19 -08:00
Makefile-i386 [PATCH] uml: fixups for "reuse i386 cpu-specific tuning" 2005-11-13 18:14:14 -08:00
Makefile-ia64
Makefile-os-Linux
Makefile-ppc
Makefile-skas [PATCH] uml makefiles sanitized 2005-09-29 08:46:26 -07:00
Makefile-tt
Makefile-x86_64 [PATCH] uml: fix dynamic linking on some 64-bit distros 2005-12-18 11:19:44 -08:00