When compiling this driver, the compiler throws the following warnings: drivers/isdn/hardware/eicon/message.c:8426: warning: array subscript is above array bounds drivers/isdn/hardware/eicon/message.c:8427: warning: array subscript is above array bounds drivers/isdn/hardware/eicon/message.c:8434: warning: array subscript is above array bounds drivers/isdn/hardware/eicon/message.c:8435: warning: array subscript is above array bounds drivers/isdn/hardware/eicon/message.c:8436: warning: array subscript is above array bounds drivers/isdn/hardware/eicon/message.c:8447: warning: array subscript is above array bounds This arises from the particular semantics the driver is using to write to the nlc array (static byte[256]). The array has a length in byte 0 followed by a T30_INFO struct starting at byte 1. The T30_INFO struct has a number of variable length strings after the station_id entry, which cannot be explicitly defined in the struct and the driver accesses them with an array index to station_id beyond the length of station_id. This patch merely changes the semantics that the driver uses to access the entries after the station_id entry to use the original 256 byte nlc array taking the offset and length of the station_id entry to calculate where to write in the array, thereby silencing the warning. Signed-off-by: Ian Munsie <imunsie@au.ibm.com> Cc: Armin Schindler <mac@melware.de> Cc: Karsten Keil <isdn@linux-pingi.de> Cc: Stoyan Gaydarov <sgayda2@uiuc.edu> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: David S. Miller <davem@davemloft.net> |
||
---|---|---|
.. | ||
adapter.h | ||
capi20.h | ||
capidtmf.c | ||
capidtmf.h | ||
capifunc.c | ||
capifunc.h | ||
capimain.c | ||
cardtype.h | ||
cp_vers.h | ||
dadapter.c | ||
dadapter.h | ||
debug_if.h | ||
debug.c | ||
debuglib.c | ||
debuglib.h | ||
dfifo.h | ||
di_dbg.h | ||
di_defs.h | ||
di.c | ||
di.h | ||
did_vers.h | ||
diddfunc.c | ||
diva_didd.c | ||
diva_dma.c | ||
diva_dma.h | ||
diva_pci.h | ||
diva.c | ||
diva.h | ||
divacapi.h | ||
divamnt.c | ||
divasfunc.c | ||
divasi.c | ||
divasmain.c | ||
divasproc.c | ||
divasync.h | ||
dqueue.c | ||
dqueue.h | ||
dsp_defs.h | ||
dsp_tst.h | ||
dspdids.h | ||
dsrv4bri.h | ||
dsrv_bri.h | ||
dsrv_pri.h | ||
entity.h | ||
helpers.h | ||
idifunc.c | ||
io.c | ||
io.h | ||
istream.c | ||
Kconfig | ||
kst_ifc.h | ||
maintidi.c | ||
maintidi.h | ||
Makefile | ||
man_defs.h | ||
mdm_msg.h | ||
message.c | ||
mi_pc.h | ||
mntfunc.c | ||
os_4bri.c | ||
os_4bri.h | ||
os_bri.c | ||
os_bri.h | ||
os_capi.h | ||
os_pri.c | ||
os_pri.h | ||
pc_init.h | ||
pc_maint.h | ||
pc.h | ||
pkmaint.h | ||
platform.h | ||
pr_pc.h | ||
s_4bri.c | ||
s_bri.c | ||
s_pri.c | ||
sdp_hdr.h | ||
um_idi.c | ||
um_idi.h | ||
um_xdi.h | ||
xdi_adapter.h | ||
xdi_msg.h | ||
xdi_vers.h |