5a0e3ad6af
percpu.h is included by sched.h and module.h and thus ends up being included when building most .c files. percpu.h includes slab.h which in turn includes gfp.h making everything defined by the two files universally available and complicating inclusion dependencies. percpu.h -> slab.h dependency is about to be removed. Prepare for this change by updating users of gfp and slab facilities include those headers directly instead of assuming availability. As this conversion needs to touch large number of source files, the following script is used as the basis of conversion. http://userweb.kernel.org/~tj/misc/slabh-sweep.py The script does the followings. * Scan files for gfp and slab usages and update includes such that only the necessary includes are there. ie. if only gfp is used, gfp.h, if slab is used, slab.h. * When the script inserts a new include, it looks at the include blocks and try to put the new include such that its order conforms to its surrounding. It's put in the include block which contains core kernel includes, in the same order that the rest are ordered - alphabetical, Christmas tree, rev-Xmas-tree or at the end if there doesn't seem to be any matching order. * If the script can't find a place to put a new include (mostly because the file doesn't have fitting include block), it prints out an error message indicating which .h file needs to be added to the file. The conversion was done in the following steps. 1. The initial automatic conversion of all .c files updated slightly over 4000 files, deleting around 700 includes and adding ~480 gfp.h and ~3000 slab.h inclusions. The script emitted errors for ~400 files. 2. Each error was manually checked. Some didn't need the inclusion, some needed manual addition while adding it to implementation .h or embedding .c file was more appropriate for others. This step added inclusions to around 150 files. 3. The script was run again and the output was compared to the edits from #2 to make sure no file was left behind. 4. Several build tests were done and a couple of problems were fixed. e.g. lib/decompress_*.c used malloc/free() wrappers around slab APIs requiring slab.h to be added manually. 5. The script was run on all .h files but without automatically editing them as sprinkling gfp.h and slab.h inclusions around .h files could easily lead to inclusion dependency hell. Most gfp.h inclusion directives were ignored as stuff from gfp.h was usually wildly available and often used in preprocessor macros. Each slab.h inclusion directive was examined and added manually as necessary. 6. percpu.h was updated not to include slab.h. 7. Build test were done on the following configurations and failures were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my distributed build env didn't work with gcov compiles) and a few more options had to be turned off depending on archs to make things build (like ipr on powerpc/64 which failed due to missing writeq). * x86 and x86_64 UP and SMP allmodconfig and a custom test config. * powerpc and powerpc64 SMP allmodconfig * sparc and sparc64 SMP allmodconfig * ia64 SMP allmodconfig * s390 SMP allmodconfig * alpha SMP allmodconfig * um on x86_64 SMP allmodconfig 8. percpu.h modifications were reverted so that it could be applied as a separate patch and serve as bisection point. Given the fact that I had only a couple of failures from tests on step 6, I'm fairly confident about the coverage of this conversion patch. If there is a breakage, it's likely to be something in one of the arch headers which should be easily discoverable easily on most builds of the specific arch. Signed-off-by: Tejun Heo <tj@kernel.org> Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org> Cc: Ingo Molnar <mingo@redhat.com> Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
146 lines
3.0 KiB
C
146 lines
3.0 KiB
C
|
|
/*
|
|
* Hauppauge HD PVR USB driver
|
|
*
|
|
* Copyright (C) 2008 Janne Grunau (j@jannau.net)
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public License as
|
|
* published by the Free Software Foundation, version 2.
|
|
*
|
|
*/
|
|
|
|
#include <linux/i2c.h>
|
|
#include <linux/slab.h>
|
|
|
|
#include "hdpvr.h"
|
|
|
|
#define CTRL_READ_REQUEST 0xb8
|
|
#define CTRL_WRITE_REQUEST 0x38
|
|
|
|
#define REQTYPE_I2C_READ 0xb1
|
|
#define REQTYPE_I2C_WRITE 0xb0
|
|
#define REQTYPE_I2C_WRITE_STATT 0xd0
|
|
|
|
static int hdpvr_i2c_read(struct hdpvr_device *dev, unsigned char addr,
|
|
char *data, int len)
|
|
{
|
|
int ret;
|
|
char *buf = kmalloc(len, GFP_KERNEL);
|
|
if (!buf)
|
|
return -ENOMEM;
|
|
|
|
ret = usb_control_msg(dev->udev,
|
|
usb_rcvctrlpipe(dev->udev, 0),
|
|
REQTYPE_I2C_READ, CTRL_READ_REQUEST,
|
|
0x100|addr, 0, buf, len, 1000);
|
|
|
|
if (ret == len) {
|
|
memcpy(data, buf, len);
|
|
ret = 0;
|
|
} else if (ret >= 0)
|
|
ret = -EIO;
|
|
|
|
kfree(buf);
|
|
|
|
return ret;
|
|
}
|
|
|
|
static int hdpvr_i2c_write(struct hdpvr_device *dev, unsigned char addr,
|
|
char *data, int len)
|
|
{
|
|
int ret;
|
|
char *buf = kmalloc(len, GFP_KERNEL);
|
|
if (!buf)
|
|
return -ENOMEM;
|
|
|
|
memcpy(buf, data, len);
|
|
ret = usb_control_msg(dev->udev,
|
|
usb_sndctrlpipe(dev->udev, 0),
|
|
REQTYPE_I2C_WRITE, CTRL_WRITE_REQUEST,
|
|
0x100|addr, 0, buf, len, 1000);
|
|
|
|
if (ret < 0)
|
|
goto error;
|
|
|
|
ret = usb_control_msg(dev->udev,
|
|
usb_rcvctrlpipe(dev->udev, 0),
|
|
REQTYPE_I2C_WRITE_STATT, CTRL_READ_REQUEST,
|
|
0, 0, buf, 2, 1000);
|
|
|
|
if (ret == 2)
|
|
ret = 0;
|
|
else if (ret >= 0)
|
|
ret = -EIO;
|
|
|
|
error:
|
|
kfree(buf);
|
|
return ret;
|
|
}
|
|
|
|
static int hdpvr_transfer(struct i2c_adapter *i2c_adapter, struct i2c_msg *msgs,
|
|
int num)
|
|
{
|
|
struct hdpvr_device *dev = i2c_get_adapdata(i2c_adapter);
|
|
int retval = 0, i, addr;
|
|
|
|
if (num <= 0)
|
|
return 0;
|
|
|
|
mutex_lock(&dev->i2c_mutex);
|
|
|
|
for (i = 0; i < num && !retval; i++) {
|
|
addr = msgs[i].addr << 1;
|
|
|
|
if (msgs[i].flags & I2C_M_RD)
|
|
retval = hdpvr_i2c_read(dev, addr, msgs[i].buf,
|
|
msgs[i].len);
|
|
else
|
|
retval = hdpvr_i2c_write(dev, addr, msgs[i].buf,
|
|
msgs[i].len);
|
|
}
|
|
|
|
mutex_unlock(&dev->i2c_mutex);
|
|
|
|
return retval ? retval : num;
|
|
}
|
|
|
|
static u32 hdpvr_functionality(struct i2c_adapter *adapter)
|
|
{
|
|
return I2C_FUNC_I2C | I2C_FUNC_SMBUS_EMUL;
|
|
}
|
|
|
|
static struct i2c_algorithm hdpvr_algo = {
|
|
.master_xfer = hdpvr_transfer,
|
|
.functionality = hdpvr_functionality,
|
|
};
|
|
|
|
int hdpvr_register_i2c_adapter(struct hdpvr_device *dev)
|
|
{
|
|
struct i2c_adapter *i2c_adap;
|
|
int retval = -ENOMEM;
|
|
|
|
i2c_adap = kzalloc(sizeof(struct i2c_adapter), GFP_KERNEL);
|
|
if (i2c_adap == NULL)
|
|
goto error;
|
|
|
|
strlcpy(i2c_adap->name, "Hauppauge HD PVR I2C",
|
|
sizeof(i2c_adap->name));
|
|
i2c_adap->algo = &hdpvr_algo;
|
|
i2c_adap->class = I2C_CLASS_TV_ANALOG;
|
|
i2c_adap->owner = THIS_MODULE;
|
|
i2c_adap->dev.parent = &dev->udev->dev;
|
|
|
|
i2c_set_adapdata(i2c_adap, dev);
|
|
|
|
retval = i2c_add_adapter(i2c_adap);
|
|
|
|
if (!retval)
|
|
dev->i2c_adapter = i2c_adap;
|
|
else
|
|
kfree(i2c_adap);
|
|
|
|
error:
|
|
return retval;
|
|
}
|