ad3a056982
[ Upstream commit 89ab396d712f7c91fe94f55cff23460426f5fc81 ] We should hold the reference returned by of_get_parent() and use it to call of_node_put() for refcount balance. Fixes:88e2da8124("clk: meson: aoclk: refactor common code into dedicated file") Fixes:6682bd4d44("clk: meson: factorise meson64 peripheral clock controller drivers") Fixes:bb6eddd1d2("clk: meson: meson8b: use the HHI syscon if available") Signed-off-by: Liang He <windhl@126.com> Link: https://lore.kernel.org/r/20220628141038.168383-1-windhl@126.com Reviewed-by: Neil Armstrong <narmstrong@baylibre.com> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> Signed-off-by: Stephen Boyd <sboyd@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
90 lines
2.3 KiB
C
90 lines
2.3 KiB
C
// SPDX-License-Identifier: GPL-2.0+
|
|
/*
|
|
* Amlogic Meson-AXG Clock Controller Driver
|
|
*
|
|
* Copyright (c) 2016 BayLibre, SAS.
|
|
* Author: Neil Armstrong <narmstrong@baylibre.com>
|
|
*
|
|
* Copyright (c) 2018 Amlogic, inc.
|
|
* Author: Qiufang Dai <qiufang.dai@amlogic.com>
|
|
* Author: Yixun Lan <yixun.lan@amlogic.com>
|
|
*/
|
|
|
|
#include <linux/platform_device.h>
|
|
#include <linux/reset-controller.h>
|
|
#include <linux/mfd/syscon.h>
|
|
#include <linux/of_device.h>
|
|
#include <linux/slab.h>
|
|
#include "meson-aoclk.h"
|
|
|
|
static int meson_aoclk_do_reset(struct reset_controller_dev *rcdev,
|
|
unsigned long id)
|
|
{
|
|
struct meson_aoclk_reset_controller *rstc =
|
|
container_of(rcdev, struct meson_aoclk_reset_controller, reset);
|
|
|
|
return regmap_write(rstc->regmap, rstc->data->reset_reg,
|
|
BIT(rstc->data->reset[id]));
|
|
}
|
|
|
|
static const struct reset_control_ops meson_aoclk_reset_ops = {
|
|
.reset = meson_aoclk_do_reset,
|
|
};
|
|
|
|
int meson_aoclkc_probe(struct platform_device *pdev)
|
|
{
|
|
struct meson_aoclk_reset_controller *rstc;
|
|
struct meson_aoclk_data *data;
|
|
struct device *dev = &pdev->dev;
|
|
struct device_node *np;
|
|
struct regmap *regmap;
|
|
int ret, clkid;
|
|
|
|
data = (struct meson_aoclk_data *) of_device_get_match_data(dev);
|
|
if (!data)
|
|
return -ENODEV;
|
|
|
|
rstc = devm_kzalloc(dev, sizeof(*rstc), GFP_KERNEL);
|
|
if (!rstc)
|
|
return -ENOMEM;
|
|
|
|
np = of_get_parent(dev->of_node);
|
|
regmap = syscon_node_to_regmap(np);
|
|
of_node_put(np);
|
|
if (IS_ERR(regmap)) {
|
|
dev_err(dev, "failed to get regmap\n");
|
|
return PTR_ERR(regmap);
|
|
}
|
|
|
|
/* Reset Controller */
|
|
rstc->data = data;
|
|
rstc->regmap = regmap;
|
|
rstc->reset.ops = &meson_aoclk_reset_ops;
|
|
rstc->reset.nr_resets = data->num_reset,
|
|
rstc->reset.of_node = dev->of_node;
|
|
ret = devm_reset_controller_register(dev, &rstc->reset);
|
|
if (ret) {
|
|
dev_err(dev, "failed to register reset controller\n");
|
|
return ret;
|
|
}
|
|
|
|
/* Populate regmap */
|
|
for (clkid = 0; clkid < data->num_clks; clkid++)
|
|
data->clks[clkid]->map = regmap;
|
|
|
|
/* Register all clks */
|
|
for (clkid = 0; clkid < data->hw_data->num; clkid++) {
|
|
if (!data->hw_data->hws[clkid])
|
|
continue;
|
|
|
|
ret = devm_clk_hw_register(dev, data->hw_data->hws[clkid]);
|
|
if (ret) {
|
|
dev_err(dev, "Clock registration failed\n");
|
|
return ret;
|
|
}
|
|
}
|
|
|
|
return devm_of_clk_add_hw_provider(dev, of_clk_hw_onecell_get,
|
|
(void *) data->hw_data);
|
|
}
|