André Goddard Rosa e7d2860b69 tree-wide: convert open calls to remove spaces to skip_spaces() lib function ... Makes use of skip_spaces() defined in lib/string.c for removing leading spaces from strings all over the tree. It decreases lib.a code size by 47 bytes and reuses the function tree-wide: text data bss dec hex filename 64688 584 592 65864 10148 (TOTALS-BEFORE) 64641 584 592 65817 10119 (TOTALS-AFTER) Also, while at it, if we see (*str && isspace(*str)), we can be sure to remove the first condition (*str) as the second one (isspace(*str)) also evaluates to 0 whenever *str == 0, making it redundant. In other words, "a char equals zero is never a space". Julia Lawall tried the semantic patch (http://coccinelle.lip6.fr) below, and found occurrences of this pattern on 3 more files: drivers/leds/led-class.c drivers/leds/ledtrig-timer.c drivers/video/output.c @@ expression str; @@ ( // ignore skip_spaces cases while (*str && isspace(*str)) { \(str++;\|++str;\) } | - *str && isspace(*str) ) Signed-off-by: André Goddard Rosa <andre.goddard@gmail.com> Cc: Julia Lawall <julia@diku.dk> Cc: Martin Schwidefsky <schwidefsky@de.ibm.com> Cc: Jeff Dike <jdike@addtoit.com> Cc: Ingo Molnar <mingo@elte.hu> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: "H. Peter Anvin" <hpa@zytor.com> Cc: Richard Purdie <rpurdie@rpsys.net> Cc: Neil Brown <neilb@suse.de> Cc: Kyle McMartin <kyle@mcmartin.ca> Cc: Henrique de Moraes Holschuh <hmh@hmh.eng.br> Cc: David Howells <dhowells@redhat.com> Cc: <linux-ext4@vger.kernel.org> Cc: Samuel Ortiz <samuel@sortiz.org> Cc: Patrick McHardy <kaber@trash.net> Cc: Takashi Iwai <tiwai@suse.de> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>		2009-12-15 08:53:32 -08:00
..
chan_kern.c
chan_user.c
cow_sys.h
cow_user.c
cow.h
daemon_kern.c
daemon_user.c
daemon.h
fd.c
harddog_kern.c
harddog_user.c
hostaudio_kern.c
line.c	headers: remove sched.h from interrupt.h	2009-10-11 11:20:58 -07:00
Makefile
mcast_kern.c
mcast_user.c
mcast.h
mconsole_kern.c	tree-wide: convert open calls to remove spaces to skip_spaces() lib function	2009-12-15 08:53:32 -08:00
mconsole_user.c
mmapper_kern.c	um: Remove BKL from mmapper	2009-10-14 15:35:51 +02:00
net_kern.c
net_user.c
null.c
pcap_kern.c
pcap_user.c
pcap_user.h
port_kern.c	headers: remove sched.h from interrupt.h	2009-10-11 11:20:58 -07:00
port_user.c
port.h
pty.c
random.c	um: Remove BKL from random	2009-10-14 15:35:51 +02:00
slip_common.c
slip_common.h
slip_kern.c
slip_user.c
slip.h
slirp_kern.c
slirp_user.c
slirp.h
ssl.c
ssl.h
stderr_console.c
stdio_console.c
stdio_console.h
tty.c
ubd_kern.c	uml: convert to seq_file/proc_fops	2009-12-15 08:53:25 -08:00
ubd_user.c
vde_kern.c
vde_user.c
vde.h
xterm_kern.c
xterm.c
xterm.h