7f353bf29e
http://bugzilla.kernel.org/show_bug.cgi?id=8797 shows that the bonding driver may produce bogus combinations of the checksum flags and SG/TSO. For example, if you bond devices with NETIF_F_HW_CSUM and NETIF_F_IP_CSUM you'll end up with a bonding device that has neither flag set. If both have TSO then this produces an illegal combination. The bridge device on the other hand has the correct code to deal with this. In fact, the same code can be used for both. So this patch moves that logic into net/core/dev.c and uses it for both bonding and bridging. In the process I've made small adjustments such as only setting GSO_ROBUST if at least one constituent device supports it. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> Signed-off-by: David S. Miller <davem@davemloft.net>
184 lines
4.1 KiB
C
184 lines
4.1 KiB
C
/*
|
|
* Device handling code
|
|
* Linux ethernet bridge
|
|
*
|
|
* Authors:
|
|
* Lennert Buytenhek <buytenh@gnu.org>
|
|
*
|
|
* $Id: br_device.c,v 1.6 2001/12/24 00:59:55 davem Exp $
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public License
|
|
* as published by the Free Software Foundation; either version
|
|
* 2 of the License, or (at your option) any later version.
|
|
*/
|
|
|
|
#include <linux/kernel.h>
|
|
#include <linux/netdevice.h>
|
|
#include <linux/etherdevice.h>
|
|
#include <linux/ethtool.h>
|
|
|
|
#include <asm/uaccess.h>
|
|
#include "br_private.h"
|
|
|
|
static struct net_device_stats *br_dev_get_stats(struct net_device *dev)
|
|
{
|
|
struct net_bridge *br = netdev_priv(dev);
|
|
return &br->statistics;
|
|
}
|
|
|
|
/* net device transmit always called with no BH (preempt_disabled) */
|
|
int br_dev_xmit(struct sk_buff *skb, struct net_device *dev)
|
|
{
|
|
struct net_bridge *br = netdev_priv(dev);
|
|
const unsigned char *dest = skb->data;
|
|
struct net_bridge_fdb_entry *dst;
|
|
|
|
br->statistics.tx_packets++;
|
|
br->statistics.tx_bytes += skb->len;
|
|
|
|
skb_reset_mac_header(skb);
|
|
skb_pull(skb, ETH_HLEN);
|
|
|
|
if (dest[0] & 1)
|
|
br_flood_deliver(br, skb, 0);
|
|
else if ((dst = __br_fdb_get(br, dest)) != NULL)
|
|
br_deliver(dst->dst, skb);
|
|
else
|
|
br_flood_deliver(br, skb, 0);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int br_dev_open(struct net_device *dev)
|
|
{
|
|
struct net_bridge *br = netdev_priv(dev);
|
|
|
|
br_features_recompute(br);
|
|
netif_start_queue(dev);
|
|
br_stp_enable_bridge(br);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static void br_dev_set_multicast_list(struct net_device *dev)
|
|
{
|
|
}
|
|
|
|
static int br_dev_stop(struct net_device *dev)
|
|
{
|
|
br_stp_disable_bridge(netdev_priv(dev));
|
|
|
|
netif_stop_queue(dev);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int br_change_mtu(struct net_device *dev, int new_mtu)
|
|
{
|
|
if (new_mtu < 68 || new_mtu > br_min_mtu(netdev_priv(dev)))
|
|
return -EINVAL;
|
|
|
|
dev->mtu = new_mtu;
|
|
return 0;
|
|
}
|
|
|
|
/* Allow setting mac address to any valid ethernet address. */
|
|
static int br_set_mac_address(struct net_device *dev, void *p)
|
|
{
|
|
struct net_bridge *br = netdev_priv(dev);
|
|
struct sockaddr *addr = p;
|
|
|
|
if (!is_valid_ether_addr(addr->sa_data))
|
|
return -EINVAL;
|
|
|
|
spin_lock_bh(&br->lock);
|
|
memcpy(dev->dev_addr, addr->sa_data, ETH_ALEN);
|
|
br_stp_change_bridge_id(br, addr->sa_data);
|
|
spin_unlock_bh(&br->lock);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static void br_getinfo(struct net_device *dev, struct ethtool_drvinfo *info)
|
|
{
|
|
strcpy(info->driver, "bridge");
|
|
strcpy(info->version, BR_VERSION);
|
|
strcpy(info->fw_version, "N/A");
|
|
strcpy(info->bus_info, "N/A");
|
|
}
|
|
|
|
static int br_set_sg(struct net_device *dev, u32 data)
|
|
{
|
|
struct net_bridge *br = netdev_priv(dev);
|
|
|
|
if (data)
|
|
br->feature_mask |= NETIF_F_SG;
|
|
else
|
|
br->feature_mask &= ~NETIF_F_SG;
|
|
|
|
br_features_recompute(br);
|
|
return 0;
|
|
}
|
|
|
|
static int br_set_tso(struct net_device *dev, u32 data)
|
|
{
|
|
struct net_bridge *br = netdev_priv(dev);
|
|
|
|
if (data)
|
|
br->feature_mask |= NETIF_F_TSO;
|
|
else
|
|
br->feature_mask &= ~NETIF_F_TSO;
|
|
|
|
br_features_recompute(br);
|
|
return 0;
|
|
}
|
|
|
|
static int br_set_tx_csum(struct net_device *dev, u32 data)
|
|
{
|
|
struct net_bridge *br = netdev_priv(dev);
|
|
|
|
if (data)
|
|
br->feature_mask |= NETIF_F_NO_CSUM;
|
|
else
|
|
br->feature_mask &= ~NETIF_F_ALL_CSUM;
|
|
|
|
br_features_recompute(br);
|
|
return 0;
|
|
}
|
|
|
|
static struct ethtool_ops br_ethtool_ops = {
|
|
.get_drvinfo = br_getinfo,
|
|
.get_link = ethtool_op_get_link,
|
|
.get_sg = ethtool_op_get_sg,
|
|
.set_sg = br_set_sg,
|
|
.get_tx_csum = ethtool_op_get_tx_csum,
|
|
.set_tx_csum = br_set_tx_csum,
|
|
.get_tso = ethtool_op_get_tso,
|
|
.set_tso = br_set_tso,
|
|
};
|
|
|
|
void br_dev_setup(struct net_device *dev)
|
|
{
|
|
memset(dev->dev_addr, 0, ETH_ALEN);
|
|
|
|
ether_setup(dev);
|
|
|
|
dev->do_ioctl = br_dev_ioctl;
|
|
dev->get_stats = br_dev_get_stats;
|
|
dev->hard_start_xmit = br_dev_xmit;
|
|
dev->open = br_dev_open;
|
|
dev->set_multicast_list = br_dev_set_multicast_list;
|
|
dev->change_mtu = br_change_mtu;
|
|
dev->destructor = free_netdev;
|
|
SET_MODULE_OWNER(dev);
|
|
SET_ETHTOOL_OPS(dev, &br_ethtool_ops);
|
|
dev->stop = br_dev_stop;
|
|
dev->tx_queue_len = 0;
|
|
dev->set_mac_address = br_set_mac_address;
|
|
dev->priv_flags = IFF_EBRIDGE;
|
|
|
|
dev->features = NETIF_F_SG | NETIF_F_FRAGLIST | NETIF_F_HIGHDMA |
|
|
NETIF_F_GSO_MASK | NETIF_F_NO_CSUM | NETIF_F_LLTX;
|
|
}
|