1aa56cca5b
Clearing drvdata in ->remove_one causes NULL pointer deference. Clear drvdata only in ata_host_release() after all resources are freed. Signed-off-by: Tejun Heo <htejun@gmail.com> Signed-off-by: Jeff Garzik <jeff@garzik.org>
163 lines
3.9 KiB
C
163 lines
3.9 KiB
C
|
|
/*
|
|
* pata-isapnp.c - ISA PnP PATA controller driver.
|
|
* Copyright 2005/2006 Red Hat Inc <alan@redhat.com>, all rights reserved.
|
|
*
|
|
* Based in part on ide-pnp.c by Andrey Panin <pazke@donpac.ru>
|
|
*/
|
|
|
|
#include <linux/kernel.h>
|
|
#include <linux/module.h>
|
|
#include <linux/isapnp.h>
|
|
#include <linux/init.h>
|
|
#include <linux/blkdev.h>
|
|
#include <linux/delay.h>
|
|
#include <scsi/scsi_host.h>
|
|
#include <linux/ata.h>
|
|
#include <linux/libata.h>
|
|
|
|
#define DRV_NAME "pata_isapnp"
|
|
#define DRV_VERSION "0.2.0"
|
|
|
|
static struct scsi_host_template isapnp_sht = {
|
|
.module = THIS_MODULE,
|
|
.name = DRV_NAME,
|
|
.ioctl = ata_scsi_ioctl,
|
|
.queuecommand = ata_scsi_queuecmd,
|
|
.can_queue = ATA_DEF_QUEUE,
|
|
.this_id = ATA_SHT_THIS_ID,
|
|
.sg_tablesize = LIBATA_MAX_PRD,
|
|
.cmd_per_lun = ATA_SHT_CMD_PER_LUN,
|
|
.emulated = ATA_SHT_EMULATED,
|
|
.use_clustering = ATA_SHT_USE_CLUSTERING,
|
|
.proc_name = DRV_NAME,
|
|
.dma_boundary = ATA_DMA_BOUNDARY,
|
|
.slave_configure = ata_scsi_slave_config,
|
|
.slave_destroy = ata_scsi_slave_destroy,
|
|
.bios_param = ata_std_bios_param,
|
|
};
|
|
|
|
static struct ata_port_operations isapnp_port_ops = {
|
|
.port_disable = ata_port_disable,
|
|
.tf_load = ata_tf_load,
|
|
.tf_read = ata_tf_read,
|
|
.check_status = ata_check_status,
|
|
.exec_command = ata_exec_command,
|
|
.dev_select = ata_std_dev_select,
|
|
|
|
.freeze = ata_bmdma_freeze,
|
|
.thaw = ata_bmdma_thaw,
|
|
.error_handler = ata_bmdma_error_handler,
|
|
.post_internal_cmd = ata_bmdma_post_internal_cmd,
|
|
|
|
.qc_prep = ata_qc_prep,
|
|
.qc_issue = ata_qc_issue_prot,
|
|
|
|
.data_xfer = ata_data_xfer,
|
|
|
|
.irq_handler = ata_interrupt,
|
|
.irq_clear = ata_bmdma_irq_clear,
|
|
.irq_on = ata_irq_on,
|
|
.irq_ack = ata_irq_ack,
|
|
|
|
.port_start = ata_port_start,
|
|
};
|
|
|
|
/**
|
|
* isapnp_init_one - attach an isapnp interface
|
|
* @idev: PnP device
|
|
* @dev_id: matching detect line
|
|
*
|
|
* Register an ISA bus IDE interface. Such interfaces are PIO 0 and
|
|
* non shared IRQ.
|
|
*/
|
|
|
|
static int isapnp_init_one(struct pnp_dev *idev, const struct pnp_device_id *dev_id)
|
|
{
|
|
struct ata_probe_ent ae;
|
|
void __iomem *cmd_addr, *ctl_addr;
|
|
|
|
if (pnp_port_valid(idev, 0) == 0)
|
|
return -ENODEV;
|
|
|
|
/* FIXME: Should selected polled PIO here not fail */
|
|
if (pnp_irq_valid(idev, 0) == 0)
|
|
return -ENODEV;
|
|
|
|
cmd_addr = devm_ioport_map(&idev->dev, pnp_port_start(idev, 0), 8);
|
|
if (!cmd_addr)
|
|
return -ENOMEM;
|
|
|
|
memset(&ae, 0, sizeof(struct ata_probe_ent));
|
|
INIT_LIST_HEAD(&ae.node);
|
|
ae.dev = &idev->dev;
|
|
ae.port_ops = &isapnp_port_ops;
|
|
ae.sht = &isapnp_sht;
|
|
ae.n_ports = 1;
|
|
ae.pio_mask = 1; /* ISA so PIO 0 cycles */
|
|
ae.irq = pnp_irq(idev, 0);
|
|
ae.irq_flags = 0;
|
|
ae.port_flags = ATA_FLAG_SLAVE_POSS;
|
|
ae.port[0].cmd_addr = cmd_addr;
|
|
|
|
if (pnp_port_valid(idev, 1) == 0) {
|
|
ctl_addr = devm_ioport_map(&idev->dev,
|
|
pnp_port_start(idev, 1), 1);
|
|
ae.port[0].altstatus_addr = ctl_addr;
|
|
ae.port[0].ctl_addr = ctl_addr;
|
|
ae.port_flags |= ATA_FLAG_SRST;
|
|
}
|
|
ata_std_ports(&ae.port[0]);
|
|
|
|
if (ata_device_add(&ae) == 0)
|
|
return -ENODEV;
|
|
return 0;
|
|
}
|
|
|
|
/**
|
|
* isapnp_remove_one - unplug an isapnp interface
|
|
* @idev: PnP device
|
|
*
|
|
* Remove a previously configured PnP ATA port. Called only on module
|
|
* unload events as the core does not currently deal with ISAPnP docking.
|
|
*/
|
|
|
|
static void isapnp_remove_one(struct pnp_dev *idev)
|
|
{
|
|
struct device *dev = &idev->dev;
|
|
struct ata_host *host = dev_get_drvdata(dev);
|
|
|
|
ata_host_detach(host);
|
|
}
|
|
|
|
static struct pnp_device_id isapnp_devices[] = {
|
|
/* Generic ESDI/IDE/ATA compatible hard disk controller */
|
|
{.id = "PNP0600", .driver_data = 0},
|
|
{.id = ""}
|
|
};
|
|
|
|
static struct pnp_driver isapnp_driver = {
|
|
.name = DRV_NAME,
|
|
.id_table = isapnp_devices,
|
|
.probe = isapnp_init_one,
|
|
.remove = isapnp_remove_one,
|
|
};
|
|
|
|
static int __init isapnp_init(void)
|
|
{
|
|
return pnp_register_driver(&isapnp_driver);
|
|
}
|
|
|
|
static void __exit isapnp_exit(void)
|
|
{
|
|
pnp_unregister_driver(&isapnp_driver);
|
|
}
|
|
|
|
MODULE_AUTHOR("Alan Cox");
|
|
MODULE_DESCRIPTION("low-level driver for ISA PnP ATA");
|
|
MODULE_LICENSE("GPL");
|
|
MODULE_VERSION(DRV_VERSION);
|
|
|
|
module_init(isapnp_init);
|
|
module_exit(isapnp_exit);
|