a4fb581b15
Currently, the callchains are displayed using a constant left
margin. So depending on the current sort dimension
configuration, callchains may appear to be well attached to the
first sort dimension column field which is mostly the case,
except when the first dimension of sorting is done by comm,
because these are right aligned.
This patch binds the callchain to the first letter in the first
column, whatever type of column it is (dso, comm, symbol).
Before:
0.80% perf [k] __lock_acquire
__lock_acquire
lock_acquire
|
|--58.33%-- _spin_lock
| |
| |--28.57%-- inotify_should_send_event
| | fsnotify
| | __fsnotify_parent
After:
0.80% perf [k] __lock_acquire
__lock_acquire
lock_acquire
|
|--58.33%-- _spin_lock
| |
| |--28.57%-- inotify_should_send_event
| | fsnotify
| | __fsnotify_parent
Also, for clarity, we don't put anymore the callchain as is but:
- If we have a top level ancestor in the callchain, start it
with a first ascii hook.
Before:
0.80% perf [kernel] [k] __lock_acquire
__lock_acquire
lock_acquire
|
|--58.33%-- _spin_lock
| |
| |--28.57%-- inotify_should_send_event
| | fsnotify
[..] [..]
After:
0.80% perf [kernel] [k] __lock_acquire
|
--- __lock_acquire
lock_acquire
|
|--58.33%-- _spin_lock
| |
| |--28.57%-- inotify_should_send_event
| | fsnotify
[..] [..]
- Otherwise, if we have several top level ancestors, then
display these like we did before:
1.69% Xorg
|
|--21.21%-- vread_hpet
| 0x7fffd85b46fc
| 0x7fffd85b494d
| 0x7f4fafb4e54d
|
|--15.15%-- exaOffscreenAlloc
|
|--9.09%-- I830WaitLpRing
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Anton Blanchard <anton@samba.org>
LKML-Reference: <1256246604-17156-2-git-send-email-fweisbec@gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
38 lines
1.0 KiB
C
38 lines
1.0 KiB
C
#ifndef __PERF_THREAD_H
|
|
#define __PERF_THREAD_H
|
|
|
|
#include <linux/rbtree.h>
|
|
#include <unistd.h>
|
|
#include "symbol.h"
|
|
|
|
struct thread {
|
|
struct rb_node rb_node;
|
|
struct rb_root maps;
|
|
struct list_head removed_maps;
|
|
pid_t pid;
|
|
char shortname[3];
|
|
char *comm;
|
|
int comm_len;
|
|
};
|
|
|
|
int thread__set_comm(struct thread *self, const char *comm);
|
|
int thread__comm_len(struct thread *self);
|
|
struct thread *threads__findnew(pid_t pid);
|
|
struct thread *register_idle_thread(void);
|
|
void thread__insert_map(struct thread *self, struct map *map);
|
|
int thread__fork(struct thread *self, struct thread *parent);
|
|
size_t threads__fprintf(FILE *fp);
|
|
|
|
void maps__insert(struct rb_root *maps, struct map *map);
|
|
struct map *maps__find(struct rb_root *maps, u64 ip);
|
|
|
|
struct symbol *kernel_maps__find_symbol(const u64 ip, struct map **mapp);
|
|
struct map *kernel_maps__find_by_dso_name(const char *name);
|
|
|
|
static inline struct map *thread__find_map(struct thread *self, u64 ip)
|
|
{
|
|
return self ? maps__find(&self->maps, ip) : NULL;
|
|
}
|
|
|
|
#endif /* __PERF_THREAD_H */
|