android_kernel_xiaomi_sm8350/fs/jbd2
Jan Kara f5a7a6b0d9 jbd2: Fix assertion failure in fs/jbd2/checkpoint.c
Before we start committing a transaction, we call
__journal_clean_checkpoint_list() to cleanup transaction's written-back
buffers.

If this call happens to remove all of them (and there were already some
buffers), __journal_remove_checkpoint() will decide to free the transaction
because it isn't (yet) a committing transaction and soon we fail some
assertion - the transaction really isn't ready to be freed :).

We change the check in __journal_remove_checkpoint() to free only a
transaction in T_FINISHED state.  The locking there is subtle though (as
everywhere in JBD ;().  We use j_list_lock to protect the check and a
subsequent call to __journal_drop_transaction() and do the same in the end
of journal_commit_transaction() which is the only place where a transaction
can get to T_FINISHED state.

Probably I'm too paranoid here and such locking is not really necessary -
checkpoint lists are processed only from log_do_checkpoint() where a
transaction must be already committed to be processed or from
__journal_clean_checkpoint_list() where kjournald itself calls it and thus
transaction cannot change state either.  Better be safe if something
changes in future...

Signed-off-by: Jan Kara <jack@suse.cz>
Cc: <linux-ext4@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
2008-01-28 23:58:27 -05:00
..
checkpoint.c jbd2: Fix assertion failure in fs/jbd2/checkpoint.c 2008-01-28 23:58:27 -05:00
commit.c jbd2: Fix assertion failure in fs/jbd2/checkpoint.c 2008-01-28 23:58:27 -05:00
journal.c JBD2: debug code cleanup. 2007-10-17 18:49:59 -04:00
Makefile
recovery.c jbd2: JBD_XXX to JBD2_XXX naming cleanup 2007-10-17 18:49:58 -04:00
revoke.c jbd2: JBD_XXX to JBD2_XXX naming cleanup 2007-10-17 18:49:58 -04:00
transaction.c JBD2/Ext4: Convert kmalloc to kzalloc in jbd2/ext4 2007-10-17 18:49:57 -04:00