4a5691c0f7
# reboot ... [ 42.351266] Flash device refused suspend due to active operation (state 0) [ 42.358195] Unable to handle kernel NULL pointer dereference at virtual address 00000078 [ 42.360060] pgd = c7d9c000 [ 42.362769] [00000078] *pgd=a7d8d031, *pte=00000000, *ppte=00000000 [ 42.372902] Internal error: Oops: 17 [#1] [ 42.376911] Modules linked in: [ 42.379980] CPU: 0 Not tainted (2.6.25-rc2-10642-ge8f2594-dirty #73) [ 42.380000] PC is at physmap_flash_shutdown+0x28/0x54 ... [ 42.380000] Backtrace: [ 42.380000] [<c0130c1c>] (physmap_flash_shutdown+0x0/0x54) from [<c01207c0>] (platform_drv_shutdown+0x20/0x24) [ 42.380000] r5:28121969 r4:c0229e08 [ 42.380000] [<c01207a0>] (platform_drv_shutdown+0x0/0x24) from [<c011cd40>] (device_shutdown+0x60/0x88) [ 42.380000] [<c011cce0>] (device_shutdown+0x0/0x88) from [<c003e8a4>] (kernel_restart_prepare+0x2c/0x3c) [ 42.380000] r4:00000000 [ 42.380000] [<c003e878>] (kernel_restart_prepare+0x0/0x3c) from [<c003ea00>] (kernel_restart+0x14/0x48) [ 42.380000] [<c003e9ec>] (kernel_restart+0x0/0x48) from [<c003fdc0>] (sys_reboot+0xe8/0x1f8) [ 42.380000] r4:01234567 [ 42.380000] [<c003fcd8>] (sys_reboot+0x0/0x1f8) from [<c001aa00>] (ret_fast_syscall+0x0/0x2c) [ 42.380000] r7:00000058 r6:00000004 r5:00000001 r4:00000000 [ 42.380000] Code: 0a000009 e7953004 e1a00003 e1a0e00f (e593f078) [ 42.650051] ---[ end trace 6d6c26a0fc3141de ]--- Segmentation fault INIT: no more processes left in this runlevel While looping for mtd[i]s, we should stop at the mtd[i] == NULL. This patch also removes unnecessary "if (info)" checks: suspend/resume/shutdown ops are executed only if probe() is succeeded, so info is guaranteed to be !NULL. Signed-off-by: Anton Vorontsov <cbouatmailru@gmail.com> Cc: David Brownell <david-b@pacbell.net> Cc: David Woodhouse <dwmw2@infradead.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
322 lines
7.6 KiB
C
322 lines
7.6 KiB
C
/*
|
|
* $Id: physmap.c,v 1.39 2005/11/29 14:49:36 gleixner Exp $
|
|
*
|
|
* Normal mappings of chips in physical memory
|
|
*
|
|
* Copyright (C) 2003 MontaVista Software Inc.
|
|
* Author: Jun Sun, jsun@mvista.com or jsun@junsun.net
|
|
*
|
|
* 031022 - [jsun] add run-time configure and partition setup
|
|
*/
|
|
|
|
#include <linux/module.h>
|
|
#include <linux/types.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/init.h>
|
|
#include <linux/slab.h>
|
|
#include <linux/device.h>
|
|
#include <linux/platform_device.h>
|
|
#include <linux/mtd/mtd.h>
|
|
#include <linux/mtd/map.h>
|
|
#include <linux/mtd/partitions.h>
|
|
#include <linux/mtd/physmap.h>
|
|
#include <linux/mtd/concat.h>
|
|
#include <asm/io.h>
|
|
|
|
#define MAX_RESOURCES 4
|
|
|
|
struct physmap_flash_info {
|
|
struct mtd_info *mtd[MAX_RESOURCES];
|
|
struct mtd_info *cmtd;
|
|
struct map_info map[MAX_RESOURCES];
|
|
struct resource *res;
|
|
#ifdef CONFIG_MTD_PARTITIONS
|
|
int nr_parts;
|
|
struct mtd_partition *parts;
|
|
#endif
|
|
};
|
|
|
|
static int physmap_flash_remove(struct platform_device *dev)
|
|
{
|
|
struct physmap_flash_info *info;
|
|
struct physmap_flash_data *physmap_data;
|
|
int i;
|
|
|
|
info = platform_get_drvdata(dev);
|
|
if (info == NULL)
|
|
return 0;
|
|
platform_set_drvdata(dev, NULL);
|
|
|
|
physmap_data = dev->dev.platform_data;
|
|
|
|
#ifdef CONFIG_MTD_CONCAT
|
|
if (info->cmtd != info->mtd[0]) {
|
|
del_mtd_device(info->cmtd);
|
|
mtd_concat_destroy(info->cmtd);
|
|
}
|
|
#endif
|
|
|
|
for (i = 0; i < MAX_RESOURCES; i++) {
|
|
if (info->mtd[i] != NULL) {
|
|
#ifdef CONFIG_MTD_PARTITIONS
|
|
if (info->nr_parts) {
|
|
del_mtd_partitions(info->mtd[i]);
|
|
kfree(info->parts);
|
|
} else if (physmap_data->nr_parts) {
|
|
del_mtd_partitions(info->mtd[i]);
|
|
} else {
|
|
del_mtd_device(info->mtd[i]);
|
|
}
|
|
#else
|
|
del_mtd_device(info->mtd[i]);
|
|
#endif
|
|
map_destroy(info->mtd[i]);
|
|
}
|
|
|
|
if (info->map[i].virt != NULL)
|
|
iounmap(info->map[i].virt);
|
|
}
|
|
|
|
if (info->res != NULL) {
|
|
release_resource(info->res);
|
|
kfree(info->res);
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static const char *rom_probe_types[] = { "cfi_probe", "jedec_probe", "map_rom", NULL };
|
|
#ifdef CONFIG_MTD_PARTITIONS
|
|
static const char *part_probe_types[] = { "cmdlinepart", "RedBoot", NULL };
|
|
#endif
|
|
|
|
static int physmap_flash_probe(struct platform_device *dev)
|
|
{
|
|
struct physmap_flash_data *physmap_data;
|
|
struct physmap_flash_info *info;
|
|
const char **probe_type;
|
|
int err = 0;
|
|
int i;
|
|
int devices_found = 0;
|
|
|
|
physmap_data = dev->dev.platform_data;
|
|
if (physmap_data == NULL)
|
|
return -ENODEV;
|
|
|
|
info = kzalloc(sizeof(struct physmap_flash_info), GFP_KERNEL);
|
|
if (info == NULL) {
|
|
err = -ENOMEM;
|
|
goto err_out;
|
|
}
|
|
|
|
platform_set_drvdata(dev, info);
|
|
|
|
for (i = 0; i < dev->num_resources; i++) {
|
|
printk(KERN_NOTICE "physmap platform flash device: %.8llx at %.8llx\n",
|
|
(unsigned long long)(dev->resource[i].end - dev->resource[i].start + 1),
|
|
(unsigned long long)dev->resource[i].start);
|
|
|
|
info->res = request_mem_region(dev->resource[i].start,
|
|
dev->resource[i].end - dev->resource[i].start + 1,
|
|
dev->dev.bus_id);
|
|
if (info->res == NULL) {
|
|
dev_err(&dev->dev, "Could not reserve memory region\n");
|
|
err = -ENOMEM;
|
|
goto err_out;
|
|
}
|
|
|
|
info->map[i].name = dev->dev.bus_id;
|
|
info->map[i].phys = dev->resource[i].start;
|
|
info->map[i].size = dev->resource[i].end - dev->resource[i].start + 1;
|
|
info->map[i].bankwidth = physmap_data->width;
|
|
info->map[i].set_vpp = physmap_data->set_vpp;
|
|
|
|
info->map[i].virt = ioremap(info->map[i].phys, info->map[i].size);
|
|
if (info->map[i].virt == NULL) {
|
|
dev_err(&dev->dev, "Failed to ioremap flash region\n");
|
|
err = EIO;
|
|
goto err_out;
|
|
}
|
|
|
|
simple_map_init(&info->map[i]);
|
|
|
|
probe_type = rom_probe_types;
|
|
for (; info->mtd[i] == NULL && *probe_type != NULL; probe_type++)
|
|
info->mtd[i] = do_map_probe(*probe_type, &info->map[i]);
|
|
if (info->mtd[i] == NULL) {
|
|
dev_err(&dev->dev, "map_probe failed\n");
|
|
err = -ENXIO;
|
|
goto err_out;
|
|
} else {
|
|
devices_found++;
|
|
}
|
|
info->mtd[i]->owner = THIS_MODULE;
|
|
}
|
|
|
|
if (devices_found == 1) {
|
|
info->cmtd = info->mtd[0];
|
|
} else if (devices_found > 1) {
|
|
/*
|
|
* We detected multiple devices. Concatenate them together.
|
|
*/
|
|
#ifdef CONFIG_MTD_CONCAT
|
|
info->cmtd = mtd_concat_create(info->mtd, devices_found, dev->dev.bus_id);
|
|
if (info->cmtd == NULL)
|
|
err = -ENXIO;
|
|
#else
|
|
printk(KERN_ERR "physmap-flash: multiple devices "
|
|
"found but MTD concat support disabled.\n");
|
|
err = -ENXIO;
|
|
#endif
|
|
}
|
|
if (err)
|
|
goto err_out;
|
|
|
|
#ifdef CONFIG_MTD_PARTITIONS
|
|
err = parse_mtd_partitions(info->cmtd, part_probe_types, &info->parts, 0);
|
|
if (err > 0) {
|
|
add_mtd_partitions(info->cmtd, info->parts, err);
|
|
return 0;
|
|
}
|
|
|
|
if (physmap_data->nr_parts) {
|
|
printk(KERN_NOTICE "Using physmap partition information\n");
|
|
add_mtd_partitions(info->cmtd, physmap_data->parts,
|
|
physmap_data->nr_parts);
|
|
return 0;
|
|
}
|
|
#endif
|
|
|
|
add_mtd_device(info->cmtd);
|
|
return 0;
|
|
|
|
err_out:
|
|
physmap_flash_remove(dev);
|
|
return err;
|
|
}
|
|
|
|
#ifdef CONFIG_PM
|
|
static int physmap_flash_suspend(struct platform_device *dev, pm_message_t state)
|
|
{
|
|
struct physmap_flash_info *info = platform_get_drvdata(dev);
|
|
int ret = 0;
|
|
int i;
|
|
|
|
for (i = 0; i < MAX_RESOURCES && info->mtd[i]; i++)
|
|
ret |= info->mtd[i]->suspend(info->mtd[i]);
|
|
|
|
return ret;
|
|
}
|
|
|
|
static int physmap_flash_resume(struct platform_device *dev)
|
|
{
|
|
struct physmap_flash_info *info = platform_get_drvdata(dev);
|
|
int i;
|
|
|
|
for (i = 0; i < MAX_RESOURCES && info->mtd[i]; i++)
|
|
info->mtd[i]->resume(info->mtd[i]);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static void physmap_flash_shutdown(struct platform_device *dev)
|
|
{
|
|
struct physmap_flash_info *info = platform_get_drvdata(dev);
|
|
int i;
|
|
|
|
for (i = 0; i < MAX_RESOURCES && info->mtd[i]; i++)
|
|
if (info->mtd[i]->suspend(info->mtd[i]) == 0)
|
|
info->mtd[i]->resume(info->mtd[i]);
|
|
}
|
|
#else
|
|
#define physmap_flash_suspend NULL
|
|
#define physmap_flash_resume NULL
|
|
#define physmap_flash_shutdown NULL
|
|
#endif
|
|
|
|
static struct platform_driver physmap_flash_driver = {
|
|
.probe = physmap_flash_probe,
|
|
.remove = physmap_flash_remove,
|
|
.suspend = physmap_flash_suspend,
|
|
.resume = physmap_flash_resume,
|
|
.shutdown = physmap_flash_shutdown,
|
|
.driver = {
|
|
.name = "physmap-flash",
|
|
},
|
|
};
|
|
|
|
|
|
#ifdef CONFIG_MTD_PHYSMAP_LEN
|
|
#if CONFIG_MTD_PHYSMAP_LEN != 0
|
|
#warning using PHYSMAP compat code
|
|
#define PHYSMAP_COMPAT
|
|
#endif
|
|
#endif
|
|
|
|
#ifdef PHYSMAP_COMPAT
|
|
static struct physmap_flash_data physmap_flash_data = {
|
|
.width = CONFIG_MTD_PHYSMAP_BANKWIDTH,
|
|
};
|
|
|
|
static struct resource physmap_flash_resource = {
|
|
.start = CONFIG_MTD_PHYSMAP_START,
|
|
.end = CONFIG_MTD_PHYSMAP_START + CONFIG_MTD_PHYSMAP_LEN - 1,
|
|
.flags = IORESOURCE_MEM,
|
|
};
|
|
|
|
static struct platform_device physmap_flash = {
|
|
.name = "physmap-flash",
|
|
.id = 0,
|
|
.dev = {
|
|
.platform_data = &physmap_flash_data,
|
|
},
|
|
.num_resources = 1,
|
|
.resource = &physmap_flash_resource,
|
|
};
|
|
|
|
void physmap_configure(unsigned long addr, unsigned long size,
|
|
int bankwidth, void (*set_vpp)(struct map_info *, int))
|
|
{
|
|
physmap_flash_resource.start = addr;
|
|
physmap_flash_resource.end = addr + size - 1;
|
|
physmap_flash_data.width = bankwidth;
|
|
physmap_flash_data.set_vpp = set_vpp;
|
|
}
|
|
|
|
#ifdef CONFIG_MTD_PARTITIONS
|
|
void physmap_set_partitions(struct mtd_partition *parts, int num_parts)
|
|
{
|
|
physmap_flash_data.nr_parts = num_parts;
|
|
physmap_flash_data.parts = parts;
|
|
}
|
|
#endif
|
|
#endif
|
|
|
|
static int __init physmap_init(void)
|
|
{
|
|
int err;
|
|
|
|
err = platform_driver_register(&physmap_flash_driver);
|
|
#ifdef PHYSMAP_COMPAT
|
|
if (err == 0)
|
|
platform_device_register(&physmap_flash);
|
|
#endif
|
|
|
|
return err;
|
|
}
|
|
|
|
static void __exit physmap_exit(void)
|
|
{
|
|
#ifdef PHYSMAP_COMPAT
|
|
platform_device_unregister(&physmap_flash);
|
|
#endif
|
|
platform_driver_unregister(&physmap_flash_driver);
|
|
}
|
|
|
|
module_init(physmap_init);
|
|
module_exit(physmap_exit);
|
|
|
|
MODULE_LICENSE("GPL");
|
|
MODULE_AUTHOR("David Woodhouse <dwmw2@infradead.org>");
|
|
MODULE_DESCRIPTION("Generic configurable MTD map driver");
|