Jeff Layton ca456252db knfsd: clear both setuid and setgid whenever a chown is done ... Currently, knfsd only clears the setuid bit if the owner of a file is changed on a SETATTR call, and only clears the setgid bit if the group is changed. POSIX says this in the spec for chown(): "If the specified file is a regular file, one or more of the S_IXUSR, S_IXGRP, or S_IXOTH bits of the file mode are set, and the process does not have appropriate privileges, the set-user-ID (S_ISUID) and set-group-ID (S_ISGID) bits of the file mode shall be cleared upon successful return from chown()." If I'm reading this correctly, then knfsd is doing this wrong. It should be clearing both the setuid and setgid bit on any SETATTR that changes the uid or gid. This wasn't really as noticable before, but now that the ATTR_KILL_S*ID bits are a no-op for the NFS client, it's more evident. This patch corrects the nfsd_setattr logic so that this occurs. It also does a bit of cleanup to the function. There is also one small behavioral change. If a SETATTR call comes in that changes the uid/gid and the mode, then we now only clear the setgid bit if the group execute bit isn't set. The setgid bit without a group execute bit signifies mandatory locking and we likely don't want to clear the bit in that case. Since there is no call in POSIX that should generate a SETATTR call like this, then this should rarely happen, but it's worth noting. Signed-off-by: Jeff Layton <jlayton@redhat.com> Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>		2008-04-23 16:13:43 -04:00
..
9p	fs: Remove unnecessary inclusions of asm/semaphore.h	2008-04-18 22:16:44 -04:00
adfs	mount options: fix adfs	2008-02-08 09:22:39 -08:00
affs	mount options: fix affs	2008-02-08 09:22:39 -08:00
afs	AFS: Do not describe debug parameters with their value	2008-04-16 07:43:48 -07:00
autofs	mount options: fix autofs	2008-02-08 09:22:40 -08:00
autofs4	Introduce path_put()	2008-02-14 21:13:33 -08:00
befs	mount options: fix befs	2008-02-08 09:22:40 -08:00
bfs
cifs	cifs: fix misannotations	2008-03-30 14:20:23 -07:00
coda	Introduce path_put()	2008-02-14 21:13:33 -08:00
configfs	Introduce path_put()	2008-02-14 21:13:33 -08:00
cramfs	fs: Remove unnecessary inclusions of asm/semaphore.h	2008-04-18 22:16:44 -04:00
debugfs	debugfs: fix sparse warnings	2008-03-04 14:47:06 -08:00
devpts	mount options: fix devpts	2008-02-08 09:22:40 -08:00
dlm	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/teigland/dlm	2008-04-22 13:44:23 -07:00
ecryptfs	eCryptfs: Swap dput() and mntput()	2008-03-19 18:53:36 -07:00
efs	efs: update error msg to not refer to deleted read_inode()	2008-04-02 15:28:19 -07:00
exportfs
ext2	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/juhl/trivial	2008-04-21 16:36:46 -07:00
ext3	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/juhl/trivial	2008-04-21 16:36:46 -07:00
ext4	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/juhl/trivial	2008-04-21 16:36:46 -07:00
fat	[PATCH] r/o bind mounts: elevate write count for ioctls()	2008-04-19 00:29:24 -04:00
freevxfs
fuse	fuse: fix permission checking	2008-02-23 17:12:13 -08:00
gfs2	dlm: move plock code from gfs2	2008-04-21 11:22:28 -05:00
hfs	hfs_bnode_find() can fail, resulting in hfs_bnode_split() breakage	2008-03-17 09:46:55 -07:00
hfsplus	[PATCH] r/o bind mounts: elevate write count for ioctls()	2008-04-19 00:29:24 -04:00
hostfs	uml: fix hostfs tv_usec calculations	2008-02-05 09:44:30 -08:00
hpfs	mount options: fix hpfs	2008-02-08 09:22:40 -08:00
hppfs	[PATCH] sanitize hppfs	2008-03-19 06:42:18 -04:00
hugetlbfs	[PATCH] double iput() on failure exit in hugetlb	2008-03-19 06:55:01 -04:00
isofs	zisofs: fix readpage() outside i_size	2008-03-19 18:53:36 -07:00
jbd	jbd/jbd2 NULL noise	2008-03-30 14:18:41 -07:00
jbd2	jbd/jbd2 NULL noise	2008-03-30 14:18:41 -07:00
jffs2	Convert asm/semaphore.h users to linux/semaphore.h	2008-04-18 22:22:54 -04:00
jfs	[PATCH] r/o bind mounts: elevate write count for ioctls()	2008-04-19 00:29:24 -04:00
lockd	NLM: don't let lockd exit on unexpected svc_recv errors (try #2)	2008-04-23 16:13:43 -04:00
minix
msdos
ncpfs	[PATCH] r/o bind mounts: elevate write count for ncp_ioctl()	2008-04-19 00:29:23 -04:00
nfs	NFS: don't let nfs_callback_svc exit on unexpected svc_recv errors (try #2)	2008-04-23 16:13:42 -04:00
nfs_common
nfsd	knfsd: clear both setuid and setgid whenever a chown is done	2008-04-23 16:13:43 -04:00
nls
ntfs	is_vmalloc_addr(): Check if an address is within the vmalloc boundaries	2008-02-05 09:44:14 -08:00
ocfs2	[PATCH] r/o bind mounts: elevate write count for ioctls()	2008-04-19 00:29:24 -04:00
openpromfs
partitions	block: send disk "change" event for rescan_partitions()	2008-04-19 19:10:24 -07:00
proc	[patch 6/7] vfs: mountinfo: add /proc/<pid>/mountinfo	2008-04-23 00:05:03 -04:00
qnx4
ramfs
reiserfs	Merge branch 'semaphore' of git://git.kernel.org/pub/scm/linux/kernel/git/willy/misc	2008-04-21 15:41:27 -07:00
romfs	ROMFS: Fix up an error in iget removal	2008-03-19 18:53:36 -07:00
smbfs	NULL noise: fs/*, mm/*, kernel/*	2008-03-30 14:18:41 -07:00
sysfs	sysfs: refill attribute buffer when reading from offset 0	2008-04-19 19:10:29 -07:00
sysv
udf	udf: use crc_itu_t from lib instead of udf_crc	2008-04-17 14:29:56 +02:00
ufs	fs/ufs/balloc.c: fix sparc64 printk warning	2008-03-19 18:53:37 -07:00
vfat
xfs	Merge branch 'semaphore' of git://git.kernel.org/pub/scm/linux/kernel/git/willy/misc	2008-04-21 15:41:27 -07:00
aio.c	eventfd/kaio integration fix	2008-04-11 08:06:43 -07:00
anon_inodes.c	[PATCH] fix up new filp allocators	2008-03-19 06:54:05 -04:00
attr.c
bad_inode.c
binfmt_aout.c	aout: suppress A.OUT library support if !CONFIG_ARCH_SUPPORTS_AOUT	2008-02-08 09:22:30 -08:00
binfmt_elf_fdpic.c
binfmt_elf.c	core dump: user_regset writeback	2008-03-04 16:35:10 -08:00
binfmt_em86.c
binfmt_flat.c	FLAT binaries: drop BINFMT_FLAT bad header magic warning	2008-02-14 20:58:05 -08:00
binfmt_misc.c
binfmt_script.c
binfmt_som.c	aout: remove unnecessary inclusions of {asm, linux}/a.out.h	2008-02-08 09:22:30 -08:00
bio.c	block: convert bio_copy_user to bio_copy_user_iov	2008-04-21 09:50:08 +02:00
block_dev.c	fs/block_dev.c: remove #if 0'ed code	2008-02-19 10:04:00 +01:00
buffer.c	Be more careful about marking buffers dirty	2008-04-04 14:38:17 -07:00
char_dev.c	fs/char_dev.c: chrdev_open marked static and removed from fs.h	2008-02-08 09:22:42 -08:00
compat_binfmt_elf.c
compat_ioctl.c	d_path: Make d_path() use a struct path	2008-02-14 21:17:09 -08:00
compat.c	Merge branch 'linus_origin' into hotfixes	2008-02-15 13:36:30 -05:00
dcache.c	[patch 2/7] vfs: mountinfo: add seq_file_root()	2008-04-23 00:04:38 -04:00
dcookies.c	d_path: Make d_path() use a struct path	2008-02-14 21:17:09 -08:00
direct-io.c	Pagecache zeroing: zero_user_segment, zero_user_segments and zero_user	2008-02-05 09:44:13 -08:00
dnotify.c
dquot.c	quota: add possibly missing iput() when quotaon and quotaoff races	2008-03-19 18:53:35 -07:00
drop_caches.c
eventfd.c
eventpoll.c	lockdep: annotate epoll	2008-02-05 09:44:07 -08:00
exec.c	Allow ARG_MAX execve string space even with a small stack limit	2008-03-03 10:12:14 -08:00
fcntl.c	fs: remove fastcall, it is always empty	2008-02-08 09:22:31 -08:00
fifo.c
file_table.c	[PATCH] r/o bind mounts: debugging for missed calls	2008-04-19 00:29:28 -04:00
file.c
filesystems.c
fs-writeback.c	fs: fix kernel-doc notation warnings	2008-03-19 18:53:36 -07:00
generic_acl.c
inode.c	[PATCH] r/o bind mounts: write count for file_update_time()	2008-04-19 00:29:24 -04:00
inotify_user.c	Introduce path_put()	2008-02-14 21:13:33 -08:00
inotify.c
internal.h	[PATCH] move a bunch of declarations to fs/internal.h	2008-04-21 23:11:01 -04:00
ioctl.c	fix up kerneldoc in fs/ioctl.c a little bit	2008-02-09 11:08:33 -08:00
ioprio.c
Kconfig	NFSD: Remove NFSv4 dependency on NFSv3	2008-04-23 16:13:41 -04:00
Kconfig.binfmt	[SPARC]: Remove SunOS and Solaris binary support.	2008-04-21 15:10:15 -07:00
libfs.c	Pagecache zeroing: zero_user_segment, zero_user_segments and zero_user	2008-02-05 09:44:13 -08:00
locks.c	fs: Remove unnecessary inclusions of asm/semaphore.h	2008-04-18 22:16:44 -04:00
Makefile
mbcache.c	vfs: fix possible deadlock in ext2, ext3, ext4 when using xattrs	2008-04-15 19:35:41 -07:00
mpage.c	docbook: fix filesystems.tmpl source files	2008-03-03 10:47:13 -08:00
namei.c	[PATCH] r/o bind mounts: elevate write count for open()s	2008-04-19 00:29:25 -04:00
namespace.c	[patch 7/7] vfs: mountinfo: show dominating group id	2008-04-23 00:05:09 -04:00
nfsctl.c	Introduce path_put()	2008-02-14 21:13:33 -08:00
no-block.c
open.c	[PATCH] r/o bind mounts: debugging for missed calls	2008-04-19 00:29:28 -04:00
pipe.c	[PATCH] double-free of inode on alloc_file() failure exit in create_write_pipe()	2008-04-22 19:54:57 -04:00
pnode.c	[patch 7/7] vfs: mountinfo: show dominating group id	2008-04-23 00:05:09 -04:00
pnode.h	[patch 7/7] vfs: mountinfo: show dominating group id	2008-04-23 00:05:09 -04:00
posix_acl.c
quota_v1.c
quota_v2.c
quota.c
read_write.c	fs: use loff_t type instead of long long	2008-04-22 15:17:11 -07:00
read_write.h
readdir.c
select.c	trivial: small cleanups	2008-04-21 22:15:06 +00:00
seq_file.c	[patch 2/7] vfs: mountinfo: add seq_file_root()	2008-04-23 00:04:38 -04:00
signalfd.c	signalfd: fix for incorrect SI_QUEUE user data reporting	2008-04-11 08:06:44 -07:00
splice.c	splice: fix infinite loop in generic_file_splice_read()	2008-04-10 08:24:25 +02:00
stack.c
stat.c	Introduce path_put()	2008-02-14 21:13:33 -08:00
super.c	[PATCH] move a bunch of declarations to fs/internal.h	2008-04-21 23:11:01 -04:00
sync.c
timerfd.c	timerfd: new timerfd API	2008-02-05 09:44:07 -08:00
utimes.c	[PATCH] r/o bind mounts: elevate write count for do_utimes()	2008-04-19 00:29:24 -04:00
xattr_acl.c
xattr.c	[PATCH] remove unused label in xattr.c (noise from ro-bind)	2008-04-23 00:04:04 -04:00