99b7623380
Setting ->owner as done currently (pde->owner = THIS_MODULE) is racy as correctly noted at bug #12454. Someone can lookup entry with NULL ->owner, thus not pinning enything, and release it later resulting in module refcount underflow. We can keep ->owner and supply it at registration time like ->proc_fops and ->data. But this leaves ->owner as easy-manipulative field (just one C assignment) and somebody will forget to unpin previous/pin current module when switching ->owner. ->proc_fops is declared as "const" which should give some thoughts. ->read_proc/->write_proc were just fixed to not require ->owner for protection. rmmod'ed directories will be empty and return "." and ".." -- no harm. And directories with tricky enough readdir and lookup shouldn't be modular. We definitely don't want such modular code. Removing ->owner will also make PDE smaller. So, let's nuke it. Kudos to Jeff Layton for reminding about this, let's say, oversight. http://bugzilla.kernel.org/show_bug.cgi?id=12454 Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com> |
||
|---|---|---|
| .. | ||
| .gitignore | ||
| alsa-driver-api.tmpl | ||
| debugobjects.tmpl | ||
| device-drivers.tmpl | ||
| deviceiobook.tmpl | ||
| filesystems.tmpl | ||
| gadget.tmpl | ||
| genericirq.tmpl | ||
| kernel-api.tmpl | ||
| kernel-hacking.tmpl | ||
| kernel-locking.tmpl | ||
| kgdb.tmpl | ||
| libata.tmpl | ||
| librs.tmpl | ||
| lsm.tmpl | ||
| mac80211.tmpl | ||
| Makefile | ||
| mcabook.tmpl | ||
| mtdnand.tmpl | ||
| networking.tmpl | ||
| procfs_example.c | ||
| procfs-guide.tmpl | ||
| rapidio.tmpl | ||
| regulator.tmpl | ||
| s390-drivers.tmpl | ||
| scsi.tmpl | ||
| sh.tmpl | ||
| stylesheet.xsl | ||
| uio-howto.tmpl | ||
| usb.tmpl | ||
| writing_usb_driver.tmpl | ||
| writing-an-alsa-driver.tmpl | ||
| z8530book.tmpl | ||