android_kernel_xiaomi_sm8350/Documentation/fb
Jean Delvare 0728bacbba matroxfb: make CONFIG_FB_MATROX_MULTIHEAD=y mandatory
I would like to get rid of option CONFIG_FB_MATROX_MULTIHEAD and just
always enable it.  There are many reasons for doing this:

* CONFIG_FB_MATROX_MULTIHEAD=y is what all x86 distributions do, so it
  definitely works or we would know by now.

* Building the matroxfb driver with CONFIG_FB_MATROX_MULTIHEAD not set
  results in the following build warning:

drivers/video/matrox/matroxfb_crtc2.c: In function 'matroxfb_dh_open':
drivers/video/matrox/matroxfb_crtc2.c:265: warning: the address of 'matroxfb_global_mxinfo' will always evaluate as 'true'
drivers/video/matrox/matroxfb_crtc2.c: In function 'matroxfb_dh_release':
drivers/video/matrox/matroxfb_crtc2.c:285: warning: the address of 'matroxfb_global_mxinfo' will always evaluate as 'true'

This is nothing to be worried about, the driver will work fine, but build
warnings are still annoying.

* The trick to get multihead support without CONFIG_FB_MATROX_MULTIHEAD,
  which is described in the config help text, no longer works: you can't
  load the same kernel module more than once.

* I fail to see how CONFIG_FB_MATROX_MULTIHEAD=y would make the code
  significantly slower, contrary to what the help text says.  A few extra
  parameters on the stack here and there can't really slow things down in
  comaprison to the rest of the code, and register access.

* The driver built without CONFIG_FB_MATROX_MULTIHEAD is larger than the
  driver build with CONFIG_FB_MATROX_MULTIHEAD=y by 8%.

* One less configuration option makes things simpler.  We add options
  all the time, being able to remove one for once is nice.  It improves
  testing coverage.  And I don't think the Matrox adapters are still
  popular enough to warrant overdetailed configuration settings.

* We should be able to unobfuscate the driver code quite a bit after
  this change (patches follow.)

Signed-off-by: Jean Delvare <khali@linux-fr.org>
Acked-by: Petr Vandrovec <vandrove@vc.cvut.cz>
Cc: Krzysztof Helt <krzysztof.h1@poczta.fm>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2009-09-23 07:39:56 -07:00
..
00-INDEX fbdev: remove cyblafb driver 2009-04-01 08:59:33 -07:00
arkfb.txt
aty128fb.txt
cirrusfb.txt
cmap_xfbdev.txt
deferred_io.txt
ep93xx-fb.txt ep93xx video driver 2009-09-23 07:39:51 -07:00
fbcon.txt
framebuffer.txt
gxfb.txt
imacfb.txt
intel810.txt
intelfb.txt intelfb: support 945GME (as used in ASUS Eee 901) 2008-10-16 11:21:42 -07:00
internals.txt
lxfb.txt lxfb: disable suspend VT switch by default 2008-04-28 08:58:39 -07:00
matroxfb.txt matroxfb: make CONFIG_FB_MATROX_MULTIHEAD=y mandatory 2009-09-23 07:39:56 -07:00
metronomefb.txt fbdev: platforming metronomefb and am200epd 2008-04-28 08:58:41 -07:00
modedb.txt update modedb.txt documentation about mode_option parameter change 2008-04-28 08:58:37 -07:00
pvr2fb.txt
pxafb.txt [ARM] pxafb: add support for overlay1 and overlay2 as framebuffer devices 2008-12-29 18:00:04 +08:00
s3fb.txt
sa1100fb.txt
sh7760fb.txt trivial: Miscellaneous documentation typo fixes 2009-06-12 18:01:47 +02:00
sisfb.txt
sstfb.txt
tgafb.txt
tridentfb.txt tridentfb: documentation update 2008-07-24 10:47:37 -07:00
uvesafb.txt uvesafb: documentation update 2009-04-07 08:31:09 -07:00
vesafb.txt Documentation/fb/vesafb.txt: fix typo 2009-06-16 19:47:58 -07:00
viafb.modes viafb: viafb.modes, viafb.txt 2008-10-16 11:21:41 -07:00
viafb.txt viafb: viafb.modes, viafb.txt 2008-10-16 11:21:41 -07:00
vt8623fb.txt