f7823f8f43
cx18: Reduce number of mmio read retries to improve performance. Experiments have shown 2 things: read retries never improve the result of a suspect mmio read from the CX23418 (the result stays all 0xff's), and that most of the suspected read failures are actually proper reads of values that should be all 0xff's. This change reduces the number of read retries and keeps the count separate from write retries. Signed-off-by: Andy Walls <awalls@radix.net> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
396 lines
9.5 KiB
C
396 lines
9.5 KiB
C
/*
|
|
* cx18 driver PCI memory mapped IO access routines
|
|
*
|
|
* Copyright (C) 2007 Hans Verkuil <hverkuil@xs4all.nl>
|
|
* Copyright (C) 2008 Andy Walls <awalls@radix.net>
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, write to the Free Software
|
|
* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
|
|
* 02111-1307 USA
|
|
*/
|
|
|
|
#ifndef CX18_IO_H
|
|
#define CX18_IO_H
|
|
|
|
#include "cx18-driver.h"
|
|
|
|
static inline void cx18_io_delay(struct cx18 *cx)
|
|
{
|
|
if (cx->options.mmio_ndelay)
|
|
ndelay(cx->options.mmio_ndelay);
|
|
}
|
|
|
|
/*
|
|
* Readback and retry of MMIO access for reliability:
|
|
* The concept was suggested by Steve Toth <stoth@linuxtv.org>.
|
|
* The implmentation is the fault of Andy Walls <awalls@radix.net>.
|
|
*/
|
|
|
|
/* Statistics gathering */
|
|
static inline
|
|
void cx18_log_write_retries(struct cx18 *cx, int i, const void __iomem *addr)
|
|
{
|
|
if (i > CX18_MAX_MMIO_WR_RETRIES)
|
|
i = CX18_MAX_MMIO_WR_RETRIES;
|
|
atomic_inc(&cx->mmio_stats.retried_write[i]);
|
|
return;
|
|
}
|
|
|
|
static inline
|
|
void cx18_log_read_retries(struct cx18 *cx, int i, const void __iomem *addr)
|
|
{
|
|
if (i > CX18_MAX_MMIO_RD_RETRIES)
|
|
i = CX18_MAX_MMIO_RD_RETRIES;
|
|
atomic_inc(&cx->mmio_stats.retried_read[i]);
|
|
return;
|
|
}
|
|
|
|
void cx18_log_statistics(struct cx18 *cx);
|
|
|
|
/* Non byteswapping memory mapped IO */
|
|
static inline
|
|
void cx18_raw_writel_noretry(struct cx18 *cx, u32 val, void __iomem *addr)
|
|
{
|
|
__raw_writel(val, addr);
|
|
cx18_io_delay(cx);
|
|
}
|
|
|
|
void cx18_raw_writel_retry(struct cx18 *cx, u32 val, void __iomem *addr);
|
|
|
|
static inline void cx18_raw_writel(struct cx18 *cx, u32 val, void __iomem *addr)
|
|
{
|
|
if (cx18_retry_mmio)
|
|
cx18_raw_writel_retry(cx, val, addr);
|
|
else
|
|
cx18_raw_writel_noretry(cx, val, addr);
|
|
}
|
|
|
|
|
|
static inline
|
|
u32 cx18_raw_readl_noretry(struct cx18 *cx, const void __iomem *addr)
|
|
{
|
|
u32 ret = __raw_readl(addr);
|
|
cx18_io_delay(cx);
|
|
return ret;
|
|
}
|
|
|
|
u32 cx18_raw_readl_retry(struct cx18 *cx, const void __iomem *addr);
|
|
|
|
static inline u32 cx18_raw_readl(struct cx18 *cx, const void __iomem *addr)
|
|
{
|
|
if (cx18_retry_mmio)
|
|
return cx18_raw_readl_retry(cx, addr);
|
|
|
|
return cx18_raw_readl_noretry(cx, addr);
|
|
}
|
|
|
|
|
|
static inline
|
|
u16 cx18_raw_readw_noretry(struct cx18 *cx, const void __iomem *addr)
|
|
{
|
|
u16 ret = __raw_readw(addr);
|
|
cx18_io_delay(cx);
|
|
return ret;
|
|
}
|
|
|
|
u16 cx18_raw_readw_retry(struct cx18 *cx, const void __iomem *addr);
|
|
|
|
static inline u16 cx18_raw_readw(struct cx18 *cx, const void __iomem *addr)
|
|
{
|
|
if (cx18_retry_mmio)
|
|
return cx18_raw_readw_retry(cx, addr);
|
|
|
|
return cx18_raw_readw_noretry(cx, addr);
|
|
}
|
|
|
|
|
|
/* Normal memory mapped IO */
|
|
static inline
|
|
void cx18_writel_noretry(struct cx18 *cx, u32 val, void __iomem *addr)
|
|
{
|
|
writel(val, addr);
|
|
cx18_io_delay(cx);
|
|
}
|
|
|
|
void cx18_writel_retry(struct cx18 *cx, u32 val, void __iomem *addr);
|
|
|
|
static inline void cx18_writel(struct cx18 *cx, u32 val, void __iomem *addr)
|
|
{
|
|
if (cx18_retry_mmio)
|
|
cx18_writel_retry(cx, val, addr);
|
|
else
|
|
cx18_writel_noretry(cx, val, addr);
|
|
}
|
|
|
|
void _cx18_writel_expect(struct cx18 *cx, u32 val, void __iomem *addr,
|
|
u32 eval, u32 mask);
|
|
|
|
static inline
|
|
void cx18_writew_noretry(struct cx18 *cx, u16 val, void __iomem *addr)
|
|
{
|
|
writew(val, addr);
|
|
cx18_io_delay(cx);
|
|
}
|
|
|
|
void cx18_writew_retry(struct cx18 *cx, u16 val, void __iomem *addr);
|
|
|
|
static inline void cx18_writew(struct cx18 *cx, u16 val, void __iomem *addr)
|
|
{
|
|
if (cx18_retry_mmio)
|
|
cx18_writew_retry(cx, val, addr);
|
|
else
|
|
cx18_writew_noretry(cx, val, addr);
|
|
}
|
|
|
|
|
|
static inline
|
|
void cx18_writeb_noretry(struct cx18 *cx, u8 val, void __iomem *addr)
|
|
{
|
|
writeb(val, addr);
|
|
cx18_io_delay(cx);
|
|
}
|
|
|
|
void cx18_writeb_retry(struct cx18 *cx, u8 val, void __iomem *addr);
|
|
|
|
static inline void cx18_writeb(struct cx18 *cx, u8 val, void __iomem *addr)
|
|
{
|
|
if (cx18_retry_mmio)
|
|
cx18_writeb_retry(cx, val, addr);
|
|
else
|
|
cx18_writeb_noretry(cx, val, addr);
|
|
}
|
|
|
|
|
|
static inline u32 cx18_readl_noretry(struct cx18 *cx, const void __iomem *addr)
|
|
{
|
|
u32 ret = readl(addr);
|
|
cx18_io_delay(cx);
|
|
return ret;
|
|
}
|
|
|
|
u32 cx18_readl_retry(struct cx18 *cx, const void __iomem *addr);
|
|
|
|
static inline u32 cx18_readl(struct cx18 *cx, const void __iomem *addr)
|
|
{
|
|
if (cx18_retry_mmio)
|
|
return cx18_readl_retry(cx, addr);
|
|
|
|
return cx18_readl_noretry(cx, addr);
|
|
}
|
|
|
|
|
|
static inline u16 cx18_readw_noretry(struct cx18 *cx, const void __iomem *addr)
|
|
{
|
|
u16 ret = readw(addr);
|
|
cx18_io_delay(cx);
|
|
return ret;
|
|
}
|
|
|
|
u16 cx18_readw_retry(struct cx18 *cx, const void __iomem *addr);
|
|
|
|
static inline u16 cx18_readw(struct cx18 *cx, const void __iomem *addr)
|
|
{
|
|
if (cx18_retry_mmio)
|
|
return cx18_readw_retry(cx, addr);
|
|
|
|
return cx18_readw_noretry(cx, addr);
|
|
}
|
|
|
|
|
|
static inline u8 cx18_readb_noretry(struct cx18 *cx, const void __iomem *addr)
|
|
{
|
|
u8 ret = readb(addr);
|
|
cx18_io_delay(cx);
|
|
return ret;
|
|
}
|
|
|
|
u8 cx18_readb_retry(struct cx18 *cx, const void __iomem *addr);
|
|
|
|
static inline u8 cx18_readb(struct cx18 *cx, const void __iomem *addr)
|
|
{
|
|
if (cx18_retry_mmio)
|
|
return cx18_readb_retry(cx, addr);
|
|
|
|
return cx18_readb_noretry(cx, addr);
|
|
}
|
|
|
|
|
|
static inline
|
|
u32 cx18_write_sync_noretry(struct cx18 *cx, u32 val, void __iomem *addr)
|
|
{
|
|
cx18_writel_noretry(cx, val, addr);
|
|
return cx18_readl_noretry(cx, addr);
|
|
}
|
|
|
|
static inline
|
|
u32 cx18_write_sync_retry(struct cx18 *cx, u32 val, void __iomem *addr)
|
|
{
|
|
cx18_writel_retry(cx, val, addr);
|
|
return cx18_readl_retry(cx, addr);
|
|
}
|
|
|
|
static inline u32 cx18_write_sync(struct cx18 *cx, u32 val, void __iomem *addr)
|
|
{
|
|
if (cx18_retry_mmio)
|
|
return cx18_write_sync_retry(cx, val, addr);
|
|
|
|
return cx18_write_sync_noretry(cx, val, addr);
|
|
}
|
|
|
|
|
|
void cx18_memcpy_fromio(struct cx18 *cx, void *to,
|
|
const void __iomem *from, unsigned int len);
|
|
void cx18_memset_io(struct cx18 *cx, void __iomem *addr, int val, size_t count);
|
|
|
|
|
|
/* Access "register" region of CX23418 memory mapped I/O */
|
|
static inline void cx18_write_reg_noretry(struct cx18 *cx, u32 val, u32 reg)
|
|
{
|
|
cx18_writel_noretry(cx, val, cx->reg_mem + reg);
|
|
}
|
|
|
|
static inline void cx18_write_reg_retry(struct cx18 *cx, u32 val, u32 reg)
|
|
{
|
|
cx18_writel_retry(cx, val, cx->reg_mem + reg);
|
|
}
|
|
|
|
static inline void cx18_write_reg(struct cx18 *cx, u32 val, u32 reg)
|
|
{
|
|
if (cx18_retry_mmio)
|
|
cx18_write_reg_retry(cx, val, reg);
|
|
else
|
|
cx18_write_reg_noretry(cx, val, reg);
|
|
}
|
|
|
|
static inline void _cx18_write_reg_expect(struct cx18 *cx, u32 val, u32 reg,
|
|
u32 eval, u32 mask)
|
|
{
|
|
_cx18_writel_expect(cx, val, cx->reg_mem + reg, eval, mask);
|
|
}
|
|
|
|
static inline void cx18_write_reg_expect(struct cx18 *cx, u32 val, u32 reg,
|
|
u32 eval, u32 mask)
|
|
{
|
|
if (cx18_retry_mmio)
|
|
_cx18_write_reg_expect(cx, val, reg, eval, mask);
|
|
else
|
|
cx18_write_reg_noretry(cx, val, reg);
|
|
}
|
|
|
|
|
|
static inline u32 cx18_read_reg_noretry(struct cx18 *cx, u32 reg)
|
|
{
|
|
return cx18_readl_noretry(cx, cx->reg_mem + reg);
|
|
}
|
|
|
|
static inline u32 cx18_read_reg_retry(struct cx18 *cx, u32 reg)
|
|
{
|
|
return cx18_readl_retry(cx, cx->reg_mem + reg);
|
|
}
|
|
|
|
static inline u32 cx18_read_reg(struct cx18 *cx, u32 reg)
|
|
{
|
|
if (cx18_retry_mmio)
|
|
return cx18_read_reg_retry(cx, reg);
|
|
|
|
return cx18_read_reg_noretry(cx, reg);
|
|
}
|
|
|
|
|
|
static inline u32 cx18_write_reg_sync_noretry(struct cx18 *cx, u32 val, u32 reg)
|
|
{
|
|
return cx18_write_sync_noretry(cx, val, cx->reg_mem + reg);
|
|
}
|
|
|
|
static inline u32 cx18_write_reg_sync_retry(struct cx18 *cx, u32 val, u32 reg)
|
|
{
|
|
return cx18_write_sync_retry(cx, val, cx->reg_mem + reg);
|
|
}
|
|
|
|
static inline u32 cx18_write_reg_sync(struct cx18 *cx, u32 val, u32 reg)
|
|
{
|
|
if (cx18_retry_mmio)
|
|
return cx18_write_reg_sync_retry(cx, val, reg);
|
|
|
|
return cx18_write_reg_sync_noretry(cx, val, reg);
|
|
}
|
|
|
|
|
|
/* Access "encoder memory" region of CX23418 memory mapped I/O */
|
|
static inline void cx18_write_enc_noretry(struct cx18 *cx, u32 val, u32 addr)
|
|
{
|
|
cx18_writel_noretry(cx, val, cx->enc_mem + addr);
|
|
}
|
|
|
|
static inline void cx18_write_enc_retry(struct cx18 *cx, u32 val, u32 addr)
|
|
{
|
|
cx18_writel_retry(cx, val, cx->enc_mem + addr);
|
|
}
|
|
|
|
static inline void cx18_write_enc(struct cx18 *cx, u32 val, u32 addr)
|
|
{
|
|
if (cx18_retry_mmio)
|
|
cx18_write_enc_retry(cx, val, addr);
|
|
else
|
|
cx18_write_enc_noretry(cx, val, addr);
|
|
}
|
|
|
|
|
|
static inline u32 cx18_read_enc_noretry(struct cx18 *cx, u32 addr)
|
|
{
|
|
return cx18_readl_noretry(cx, cx->enc_mem + addr);
|
|
}
|
|
|
|
static inline u32 cx18_read_enc_retry(struct cx18 *cx, u32 addr)
|
|
{
|
|
return cx18_readl_retry(cx, cx->enc_mem + addr);
|
|
}
|
|
|
|
static inline u32 cx18_read_enc(struct cx18 *cx, u32 addr)
|
|
{
|
|
if (cx18_retry_mmio)
|
|
return cx18_read_enc_retry(cx, addr);
|
|
|
|
return cx18_read_enc_noretry(cx, addr);
|
|
}
|
|
|
|
static inline
|
|
u32 cx18_write_enc_sync_noretry(struct cx18 *cx, u32 val, u32 addr)
|
|
{
|
|
return cx18_write_sync_noretry(cx, val, cx->enc_mem + addr);
|
|
}
|
|
|
|
static inline
|
|
u32 cx18_write_enc_sync_retry(struct cx18 *cx, u32 val, u32 addr)
|
|
{
|
|
return cx18_write_sync_retry(cx, val, cx->enc_mem + addr);
|
|
}
|
|
|
|
static inline
|
|
u32 cx18_write_enc_sync(struct cx18 *cx, u32 val, u32 addr)
|
|
{
|
|
if (cx18_retry_mmio)
|
|
return cx18_write_enc_sync_retry(cx, val, addr);
|
|
|
|
return cx18_write_enc_sync_noretry(cx, val, addr);
|
|
}
|
|
|
|
void cx18_sw1_irq_enable(struct cx18 *cx, u32 val);
|
|
void cx18_sw1_irq_disable(struct cx18 *cx, u32 val);
|
|
void cx18_sw2_irq_enable(struct cx18 *cx, u32 val);
|
|
void cx18_sw2_irq_disable(struct cx18 *cx, u32 val);
|
|
void cx18_setup_page(struct cx18 *cx, u32 addr);
|
|
|
|
#endif /* CX18_IO_H */
|