From ccac8c4f6ea8649c3c08a658a09cda8a94c0aa5e Mon Sep 17 00:00:00 2001
From: Bill Somerville <bill@classdesign.com>
Date: Wed, 3 Jul 2019 00:03:02 +0100
Subject: [PATCH 1/4] Squash a couple of warnings

---
 Audio/BWFFile.cpp | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Audio/BWFFile.cpp b/Audio/BWFFile.cpp
index e293cbb3f..45de7cdc6 100644
--- a/Audio/BWFFile.cpp
+++ b/Audio/BWFFile.cpp
@@ -354,6 +354,7 @@ bool BWFFile::impl::update_header ()
             {
             case BextVersion::v_0:
               data->version_ = qToBigEndian<quint32> (data->version_);
+              // fall through
             default:
               data->loudness_value_ = qToBigEndian<quint16> (data->loudness_value_);
               data->loudness_range_ = qToBigEndian<quint16> (data->loudness_range_);
@@ -370,6 +371,7 @@ bool BWFFile::impl::update_header ()
             {
             case BextVersion::v_0:
               data->version_ = qToLittleEndian<quint32> (data->version_);
+              // fall through
             default:
               data->loudness_value_ = qToLittleEndian<quint16> (data->loudness_value_);
               data->loudness_range_ = qToLittleEndian<quint16> (data->loudness_range_);

From a9fd0730237e1ddb5f113b07491c2acab127ed3a Mon Sep 17 00:00:00 2001
From: Bill Somerville <bill@classdesign.com>
Date: Wed, 3 Jul 2019 00:15:48 +0100
Subject: [PATCH 2/4] Squash a compiler warning

---
 Network/NetworkServerLookup.cpp | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/Network/NetworkServerLookup.cpp b/Network/NetworkServerLookup.cpp
index 3e0ec34a3..0d7cd4fe6 100644
--- a/Network/NetworkServerLookup.cpp
+++ b/Network/NetworkServerLookup.cpp
@@ -66,8 +66,7 @@ network_server_lookup (QString query
                 {
                   break;
                 }
-              // drop through
-
+              // fall through
             case QAbstractSocket::AnyIPProtocol:
               found = true;
               break;

From cee3c9796fcc2f246d98218693ffb2e518bf85a2 Mon Sep 17 00:00:00 2001
From: Bill Somerville <bill@classdesign.com>
Date: Wed, 3 Jul 2019 00:16:39 +0100
Subject: [PATCH 3/4] Squash a compiler warning that was also a potential
 defect

---
 widgets/RestrictedSpinBox.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/widgets/RestrictedSpinBox.cpp b/widgets/RestrictedSpinBox.cpp
index 3d18ce488..0c71634bb 100644
--- a/widgets/RestrictedSpinBox.cpp
+++ b/widgets/RestrictedSpinBox.cpp
@@ -10,7 +10,7 @@ QValidator::State RestrictedSpinBox::validate (QString& input, int& pos) const
   // start by doing the standard QSpinBox validation
   auto valid = HintedSpinBox::validate (input, pos);
   // extra validation
-  if (QValidator::Acceptable
+  if (QValidator::Acceptable == valid
       && values ().end () == std::find (values ().begin (), values ().end (), valueFromText (input)))
     {
       valid = QValidator::Intermediate;

From e95451cdccb3db006f6a0921ec99a31a73061c51 Mon Sep 17 00:00:00 2001
From: Bill Somerville <bill@classdesign.com>
Date: Wed, 3 Jul 2019 00:29:56 +0100
Subject: [PATCH 4/4] Squash compiler warnings

---
 getfile.cpp | 36 ++++++++++++++++++------------------
 1 file changed, 18 insertions(+), 18 deletions(-)

diff --git a/getfile.cpp b/getfile.cpp
index ed227dd38..96c76ad8a 100644
--- a/getfile.cpp
+++ b/getfile.cpp
@@ -22,21 +22,21 @@
 
 void getfile(QString fname, int ntrperiod)
 {
-  struct WAVHDR {
-    char ariff[4];
-    int lenfile;
-    char awave[4];
-    char afmt[4];
-    int lenfmt;
-    short nfmt2;
-    short nchan2;
-    int nsamrate;
-    int nbytesec;
-    short nbytesam2;
-    short nbitsam2;
-    char adata[4];
-    int ndata;
-  } hdr;
+  // struct WAVHDR {
+  //   char ariff[4];
+  //   int lenfile;
+  //   char awave[4];
+  //   char afmt[4];
+  //   int lenfmt;
+  //   short nfmt2;
+  //   short nchan2;
+  //   int nsamrate;
+  //   int nbytesec;
+  //   short nbytesam2;
+  //   short nbitsam2;
+  //   char adata[4];
+  //   int ndata;
+  // } hdr;
 
   char name[512];
   strncpy(name,fname.toLatin1(), sizeof (name) - 1);
@@ -93,10 +93,10 @@ void getfile(QString fname, int ntrperiod)
         if (!memcmp(desc.id,"data",sizeof desc.id)) break;
       } while (!fseek(fp,(desc.size + 1) / 2 * 2,SEEK_CUR));
     
-// Read (and ignore) a 44-byte WAV header; then read data
-//    int n=fread(&hdr,1,44,fp);
+    // Read (and ignore) a 44-byte WAV header; then read data
+    // int n=fread(&hdr,1,44,fp);
     int n=fread(dec_data.d2,2,npts,fp);
-    if(hdr.nsamrate==11025) wav12_(dec_data.d2,dec_data.d2,&n,(short*)&fmt.nbitsam2);
+    if(fmt.nsamrate==11025) wav12_(dec_data.d2,dec_data.d2,&n,(short*)&fmt.nbitsam2);
     fclose(fp);
     dec_data.params.newdat=1;
     dec_data.params.kin=n;