From d15e419993de5f88b996141f47c47a46408b43b0 Mon Sep 17 00:00:00 2001
From: Bill Somerville <bill@classdesign.com>
Date: Wed, 7 Oct 2020 19:11:27 +0100
Subject: [PATCH] Allow UDP service port zero, this disables the UDP Message
 Protocol

---
 Configuration.cpp |  7 +------
 Configuration.ui  | 12 ++++++------
 2 files changed, 7 insertions(+), 12 deletions(-)

diff --git a/Configuration.cpp b/Configuration.cpp
index 0466fd662..5df45c543 100644
--- a/Configuration.cpp
+++ b/Configuration.cpp
@@ -1070,18 +1070,13 @@ Configuration::impl::impl (Configuration * self, QNetworkAccessManager * network
 
   //
   // validation
+  //
   ui_->callsign_line_edit->setValidator (new CallsignValidator {this});
   ui_->grid_line_edit->setValidator (new MaidenheadLocatorValidator {this});
   ui_->add_macro_line_edit->setValidator (new QRegularExpressionValidator {message_alphabet, this});
   ui_->Field_Day_Exchange->setValidator (new QRegularExpressionValidator {field_day_exchange_re, this});
   ui_->RTTY_Exchange->setValidator (new QRegularExpressionValidator {RTTY_roundup_exchange_re, this});
 
-  ui_->udp_server_port_spin_box->setMinimum (1);
-  ui_->udp_server_port_spin_box->setMaximum (std::numeric_limits<port_type>::max ());
-
-  ui_->n1mm_server_port_spin_box->setMinimum (1);
-  ui_->n1mm_server_port_spin_box->setMaximum (std::numeric_limits<port_type>::max ());
-
   //
   // assign ids to radio buttons
   //
diff --git a/Configuration.ui b/Configuration.ui
index d22032d53..fbd53c422 100644
--- a/Configuration.ui
+++ b/Configuration.ui
@@ -1893,9 +1893,6 @@ and DX Grid fields when a 73 or free text message is sent.</string>
               <property name="toolTip">
                <string>&lt;html&gt;&lt;head/&gt;&lt;body&gt;&lt;p&gt;Enter the service port number of the UDP server that WSJT-X should send updates to. If this is zero no updates will be broadcast.&lt;/p&gt;&lt;/body&gt;&lt;/html&gt;</string>
               </property>
-              <property name="minimum">
-               <number>0</number>
-              </property>
               <property name="maximum">
                <number>65534</number>
               </property>
@@ -1988,6 +1985,9 @@ and DX Grid fields when a 73 or free text message is sent.</string>
             <property name="toolTip">
              <string>&lt;html&gt;&lt;head/&gt;&lt;body&gt;&lt;p&gt;Enter the port number that WSJT-X should use for UDP broadcasts of ADIF log information. For N1MM Logger+, this value should be 2333. If this is zero,  no updates will be broadcast.&lt;/p&gt;&lt;/body&gt;&lt;/html&gt;</string>
             </property>
+            <property name="maximum">
+             <number>65534</number>
+            </property>
            </widget>
           </item>
          </layout>
@@ -3194,11 +3194,11 @@ Right click for insert and delete options.</string>
  <buttongroups>
   <buttongroup name="PTT_method_button_group"/>
   <buttongroup name="CAT_data_bits_button_group"/>
-  <buttongroup name="CAT_stop_bits_button_group"/>
   <buttongroup name="special_op_activity_button_group"/>
-  <buttongroup name="TX_mode_button_group"/>
+  <buttongroup name="CAT_stop_bits_button_group"/>
   <buttongroup name="TX_audio_source_button_group"/>
-  <buttongroup name="CAT_handshake_button_group"/>
   <buttongroup name="split_mode_button_group"/>
+  <buttongroup name="TX_mode_button_group"/>
+  <buttongroup name="CAT_handshake_button_group"/>
  </buttongroups>
 </ui>