Commit Graph

915 Commits

Author SHA1 Message Date
Bill Somerville
ba4cfb2311 Another uninitialized variable picked up by valgrind MemCheck
git-svn-id: svn+ssh://svn.code.sf.net/p/wsjt/wsjt/branches/wsjtx@6766 ab8295b8-cf94-4d9e-aec4-7959e3be5d79
2016-06-11 23:53:18 +00:00
Bill Somerville
282459b665 Clean up some memory leaks
Move the  FFTW3 cleanup  into the  main routine as  it should  only be
called  once rather  than  every time  the  settings configuration  is
changed or reset (MultiSettings).

Call the new fini_ldpc_ routine before  exiting in the main routine to
free the LDPC resources.

git-svn-id: svn+ssh://svn.code.sf.net/p/wsjt/wsjt/branches/wsjtx@6764 ab8295b8-cf94-4d9e-aec4-7959e3be5d79
2016-06-11 18:50:57 +00:00
Bill Somerville
c2a73723e0 Fix some initialization order issues introduced in r6755
These include the wide graph window not being suppressed when starting
the application in a fast mode.

git-svn-id: svn+ssh://svn.code.sf.net/p/wsjt/wsjt/branches/wsjtx@6762 ab8295b8-cf94-4d9e-aec4-7959e3be5d79
2016-06-11 18:50:41 +00:00
Bill Somerville
829dc3ec57 Make sure tune power tool tip only shows when adjusting the tune power using the UI
git-svn-id: svn+ssh://svn.code.sf.net/p/wsjt/wsjt/branches/wsjtx@6761 ab8295b8-cf94-4d9e-aec4-7959e3be5d79
2016-06-11 18:50:34 +00:00
Bill Somerville
c7344e0441 Another, hopefully final, fix for saving decocded WAV files reliably
git-svn-id: svn+ssh://svn.code.sf.net/p/wsjt/wsjt/branches/wsjtx@6757 ab8295b8-cf94-4d9e-aec4-7959e3be5d79
2016-06-10 22:59:41 +00:00
Bill Somerville
8e43af11e5 Fix numerous memory leaks and uses of uninitialized variables
These were discovered when running under teh valgrind MemCheck tool. I
have also  checked in a suppressions  file (wsjtx-valgrind.linux.supp)
suitable for use on Linux when running the valgrind MemCheck tool.

git-svn-id: svn+ssh://svn.code.sf.net/p/wsjt/wsjt/branches/wsjtx@6755 ab8295b8-cf94-4d9e-aec4-7959e3be5d79
2016-06-10 15:54:16 +00:00
Bill Somerville
66c390de79 More consistent highlighting and processing of general call messages
Highlight,  in the  CQ  colour, CQDX  ... and  QRZ  ...  messages  and
process correctly for worked before and DXCC entity.

git-svn-id: svn+ssh://svn.code.sf.net/p/wsjt/wsjt/branches/wsjtx@6753 ab8295b8-cf94-4d9e-aec4-7959e3be5d79
2016-06-09 23:39:48 +00:00
Bill Somerville
7be033e8c2 Report WAV file reading and writing errors
Refactor the  save WAV  file routine  to return an  error string  as a
promise and then get that result and report in a QMessageBox.

git-svn-id: svn+ssh://svn.code.sf.net/p/wsjt/wsjt/branches/wsjtx@6752 ab8295b8-cf94-4d9e-aec4-7959e3be5d79
2016-06-09 23:39:41 +00:00
Joe Taylor
df518f4e1d Make it possible to find MSK144 code-definition files in the "data_dir" on all platforms.
git-svn-id: svn+ssh://svn.code.sf.net/p/wsjt/wsjt/branches/wsjtx@6747 ab8295b8-cf94-4d9e-aec4-7959e3be5d79
2016-06-09 15:06:15 +00:00
Joe Taylor
143736129b Starting to implement the hooks for interfacing to QRA mode.
Pass file path for peg-128 files to fast_decode().  (Inelegant, but it works.)


git-svn-id: svn+ssh://svn.code.sf.net/p/wsjt/wsjt/branches/wsjtx@6741 ab8295b8-cf94-4d9e-aec4-7959e3be5d79
2016-06-08 21:20:58 +00:00
Joe Taylor
ecd36a33b5 Starting what's needed to pass data_dir to fast_decode(). I need help!
git-svn-id: svn+ssh://svn.code.sf.net/p/wsjt/wsjt/branches/wsjtx@6740 ab8295b8-cf94-4d9e-aec4-7959e3be5d79
2016-06-08 19:49:50 +00:00
Bill Somerville
a6be978915 Ensure that tune specific Tx gain setting is not restored after it is cleared
git-svn-id: svn+ssh://svn.code.sf.net/p/wsjt/wsjt/branches/wsjtx@6733 ab8295b8-cf94-4d9e-aec4-7959e3be5d79
2016-06-05 19:24:56 +00:00
Joe Taylor
6eb55cee68 No short messages (yet?) in MSK144 mode. Max message length = 80. Don't
try to remove a noexistent file.


git-svn-id: svn+ssh://svn.code.sf.net/p/wsjt/wsjt/branches/wsjtx@6722 ab8295b8-cf94-4d9e-aec4-7959e3be5d79
2016-06-03 18:20:53 +00:00
Joe Taylor
9845494276 Install MSK144 as a new mode.
git-svn-id: svn+ssh://svn.code.sf.net/p/wsjt/wsjt/branches/wsjtx@6721 ab8295b8-cf94-4d9e-aec4-7959e3be5d79
2016-06-03 15:45:54 +00:00
Bill Somerville
b49999f96d Fix close down semantics and suppress subprocess errors during close down
git-svn-id: svn+ssh://svn.code.sf.net/p/wsjt/wsjt/branches/wsjtx@6705 ab8295b8-cf94-4d9e-aec4-7959e3be5d79
2016-05-26 23:40:16 +00:00
Bill Somerville
3ec6d211c8 Extend UDP status message - added Rx/Tx DF, call and grid information
Build now creates and installs a  UDP library that contains the server
side  of the  UDP messaging  facility.  This  library is  used by  the
udp_daemon and message_aggregator reference  examples. The new library
is  currently a  static archive  but  can also  be built  as a  shared
library.  The library  allows third  party Qt  applications to  easily
access UDP messages from WSJT-X.

Refactored  the  message_aggregator  reference example  to  split  out
classes into  separate translation  units. Added new  functionality to
exercise  the  new  UDP  status fields,  highlight  own  call,  CQ/QRZ
messages and decodes near Rx DF.

git-svn-id: svn+ssh://svn.code.sf.net/p/wsjt/wsjt/branches/wsjtx@6691 ab8295b8-cf94-4d9e-aec4-7959e3be5d79
2016-05-24 10:08:35 +00:00
Joe Taylor
d865186de3 JT4 end-of-line flag "f*" is now properly displayed in the Avg Msg window.
git-svn-id: svn+ssh://svn.code.sf.net/p/wsjt/wsjt/branches/wsjtx@6690 ab8295b8-cf94-4d9e-aec4-7959e3be5d79
2016-05-23 20:34:01 +00:00
Joe Taylor
1531f3ad3b New format for end-of-line flags in JT4 and JT65; starting work on
establishing sync in JT4.


git-svn-id: svn+ssh://svn.code.sf.net/p/wsjt/wsjt/branches/wsjtx@6685 ab8295b8-cf94-4d9e-aec4-7959e3be5d79
2016-05-19 16:13:51 +00:00
Bill Somerville
21283cd475 Message averaging window fonts controlled by configuration
Use the decoded text font for the message averaging window.

git-svn-id: svn+ssh://svn.code.sf.net/p/wsjt/wsjt/branches/wsjtx@6684 ab8295b8-cf94-4d9e-aec4-7959e3be5d79
2016-05-18 23:22:24 +00:00
Bill Somerville
a63e906cbb Do not access ui widgets after the UI has been destroyed
During  orderly close down  the UI  can  be destroyed  while Rx  audio
blocks are  still being  delivered. Therefore the  UI pointer  must be
checked  in MainWindow::datasink  before attempting  to access  the UI
widgets.

git-svn-id: svn+ssh://svn.code.sf.net/p/wsjt/wsjt/branches/wsjtx@6683 ab8295b8-cf94-4d9e-aec4-7959e3be5d79
2016-05-17 20:45:40 +00:00
Bill Somerville
22a9195326 Allow for extra character after mode when matching UDP reply to CQ messages
git-svn-id: svn+ssh://svn.code.sf.net/p/wsjt/wsjt/branches/wsjtx@6682 ab8295b8-cf94-4d9e-aec4-7959e3be5d79
2016-05-17 20:45:32 +00:00
Bill Somerville
f398495cfc Allow for, and add where necessary, a second character after mode
The decoded message processing relies on fixed column positions so the
extra character used in message  averaging to indicate sync flips must
also be allowed for in other modes.  This is done by inserting a space
character.

git-svn-id: svn+ssh://svn.code.sf.net/p/wsjt/wsjt/branches/wsjtx@6681 ab8295b8-cf94-4d9e-aec4-7959e3be5d79
2016-05-17 19:35:38 +00:00
Bill Somerville
cc8d2130c6 Improved subprocess handling and error reporting
git-svn-id: svn+ssh://svn.code.sf.net/p/wsjt/wsjt/branches/wsjtx@6675 ab8295b8-cf94-4d9e-aec4-7959e3be5d79
2016-05-07 19:32:52 +00:00
Bill Somerville
a45ea3cdff Adjust decodes displays and processing for extra csync indicator after mode
git-svn-id: svn+ssh://svn.code.sf.net/p/wsjt/wsjt/branches/wsjtx@6674 ab8295b8-cf94-4d9e-aec4-7959e3be5d79
2016-05-05 18:53:00 +00:00
Bill Somerville
2c7ae5f9de Pass sensible default min sync to decoders if spin box is not visible
git-svn-id: svn+ssh://svn.code.sf.net/p/wsjt/wsjt/branches/wsjtx@6673 ab8295b8-cf94-4d9e-aec4-7959e3be5d79
2016-05-05 18:52:47 +00:00
Bill Somerville
7c2ededab6 Do not act on double clicks of empty decode window lines
Tx period was erroneously being forced to odd/2nd.

git-svn-id: svn+ssh://svn.code.sf.net/p/wsjt/wsjt/branches/wsjtx@6670 ab8295b8-cf94-4d9e-aec4-7959e3be5d79
2016-05-05 01:32:16 +00:00
Bill Somerville
080f7ef1a2 Make mutable static variables instance variables where necessary
Static storage variables that should  have been class members are made
so. This  ensures that  if they  are used  as initialization  one time
switches   then  they   will  operate   correctly  when   their  class
instantiated more than once. This now happoens for most classes due to
the configurations  switching facility which destroys  all windows and
re-instantiates them.

git-svn-id: svn+ssh://svn.code.sf.net/p/wsjt/wsjt/branches/wsjtx@6661 ab8295b8-cf94-4d9e-aec4-7959e3be5d79
2016-05-01 00:40:51 +00:00
Joe Taylor
5bf1a0dcf0 Make sure the "Fast" checkbox becomes visible after enabling VHF/UHF
features on the Settings | General tab.


git-svn-id: svn+ssh://svn.code.sf.net/p/wsjt/wsjt/branches/wsjtx@6652 ab8295b8-cf94-4d9e-aec4-7959e3be5d79
2016-04-28 15:06:32 +00:00
Bill Somerville
1cae0b8aa9 Move temporary directory creation and deletion outside of MainWindow
Changing configuration causes  WSJT-X and JTAlert to get  into a fight
for the temporary directory. By moving the creation and clearup of the
temporary directory outside  of the configurations loop  this issue is
minimized to no worse than before multiple configurations were added.

git-svn-id: svn+ssh://svn.code.sf.net/p/wsjt/wsjt/branches/wsjtx@6630 ab8295b8-cf94-4d9e-aec4-7959e3be5d79
2016-04-20 21:59:22 +00:00
Bill Somerville
e6c59a42b5 Ensure that WSPR band hopping is disabled when Rig is None
Also added  a new configuration query  method to check if  Rig is None
i.e. a dummy rig.

git-svn-id: svn+ssh://svn.code.sf.net/p/wsjt/wsjt/branches/wsjtx@6629 ab8295b8-cf94-4d9e-aec4-7959e3be5d79
2016-04-20 20:22:23 +00:00
Bill Somerville
3b46e140af Disable Internet spotting when rig control is not working
git-svn-id: svn+ssh://svn.code.sf.net/p/wsjt/wsjt/branches/wsjtx@6628 ab8295b8-cf94-4d9e-aec4-7959e3be5d79
2016-04-20 19:33:33 +00:00
Bill Somerville
119a98f99a Disable WSPR band hopping on rig failure before showing error message
git-svn-id: svn+ssh://svn.code.sf.net/p/wsjt/wsjt/branches/wsjtx@6626 ab8295b8-cf94-4d9e-aec4-7959e3be5d79
2016-04-19 13:50:05 +00:00
Bill Somerville
4cebdddfe5 Add multiple configurations navigation and management
Multiple configurations  are accessed and  maintained from a  new main
window menu bar  pop up menu "Configurations". The  prior settings are
the  "Default"  entry. New  configurations  may  be added  by  cloning
existing ones.  Maintenance  and navigation is via sub  menus for each
configuration.

git-svn-id: svn+ssh://svn.code.sf.net/p/wsjt/wsjt/branches/wsjtx@6623 ab8295b8-cf94-4d9e-aec4-7959e3be5d79
2016-04-17 23:39:12 +00:00
Joe Taylor
c7dfc1ee00 1. Protect against wrong ID of f0 being fit by lorentzian(), when Ftol is large.
2. When switching to JT65 mode, go through JT9 first.


git-svn-id: svn+ssh://svn.code.sf.net/p/wsjt/wsjt/branches/wsjtx@6621 ab8295b8-cf94-4d9e-aec4-7959e3be5d79
2016-04-14 13:22:05 +00:00
Joe Taylor
3aca283554 In single-decode mode, treat "Aggressive decoding level" as 1 if set to 0.
git-svn-id: svn+ssh://svn.code.sf.net/p/wsjt/wsjt/branches/wsjtx@6620 ab8295b8-cf94-4d9e-aec4-7959e3be5d79
2016-04-13 13:52:45 +00:00
Bill Somerville
8d13c8e1ff Restore double click on decode behaviour broken by disable Tx DF spin box
The changes  to fix the  Tx DF  at 1000Hz when  VHF & up  features are
enabled had an undesirable side effect of disabling double clicking on
decodes  because  this was  disabled  by  the  Tx  DF spin  box  being
disabled. The  Tx DF  spin box  being disabled  in VHF  & up  mode may
change but this change fixes this issue regardless.

git-svn-id: svn+ssh://svn.code.sf.net/p/wsjt/wsjt/branches/wsjtx@6617 ab8295b8-cf94-4d9e-aec4-7959e3be5d79
2016-04-12 22:07:14 +00:00
Joe Taylor
90beb50cbe 1. Add AGC for waterfall in *Ref Spec* mode.
2. Don't display orange warning bar when in WSPR mode.
3. Fix a longstanding compiler warning.


git-svn-id: svn+ssh://svn.code.sf.net/p/wsjt/wsjt/branches/wsjtx@6616 ab8295b8-cf94-4d9e-aec4-7959e3be5d79
2016-04-12 19:54:15 +00:00
Bill Somerville
38cf525969 Use fixed 1000Hz Tx DF in VHF & up QSO modes
git-svn-id: svn+ssh://svn.code.sf.net/p/wsjt/wsjt/branches/wsjtx@6610 ab8295b8-cf94-4d9e-aec4-7959e3be5d79
2016-04-11 23:29:29 +00:00
Bill Somerville
4350c682ec More consistent checks for WSPR modes
git-svn-id: svn+ssh://svn.code.sf.net/p/wsjt/wsjt/branches/wsjtx@6609 ab8295b8-cf94-4d9e-aec4-7959e3be5d79
2016-04-11 23:29:21 +00:00
Joe Taylor
b843894061 First working code offering optional computation and use of a reference
spectrum.


git-svn-id: svn+ssh://svn.code.sf.net/p/wsjt/wsjt/branches/wsjtx@6608 ab8295b8-cf94-4d9e-aec4-7959e3be5d79
2016-04-11 20:53:54 +00:00
Joe Taylor
50cbdbb807 More work toward a usable reference spectrum.
git-svn-id: svn+ssh://svn.code.sf.net/p/wsjt/wsjt/branches/wsjtx@6603 ab8295b8-cf94-4d9e-aec4-7959e3be5d79
2016-04-08 20:03:29 +00:00
Joe Taylor
23298c1743 Rename refspec() to refspectrum().
git-svn-id: svn+ssh://svn.code.sf.net/p/wsjt/wsjt/branches/wsjtx@6601 ab8295b8-cf94-4d9e-aec4-7959e3be5d79
2016-04-08 15:55:28 +00:00
Joe Taylor
88e47a5941 Working on implementing reference spectra.
git-svn-id: svn+ssh://svn.code.sf.net/p/wsjt/wsjt/branches/wsjtx@6600 ab8295b8-cf94-4d9e-aec4-7959e3be5d79
2016-04-08 15:23:32 +00:00
Joe Taylor
da098e4a76 Starting to implement accumulation of reference spectrum.
git-svn-id: svn+ssh://svn.code.sf.net/p/wsjt/wsjt/branches/wsjtx@6598 ab8295b8-cf94-4d9e-aec4-7959e3be5d79
2016-04-07 20:02:32 +00:00
Bill Somerville
2cfbb15b4f Rig control overhaul to implement generic Doppler shift tracking
The  concept of  a nominal  receive  and transmit  frequency has  been
introduced. This is  used as a base frequency  for Doppler correction,
frequency setting  and reporting. The  start up frequency is  now zero
which is  updated by the first  rig control status report.  This needs
more  work to  accommodate  calling frequency  plus working  frequency
operation as is used for random MS operation etc..

The  main  window  frequency  display  now  shows  the  transmit  dial
frequency while transmitting.

The mode changing logic sequence has been changed such that the rig is
correctly put  into and  taken out  of split mode  as required  by the
target mode.  This also  avoids the "other"  VFO having  its frequency
changed when  entering a mode that  does not use split  operating like
WSPR.

The main window  band combo box edit  may now be used to  input an kHz
offset  from the  current MHz  dial  frequency. This  is intended  for
setting  a sked  or working  frequency on  the VHF  and up  bands. For
example the working frequency for 23cms  might be set to 1296MHz and a
working  frequency of  1296.3MHz would  be selected  by selecting  the
23cms band  with the combo box  drop down list and  then entering 300k
into the band combo box edit widget.

When using JT4 modes a CTRL+Click on the waterfall adjusts the nominal
frequency such  that the frequency  clicked on  becomes the Tx  and Rx
frequency using  the fixed 1000Hz  DF that  JT4 modes use.   This will
probably be extended to all QSO modes when used in VHF & up mode. This
assumes that 1000Hz is an optimal DF  for both Tx and Rx and therefore
one  can "net"  to an  off frequency,  but visible  on the  waterfall,
caller with one click.

Improvements to OmniRig  rig control including use of  the serial port
control lines RTS or DTR, on the  CAT serial port used by OmniRig, for
PTT control.

Incrementing transaction sequence numbers added to messages to and from
the rig control  thread. This enables round trip status  to be tracked
and associated with a request. For  example a command that might cause
several  asynchronous  status  updates  can  now  be  tracked  in  the
originating thread such  that it is clear which updates  are caused by
executing the  request. This in turn  allows updates to be  held until
the request is complete i.e. the  state is consistent with the results
of the request.

Messages  to the  rig control  thread are  now posted  as a  new state
(Transceiver::TransceiverState) object. The  rig control thread tracks
requests and  actions any differences  between the prior  requests and
the new state.

The rig  control thread is now  stored on the  heap so that it  can be
closed down  and released as needed.  Along with this the  rig control
close  down  semantics  are  better defined  avoiding  some  potential
deadlock situations.

If the rig  is placed into split  mode it will be  reverted to simplex
mode when the rig connection is closed.

When  using direct  rig control  via Hamlib,  rigs that  have A/B  VFO
arrangements and  no method to query  the current VFO like  many Icoms
and  the Yaesu  FT-817/857/897(D)  series now  have smarted  frequency
updating requiring no  VFO changes when changing  the frequency.  This
is particularly  important when doing  Tx Doppler correction  to avoid
glitches.

The implementation  of emulated  split operating  mode ("Fake  It") is
simplified and improved.

A dummy  Hamlib transceiver for PTT  control on a separate  port is no
long instantiated if CAT or VOX PTT control is selected.

The resolution and  any rounding of the rig CAT  frequency set and get
commands is determined automatically  upon opening the rig connection.
This is needed to determine the  rate of frequency updates for Doppler
tracking. It also allows the rig to be more accurately controlled.

Frequency  calibration is  calculated separately  for the  receive and
transmit frequencies.

Whether  the  rig  modulation  mode  should be  controlled  is  now  a
constructor  argument rather  than  being passed  with individual  rig
control requests.

Doppler  shift  correction  is   considerably  enhanced  with  simpler
controls and much  better rig control.  A new mode  of tracking called
"receive only" is introduced for those with rigs that cannot be QSY:ed
via  CAT  when transmitting.   Such  rigs  have a  Doppler  correction
calculated  for the  middle of  the next  transmit period  just before
transmission starts. While  using Doppler tracking it  is now possible
to adjust the  sked frequency either using the new  kHz offset feature
of the main  window band combo box  or by directly tuning  the rig VFO
knob while holding down the CTRL key.

The astronomical data window that includes Doppler tracking control is
now opened  and closed using a  checkable menu item to  avoid it being
accidentally closed.

Debug  configuration  rig  control  diagnostic  messages  now  have  a
facility argument for clearer and more standardized trace messages.

git-svn-id: svn+ssh://svn.code.sf.net/p/wsjt/wsjt/branches/wsjtx@6590 ab8295b8-cf94-4d9e-aec4-7959e3be5d79
2016-04-06 17:11:58 +00:00
Joe Taylor
bcdd28a038 Add markers for RO RRR 73 messages on the Wide Graph scale.
git-svn-id: svn+ssh://svn.code.sf.net/p/wsjt/wsjt/branches/wsjtx@6557 ab8295b8-cf94-4d9e-aec4-7959e3be5d79
2016-03-24 16:46:52 +00:00
Joe Taylor
33581198e6 1. Generate shorthand JT65 messages for RO, RRR, 73.
2. Fix background colors for special message types.


git-svn-id: svn+ssh://svn.code.sf.net/p/wsjt/wsjt/branches/wsjtx@6556 ab8295b8-cf94-4d9e-aec4-7959e3be5d79
2016-03-24 15:44:48 +00:00
Joe Taylor
3e091fca99 Improved GUI control and display of averaged and hinted decodes.
git-svn-id: svn+ssh://svn.code.sf.net/p/wsjt/wsjt/branches/wsjtx@6548 ab8295b8-cf94-4d9e-aec4-7959e3be5d79
2016-03-22 14:12:59 +00:00
Joe Taylor
846ddf9039 1. Clean up GUI features releted to message averaging and deep search.
2. Make averaging and DS separately selecteble.
3. Clear nftt and avemsg on Clear Avg.
4. Allow fer65 to handle message averaging.


git-svn-id: svn+ssh://svn.code.sf.net/p/wsjt/wsjt/branches/wsjtx@6543 ab8295b8-cf94-4d9e-aec4-7959e3be5d79
2016-03-21 16:03:11 +00:00
Joe Taylor
331402213a Several changes for single-decode behavior:
1. Use "f" to flag FT decodes, 'h' for hinted decodes.
2. Let "Experience-based" checkboxes activate hinted decoding.
3. Singls-sequence decodes go to left window, average decodes to right.


git-svn-id: svn+ssh://svn.code.sf.net/p/wsjt/wsjt/branches/wsjtx@6542 ab8295b8-cf94-4d9e-aec4-7959e3be5d79
2016-03-20 19:32:08 +00:00