auto-format xts code

This commit is contained in:
Steffen Jaeckel 2015-08-26 00:02:50 +02:00
parent b25d04ed94
commit 181d2f2df7
6 changed files with 145 additions and 164 deletions

View File

@ -11,8 +11,8 @@
#include "tomcrypt.h" #include "tomcrypt.h"
/** /**
Source donated by Elliptic Semiconductor Inc (www.ellipticsemi.com) to the LibTom Projects Source donated by Elliptic Semiconductor Inc (www.ellipticsemi.com) to the LibTom Projects
*/ */
#ifdef LTC_XTS_MODE #ifdef LTC_XTS_MODE
@ -24,11 +24,11 @@ static int tweak_uncrypt(const unsigned char *C, unsigned char *P, unsigned char
/* tweak encrypt block i */ /* tweak encrypt block i */
#ifdef LTC_FAST #ifdef LTC_FAST
for (x = 0; x < 16; x += sizeof(LTC_FAST_TYPE)) { for (x = 0; x < 16; x += sizeof(LTC_FAST_TYPE)) {
*((LTC_FAST_TYPE*)&P[x]) = *((LTC_FAST_TYPE*)&C[x]) ^ *((LTC_FAST_TYPE*)&T[x]); *((LTC_FAST_TYPE *)&P[x]) = *((LTC_FAST_TYPE *)&C[x]) ^ *((LTC_FAST_TYPE *)&T[x]);
} }
#else #else
for (x = 0; x < 16; x++) { for (x = 0; x < 16; x++) {
P[x] = C[x] ^ T[x]; P[x] = C[x] ^ T[x];
} }
#endif #endif
@ -36,11 +36,11 @@ static int tweak_uncrypt(const unsigned char *C, unsigned char *P, unsigned char
#ifdef LTC_FAST #ifdef LTC_FAST
for (x = 0; x < 16; x += sizeof(LTC_FAST_TYPE)) { for (x = 0; x < 16; x += sizeof(LTC_FAST_TYPE)) {
*((LTC_FAST_TYPE*)&P[x]) ^= *((LTC_FAST_TYPE*)&T[x]); *((LTC_FAST_TYPE *)&P[x]) ^= *((LTC_FAST_TYPE *)&T[x]);
} }
#else #else
for (x = 0; x < 16; x++) { for (x = 0; x < 16; x++) {
P[x] = P[x] ^ T[x]; P[x] = P[x] ^ T[x];
} }
#endif #endif
@ -51,27 +51,25 @@ static int tweak_uncrypt(const unsigned char *C, unsigned char *P, unsigned char
} }
/** XTS Decryption /** XTS Decryption
@param ct [in] Ciphertext @param ct [in] Ciphertext
@param ptlen Length of plaintext (and ciphertext) @param ptlen Length of plaintext (and ciphertext)
@param pt [out] Plaintext @param pt [out] Plaintext
@param tweak [in] The 128--bit encryption tweak (e.g. sector number) @param tweak [in] The 128--bit encryption tweak (e.g. sector number)
@param xts The XTS structure @param xts The XTS structure
Returns CRYPT_OK upon success Returns CRYPT_OK upon success
*/int xts_decrypt( */
const unsigned char *ct, unsigned long ptlen, int xts_decrypt(const unsigned char *ct, unsigned long ptlen, unsigned char *pt, unsigned char *tweak,
unsigned char *pt, symmetric_xts *xts)
unsigned char *tweak,
symmetric_xts *xts)
{ {
unsigned char PP[16], CC[16], T[16]; unsigned char PP[16], CC[16], T[16];
unsigned long i, m, mo, lim; unsigned long i, m, mo, lim;
int err; int err;
/* check inputs */ /* check inputs */
LTC_ARGCHK(pt != NULL); LTC_ARGCHK(pt != NULL);
LTC_ARGCHK(ct != NULL); LTC_ARGCHK(ct != NULL);
LTC_ARGCHK(tweak != NULL); LTC_ARGCHK(tweak != NULL);
LTC_ARGCHK(xts != NULL); LTC_ARGCHK(xts != NULL);
/* check if valid */ /* check if valid */
if ((err = cipher_is_valid(xts->cipher)) != CRYPT_OK) { if ((err = cipher_is_valid(xts->cipher)) != CRYPT_OK) {
@ -79,7 +77,7 @@ static int tweak_uncrypt(const unsigned char *C, unsigned char *P, unsigned char
} }
/* get number of blocks */ /* get number of blocks */
m = ptlen >> 4; m = ptlen >> 4;
mo = ptlen & 15; mo = ptlen & 15;
/* must have at least one full block */ /* must have at least one full block */
@ -95,27 +93,26 @@ static int tweak_uncrypt(const unsigned char *C, unsigned char *P, unsigned char
if (cipher_descriptor[xts->cipher].accel_xts_decrypt && lim > 0) { if (cipher_descriptor[xts->cipher].accel_xts_decrypt && lim > 0) {
/* use accelerated decryption for whole blocks */ /* use accelerated decryption for whole blocks */
if ((err = cipher_descriptor[xts->cipher].accel_xts_decrypt(ct, pt, if ((err = cipher_descriptor[xts->cipher].accel_xts_decrypt(ct, pt, lim, tweak, &xts->key1, &xts->key2) !=
lim, tweak, &xts->key1, &xts->key2) != CRYPT_OK)) { CRYPT_OK)) {
return err; return err;
} }
ct += lim * 16; ct += lim * 16;
pt += lim * 16; pt += lim * 16;
/* tweak is encrypted on output */ /* tweak is encrypted on output */
XMEMCPY(T, tweak, sizeof(T)); XMEMCPY(T, tweak, sizeof(T));
} else { } else {
/* encrypt the tweak */ /* encrypt the tweak */
if ((err = cipher_descriptor[xts->cipher].ecb_encrypt(tweak, T, if ((err = cipher_descriptor[xts->cipher].ecb_encrypt(tweak, T, &xts->key2)) != CRYPT_OK) {
&xts->key2)) != CRYPT_OK) { return err;
return err;
} }
for (i = 0; i < lim; i++) { for (i = 0; i < lim; i++) {
err = tweak_uncrypt(ct, pt, T, xts); err = tweak_uncrypt(ct, pt, T, xts);
ct += 16; ct += 16;
pt += 16; pt += 16;
} }
} }
@ -131,11 +128,11 @@ static int tweak_uncrypt(const unsigned char *C, unsigned char *P, unsigned char
/* Pm = first ptlen % 16 bytes of PP */ /* Pm = first ptlen % 16 bytes of PP */
for (i = 0; i < mo; i++) { for (i = 0; i < mo; i++) {
CC[i] = ct[16+i]; CC[i] = ct[16 + i];
pt[16+i] = PP[i]; pt[16 + i] = PP[i];
} }
for (; i < 16; i++) { for (; i < 16; i++) {
CC[i] = PP[i]; CC[i] = PP[i];
} }
/* Pm-1 = Tweak uncrypt CC */ /* Pm-1 = Tweak uncrypt CC */
@ -145,8 +142,7 @@ static int tweak_uncrypt(const unsigned char *C, unsigned char *P, unsigned char
} }
/* Decrypt the tweak back */ /* Decrypt the tweak back */
if ((err = cipher_descriptor[xts->cipher].ecb_decrypt(T, tweak, if ((err = cipher_descriptor[xts->cipher].ecb_decrypt(T, tweak, &xts->key2)) != CRYPT_OK) {
&xts->key2)) != CRYPT_OK) {
return err; return err;
} }
@ -158,4 +154,3 @@ static int tweak_uncrypt(const unsigned char *C, unsigned char *P, unsigned char
/* $Source$ */ /* $Source$ */
/* $Revision$ */ /* $Revision$ */
/* $Date$ */ /* $Date$ */

View File

@ -31,4 +31,3 @@ void xts_done(symmetric_xts *xts)
/* $Source$ */ /* $Source$ */
/* $Revision$ */ /* $Revision$ */
/* $Date$ */ /* $Date$ */

View File

@ -11,8 +11,8 @@
#include "tomcrypt.h" #include "tomcrypt.h"
/** /**
Source donated by Elliptic Semiconductor Inc (www.ellipticsemi.com) to the LibTom Projects Source donated by Elliptic Semiconductor Inc (www.ellipticsemi.com) to the LibTom Projects
*/ */
#ifdef LTC_XTS_MODE #ifdef LTC_XTS_MODE
@ -24,7 +24,7 @@ static int tweak_crypt(const unsigned char *P, unsigned char *C, unsigned char *
/* tweak encrypt block i */ /* tweak encrypt block i */
#ifdef LTC_FAST #ifdef LTC_FAST
for (x = 0; x < 16; x += sizeof(LTC_FAST_TYPE)) { for (x = 0; x < 16; x += sizeof(LTC_FAST_TYPE)) {
*((LTC_FAST_TYPE*)&C[x]) = *((LTC_FAST_TYPE*)&P[x]) ^ *((LTC_FAST_TYPE*)&T[x]); *((LTC_FAST_TYPE *)&C[x]) = *((LTC_FAST_TYPE *)&P[x]) ^ *((LTC_FAST_TYPE *)&T[x]);
} }
#else #else
for (x = 0; x < 16; x++) { for (x = 0; x < 16; x++) {
@ -38,11 +38,11 @@ static int tweak_crypt(const unsigned char *P, unsigned char *C, unsigned char *
#ifdef LTC_FAST #ifdef LTC_FAST
for (x = 0; x < 16; x += sizeof(LTC_FAST_TYPE)) { for (x = 0; x < 16; x += sizeof(LTC_FAST_TYPE)) {
*((LTC_FAST_TYPE*)&C[x]) ^= *((LTC_FAST_TYPE*)&T[x]); *((LTC_FAST_TYPE *)&C[x]) ^= *((LTC_FAST_TYPE *)&T[x]);
} }
#else #else
for (x = 0; x < 16; x++) { for (x = 0; x < 16; x++) {
C[x] = C[x] ^ T[x]; C[x] = C[x] ^ T[x];
} }
#endif #endif
@ -53,28 +53,25 @@ static int tweak_crypt(const unsigned char *P, unsigned char *C, unsigned char *
} }
/** XTS Encryption /** XTS Encryption
@param pt [in] Plaintext @param pt [in] Plaintext
@param ptlen Length of plaintext (and ciphertext) @param ptlen Length of plaintext (and ciphertext)
@param ct [out] Ciphertext @param ct [out] Ciphertext
@param tweak [in] The 128--bit encryption tweak (e.g. sector number) @param tweak [in] The 128--bit encryption tweak (e.g. sector number)
@param xts The XTS structure @param xts The XTS structure
Returns CRYPT_OK upon success Returns CRYPT_OK upon success
*/ */
int xts_encrypt( int xts_encrypt(const unsigned char *pt, unsigned long ptlen, unsigned char *ct, unsigned char *tweak,
const unsigned char *pt, unsigned long ptlen, symmetric_xts *xts)
unsigned char *ct,
unsigned char *tweak,
symmetric_xts *xts)
{ {
unsigned char PP[16], CC[16], T[16]; unsigned char PP[16], CC[16], T[16];
unsigned long i, m, mo, lim; unsigned long i, m, mo, lim;
int err; int err;
/* check inputs */ /* check inputs */
LTC_ARGCHK(pt != NULL); LTC_ARGCHK(pt != NULL);
LTC_ARGCHK(ct != NULL); LTC_ARGCHK(ct != NULL);
LTC_ARGCHK(tweak != NULL); LTC_ARGCHK(tweak != NULL);
LTC_ARGCHK(xts != NULL); LTC_ARGCHK(xts != NULL);
/* check if valid */ /* check if valid */
if ((err = cipher_is_valid(xts->cipher)) != CRYPT_OK) { if ((err = cipher_is_valid(xts->cipher)) != CRYPT_OK) {
@ -82,7 +79,7 @@ int xts_encrypt(
} }
/* get number of blocks */ /* get number of blocks */
m = ptlen >> 4; m = ptlen >> 4;
mo = ptlen & 15; mo = ptlen & 15;
/* must have at least one full block */ /* must have at least one full block */
@ -99,9 +96,9 @@ int xts_encrypt(
if (cipher_descriptor[xts->cipher].accel_xts_encrypt && lim > 0) { if (cipher_descriptor[xts->cipher].accel_xts_encrypt && lim > 0) {
/* use accelerated encryption for whole blocks */ /* use accelerated encryption for whole blocks */
if ((err = cipher_descriptor[xts->cipher].accel_xts_encrypt(pt, ct, lim, if ((err = cipher_descriptor[xts->cipher].accel_xts_encrypt(pt, ct, lim, tweak, &xts->key1, &xts->key2) !=
tweak, &xts->key1, &xts->key2) != CRYPT_OK)) { CRYPT_OK)) {
return err; return err;
} }
ct += lim * 16; ct += lim * 16;
pt += lim * 16; pt += lim * 16;
@ -111,15 +108,14 @@ int xts_encrypt(
} else { } else {
/* encrypt the tweak */ /* encrypt the tweak */
if ((err = cipher_descriptor[xts->cipher].ecb_encrypt(tweak, T, if ((err = cipher_descriptor[xts->cipher].ecb_encrypt(tweak, T, &xts->key2)) != CRYPT_OK) {
&xts->key2)) != CRYPT_OK) { return err;
return err;
} }
for (i = 0; i < lim; i++) { for (i = 0; i < lim; i++) {
err = tweak_crypt(pt, ct, T, xts); err = tweak_crypt(pt, ct, T, xts);
ct += 16; ct += 16;
pt += 16; pt += 16;
} }
} }
@ -132,12 +128,12 @@ int xts_encrypt(
/* Cm = first ptlen % 16 bytes of CC */ /* Cm = first ptlen % 16 bytes of CC */
for (i = 0; i < mo; i++) { for (i = 0; i < mo; i++) {
PP[i] = pt[16+i]; PP[i] = pt[16 + i];
ct[16+i] = CC[i]; ct[16 + i] = CC[i];
} }
for (; i < 16; i++) { for (; i < 16; i++) {
PP[i] = CC[i]; PP[i] = CC[i];
} }
/* Cm-1 = Tweak encrypt PP */ /* Cm-1 = Tweak encrypt PP */
@ -147,8 +143,7 @@ int xts_encrypt(
} }
/* Decrypt the tweak back */ /* Decrypt the tweak back */
if ((err = cipher_descriptor[xts->cipher].ecb_decrypt(T, tweak, if ((err = cipher_descriptor[xts->cipher].ecb_decrypt(T, tweak, &xts->key2)) != CRYPT_OK) {
&xts->key2)) != CRYPT_OK) {
return err; return err;
} }
@ -160,4 +155,3 @@ int xts_encrypt(
/* $Source$ */ /* $Source$ */
/* $Revision$ */ /* $Revision$ */
/* $Date$ */ /* $Date$ */

View File

@ -16,7 +16,6 @@
#ifdef LTC_XTS_MODE #ifdef LTC_XTS_MODE
/** Start XTS mode /** Start XTS mode
@param cipher The index of the cipher to use @param cipher The index of the cipher to use
@param key1 The encrypt key @param key1 The encrypt key
@ -26,19 +25,15 @@
@param xts [out] XTS structure @param xts [out] XTS structure
Returns CRYPT_OK upon success. Returns CRYPT_OK upon success.
*/ */
int xts_start( int cipher, int xts_start(int cipher, const unsigned char *key1, const unsigned char *key2, unsigned long keylen, int num_rounds,
const unsigned char *key1, symmetric_xts *xts)
const unsigned char *key2,
unsigned long keylen,
int num_rounds,
symmetric_xts *xts)
{ {
int err; int err;
/* check inputs */ /* check inputs */
LTC_ARGCHK(key1 != NULL); LTC_ARGCHK(key1 != NULL);
LTC_ARGCHK(key2 != NULL); LTC_ARGCHK(key2 != NULL);
LTC_ARGCHK(xts != NULL); LTC_ARGCHK(xts != NULL);
/* check if valid */ /* check if valid */
if ((err = cipher_is_valid(cipher)) != CRYPT_OK) { if ((err = cipher_is_valid(cipher)) != CRYPT_OK) {
@ -66,4 +61,3 @@ int xts_start( int cipher,
/* $Source$ */ /* $Source$ */
/* $Revision$ */ /* $Revision$ */
/* $Date$ */ /* $Date$ */

View File

@ -21,17 +21,17 @@
*/ */
void xts_mult_x(unsigned char *I) void xts_mult_x(unsigned char *I)
{ {
int x; int x;
unsigned char t, tt; unsigned char t, tt;
for (x = t = 0; x < 16; x++) { for (x = t = 0; x < 16; x++) {
tt = I[x] >> 7; tt = I[x] >> 7;
I[x] = ((I[x] << 1) | t) & 0xFF; I[x] = ((I[x] << 1) | t) & 0xFF;
t = tt; t = tt;
} }
if (tt) { if (tt) {
I[0] ^= 0x87; I[0] ^= 0x87;
} }
} }
#endif #endif
@ -39,4 +39,3 @@ void xts_mult_x(unsigned char *I)
/* $Source$ */ /* $Source$ */
/* $Revision$ */ /* $Revision$ */
/* $Date$ */ /* $Date$ */

View File

@ -14,6 +14,7 @@
/** /**
Source donated by Elliptic Semiconductor Inc (www.ellipticsemi.com) to the LibTom Projects Source donated by Elliptic Semiconductor Inc (www.ellipticsemi.com) to the LibTom Projects
Returns CRYPT_OK upon success. Returns CRYPT_OK upon success.
*/ */
int xts_test(void) int xts_test(void)
@ -21,7 +22,8 @@ int xts_test(void)
#ifdef LTC_NO_TEST #ifdef LTC_NO_TEST
return CRYPT_NOP; return CRYPT_NOP;
#else #else
static const struct { static const struct
{
int keylen; int keylen;
unsigned char key1[32]; unsigned char key1[32];
unsigned char key2[32]; unsigned char key2[32];
@ -143,9 +145,9 @@ int xts_test(void)
}; };
unsigned char OUT[512], Torg[16], T[16]; unsigned char OUT[512], Torg[16], T[16];
ulong64 seq; ulong64 seq;
symmetric_xts xts; symmetric_xts xts;
int i, j, err, idx; int i, j, err, idx;
unsigned long len; unsigned long len;
/* AES can be under rijndael or aes... try to find it */ /* AES can be under rijndael or aes... try to find it */
@ -154,51 +156,51 @@ int xts_test(void)
return CRYPT_NOP; return CRYPT_NOP;
} }
} }
for (j = 0; j < 2; j++) { for (j = 0; j < 2; j++) {
for (i = 0; i < (int)(sizeof(tests)/sizeof(tests[0])); i++) { for (i = 0; i < (int)(sizeof(tests) / sizeof(tests[0])); i++) {
/* skip the cases where /* skip the cases where
* the length is smaller than 2*blocklen * the length is smaller than 2*blocklen
* or the length is not a multiple of 32 * or the length is not a multiple of 32
*/ */
if ((j == 1) && ((tests[i].PTLEN < 32) || (tests[i].PTLEN % 32))) { if ((j == 1) && ((tests[i].PTLEN < 32) || (tests[i].PTLEN % 32))) {
continue; continue;
} }
len = tests[i].PTLEN/2; len = tests[i].PTLEN / 2;
err = xts_start(idx, tests[i].key1, tests[i].key2, tests[i].keylen/2, 0, &xts); err = xts_start(idx, tests[i].key1, tests[i].key2, tests[i].keylen / 2, 0, &xts);
if (err != CRYPT_OK) { if (err != CRYPT_OK) {
return err; return err;
} }
seq = tests[i].seqnum; seq = tests[i].seqnum;
STORE64L(seq,Torg); STORE64L(seq, Torg);
XMEMSET(Torg+8, 0, 8); XMEMSET(Torg + 8, 0, 8);
XMEMCPY(T, Torg, sizeof(T)); XMEMCPY(T, Torg, sizeof(T));
if (j == 0) { if (j == 0) {
err = xts_encrypt(tests[i].PTX, tests[i].PTLEN, OUT, T, &xts); err = xts_encrypt(tests[i].PTX, tests[i].PTLEN, OUT, T, &xts);
if (err != CRYPT_OK) { if (err != CRYPT_OK) {
xts_done(&xts); xts_done(&xts);
return err; return err;
} }
} } else {
else { err = xts_encrypt(tests[i].PTX, len, OUT, T, &xts);
err = xts_encrypt(tests[i].PTX, len, OUT, T, &xts); if (err != CRYPT_OK) {
if (err != CRYPT_OK) { xts_done(&xts);
xts_done(&xts); return err;
return err; }
} err = xts_encrypt(&tests[i].PTX[len], len, &OUT[len], T, &xts);
err = xts_encrypt(&tests[i].PTX[len], len, &OUT[len], T, &xts); if (err != CRYPT_OK) {
if (err != CRYPT_OK) { xts_done(&xts);
xts_done(&xts); return err;
return err; }
}
} }
if (XMEMCMP(OUT, tests[i].CTX, tests[i].PTLEN)) { if (XMEMCMP(OUT, tests[i].CTX, tests[i].PTLEN)) {
#ifdef LTC_TEST_DBG #ifdef LTC_TEST_DBG
printf("\nTestcase #%d with original length %lu and half of it %lu\n", i, tests[i].PTLEN, len); printf("\nTestcase #%d with original length %lu and half of it "
"%lu\n",
i, tests[i].PTLEN, len);
printf("\nencrypt\n"); printf("\nencrypt\n");
print_hex("should", tests[i].CTX, tests[i].PTLEN); print_hex("should", tests[i].CTX, tests[i].PTLEN);
print_hex("is", OUT, tests[i].PTLEN); print_hex("is", OUT, tests[i].PTLEN);
@ -209,23 +211,22 @@ int xts_test(void)
XMEMCPY(T, Torg, sizeof(T)); XMEMCPY(T, Torg, sizeof(T));
if (j == 0) { if (j == 0) {
err = xts_decrypt(tests[i].CTX, tests[i].PTLEN, OUT, T, &xts); err = xts_decrypt(tests[i].CTX, tests[i].PTLEN, OUT, T, &xts);
if (err != CRYPT_OK) { if (err != CRYPT_OK) {
xts_done(&xts); xts_done(&xts);
return err; return err;
} }
} } else {
else { err = xts_decrypt(tests[i].CTX, len, OUT, T, &xts);
err = xts_decrypt(tests[i].CTX, len, OUT, T, &xts); if (err != CRYPT_OK) {
if (err != CRYPT_OK) { xts_done(&xts);
xts_done(&xts); return err;
return err; }
} err = xts_decrypt(&tests[i].CTX[len], len, &OUT[len], T, &xts);
err = xts_decrypt(&tests[i].CTX[len], len, &OUT[len], T, &xts); if (err != CRYPT_OK) {
if (err != CRYPT_OK) { xts_done(&xts);
xts_done(&xts); return err;
return err; }
}
} }
if (XMEMCMP(OUT, tests[i].PTX, tests[i].PTLEN)) { if (XMEMCMP(OUT, tests[i].PTX, tests[i].PTLEN)) {
@ -238,7 +239,7 @@ int xts_test(void)
return CRYPT_FAIL_TESTVECTOR; return CRYPT_FAIL_TESTVECTOR;
} }
xts_done(&xts); xts_done(&xts);
} }
} }
return CRYPT_OK; return CRYPT_OK;
#endif #endif
@ -249,4 +250,3 @@ int xts_test(void)
/* $Source$ */ /* $Source$ */
/* $Revision$ */ /* $Revision$ */
/* $Date$ */ /* $Date$ */