1
0
mirror of https://github.com/f4exb/sdrangel.git synced 2026-07-11 21:34:17 -04:00

bump bundled faad2 to 2.10.1, fixes heap overflow (#2766)

This commit is contained in:
Cole Munz
2026-07-09 16:37:40 -05:00
parent 8fb29c9ddd
commit 499b75f0d2
+7 -1
View File
@@ -300,9 +300,15 @@ if (NOT ZLIB_FOUND AND NOT USE_PRECOMPILED_LIBS)
endif (NOT ZLIB_FOUND AND NOT USE_PRECOMPILED_LIBS)
if (NOT FAAD_FOUND AND NOT USE_PRECOMPILED_LIBS)
# faad2 2.8.8 is the last version SourceForge ever hosted, and it predates the 2.9.0 fix
# for a heap overflow in excluded_channels() (knik0/faad2@942c3e0a: unbounded exclude_mask
# write in the DRC parser). Later releases only live on GitHub, whose source archives don't
# include a pre-built configure script (only configure.ac), so bootstrap it first -- same
# reason libusb above fetches a release tarball instead of a bare git checkout.
ExternalProject_Add(faad
URL https://downloads.sourceforge.net/project/faac/faad2-src/faad2-2.8.0/faad2-2.8.8.tar.gz
URL https://github.com/knik0/faad2/archive/refs/tags/2.10.1.tar.gz
PREFIX "${EXTERNAL_BUILD_LIBRARIES}/faad"
PATCH_COMMAND <SOURCE_DIR>/bootstrap
CONFIGURE_COMMAND <SOURCE_DIR>/configure --prefix=<INSTALL_DIR>
TEST_COMMAND ""
)