VE7UWU/sdrangel
1
0
Fork 0
mirror of https://github.com/f4exb/sdrangel.git synced 2026-10-08 08:10:35 -04:00
Code Issues Projects Releases Wiki Activity

moddatv: Fix GCC uninitialized variable warnings

Browse Source 
Handle unsupported modulation and DVB-S code rates in
getDVBSDataBitrate() and stop checkBitrates() when no valid bitrate
can be calculated.

Signed-off-by: Robin Getz <rgetz503@gmail.com>
This commit is contained in:
Robin Getz
2026-10-03 17:35:02 -04:00
parent a209f80755
commit 4ac89f7ed2
2 changed files with 9 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/channeltx/moddatv/datvmodsettings.cpp
+6
View File
@@ -251,6 +251,9 @@ int DATVModSettings::getDVBSDataBitrate() const
case DATVModSettings::APSK32:
bitsPerSymbol = 5.0f;
break;
default:
qWarning("DATVModSettings::getDVBSDataBitrate: Unsupported modulation");
return 0;
}
if (m_standard == DATVModSettings::DVB_S)
@@ -297,6 +300,9 @@ int DATVModSettings::getDVBSDataBitrate() const
case DATVModSettings::FEC35:
convFactor = 3.0f/5.0f;
break;
default:
qWarning("DATVModSettings::getDVBSDataBitrate: Unsupported DVB-S code rate");
return 0;
}
fecFactor = rsFactor * convFactor;
plFactor = 1.0f;
plugins/channeltx/moddatv/datvmodsource.cpp
+3
View File
@@ -214,7 +214,10 @@ void DATVModSource::checkBitrates()
qDebug() << "MPEG-TS bitrate: " << m_mpegTSBitrate;
qDebug() << "DVB data bitrate: " << dataBitrate;
if (dataBitrate <= 0)
{
qWarning() << "Unable to calculate DVB data bitrate";
return;
}
if (dataBitrate < m_mpegTSBitrate)
qWarning() << "DVB data bitrate is lower than the bitrate of the MPEG transport stream";
m_tsRatio = m_mpegTSBitrate/(float)dataBitrate;