VE7UWU/sdrangel
1
0
Fork 0
mirror of https://github.com/f4exb/sdrangel.git synced 2026-07-28 13:04:17 -04:00
Code Issues Projects Releases Wiki Activity

ADSB Demod: Fix incorrect iterator range when restoring column sizes

Browse Source 
cppcheck reported that the std::copy() call used iterators from different
containers when restoring ADSB demod table column sizes.

The copy operation used settings.m_columnSizes as the source start iterator
but settings.m_columnIndexes as the source end iterator. This was likely a
copy/paste error and resulted in an invalid iterator range.

Use settings.m_columnSizes for both source iterators so column size settings
are restored correctly.

Signed-off-by: Robin Getz <rgetz503@gmail.com>
This commit is contained in:
Robin Getz
2026-07-26 13:44:02 -04:00
parent b1e685b71c
commit 66d28efcc1
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/channelrx/demodadsb/adsbdemodsettings.cpp
+1 -1
View File
@@ -531,7 +531,7 @@ void ADSBDemodSettings::applySettings(const QStringList& settingsKeys, const ADS
std::copy(std::begin(settings.m_columnIndexes), std::end(settings.m_columnIndexes), std::begin(m_columnIndexes));
}
if (settingsKeys.contains("columnSizes")) {
std::copy(std::begin(settings.m_columnSizes), std::end(settings.m_columnIndexes), std::begin(m_columnSizes));
std::copy(std::begin(settings.m_columnSizes), std::end(settings.m_columnSizes), std::begin(m_columnSizes));
}
if (settingsKeys.contains("airportRange")) {
m_airportRange = settings.m_airportRange;