VE7UWU/sdrangel
1
0
Fork 0
mirror of https://github.com/f4exb/sdrangel.git synced 2026-08-10 13:33:49 -04:00
Code Issues Projects Releases Wiki Activity

Disable sorting and fix memory leak

Browse Source
This commit is contained in:
Jon Beniston
2026-07-31 17:22:18 +01:00
parent ee7067bbc4
commit d8f3d447c8
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/channelrx/demodpager/pagerdemodnotificationdialog.cpp
+5 -5
View File
@@ -42,7 +42,7 @@ PagerDemodNotificationDialog::PagerDemodNotificationDialog(PagerDemodSettings *s
resizeTable();
for (int i = 0; i < m_settings->m_notificationSettings.size(); i++) {
addRow(m_settings->m_notificationSettings[i]);
addRow(m_settings->m_notificationSettings[i].data());
}
}
@@ -54,11 +54,10 @@ PagerDemodNotificationDialog::~PagerDemodNotificationDialog()
void PagerDemodNotificationDialog::accept()
{
qDeleteAll(m_settings->m_notificationSettings);
m_settings->m_notificationSettings.clear();
for (int i = 0; i < ui->table->rowCount(); i++)
{
PagerDemodSettings::NotificationSettings *notificationSettings = new PagerDemodSettings::NotificationSettings();
QSharedPointer<PagerDemodSettings::NotificationSettings> notificationSettings = QSharedPointer<PagerDemodSettings::NotificationSettings>::create();
int idx = ((QComboBox *)ui->table->cellWidget(i, NOTIFICATION_COL_MATCH))->currentIndex();
notificationSettings->m_matchColumn = m_columnMap[idx];
notificationSettings->m_regExp = ui->table->item(i, NOTIFICATION_COL_REG_EXP)->data(Qt::DisplayRole).toString().trimmed();
@@ -103,7 +102,7 @@ void PagerDemodNotificationDialog::on_remove_clicked()
{
int row = indexList.at(0).row();
ui->table->removeRow(row);
m_colorGUIs.removeAt(row);
delete m_colorGUIs.takeAt(row);
}
}
@@ -171,5 +170,6 @@ void PagerDemodNotificationDialog::addRow(PagerDemodSettings::NotificationSettin
ui->table->setItem(row, NOTIFICATION_COL_SPEECH, speechItem);
ui->table->setItem(row, NOTIFICATION_COL_COMMAND, commandItem);
ui->table->setCellWidget(row, NOTIFICATION_COL_PLOT_ON_MAP, plotOnMap);
ui->table->setSortingEnabled(true);
// Sorting is intentionally left disabled - the table mixes items with cell widgets and a
// parallel m_colorGUIs list indexed by row, none of which are reordered when sorting
}