mirror of
https://github.com/f4exb/sdrangel.git
synced 2026-07-26 12:04:13 -04:00
NoiseFigure: Prevent divide by zero when plotting reference data
Fix Coverity CID 649238 (DIVIDE_BY_ZERO) by validating the reference column count before using it as a divisor in plotChart(). The reference column count can be cleared when removing reference data, in on_clearReference_clicked() so ensure chart rendering handles an empty reference configuration safely. Signed-off-by: Robin Getz <rgetz503@gmail.com>
This commit is contained in:
@@ -102,7 +102,7 @@ void NoiseFigureGUI::plotChart()
|
||||
|
||||
// Create reference data series
|
||||
QLineSeries *ref = nullptr;
|
||||
if ((m_refData.size() > 0) && (ui->chartSelect->currentIndex() < m_refCols-1)) {
|
||||
if ((m_refData.size() > 0) && (m_refCols > 0) && (ui->chartSelect->currentIndex() < m_refCols-1)) {
|
||||
ref = new QLineSeries();
|
||||
for (int i = 0; i < m_refData.size() / m_refCols; i++) {
|
||||
ref->append(m_refData[i*m_refCols], m_refData[i*m_refCols+ui->chartSelect->currentIndex()+1]);
|
||||
|
||||
Reference in New Issue
Block a user