Replace variable length arrays in SumProductAlgorithm::finalp() with a
std::vector buffers.
This removes reliance on compiler VLA extensions while preserving the
existing contiguous temporary buffer layout.
Signed-off-by: Robin Getz <rgetz503@gmail.com>
Replace variable length arrays in LambdaMinAlgorithm::finalp() with
std::vector storage.
Update nth_element() usage to operate on vector iterators while removing
the non-standard VLA usage.
Signed-off-by: Robin Getz <rgetz503@gmail.com>
Replace variable length arrays in LogDomainSPA::finalp() with
std::vector buffers.
This removes reliance on compiler VLA extensions while preserving the
existing contiguous temporary buffer layout.
Signed-off-by: Robin Getz <rgetz503@gmail.com>
Replace the variable length temporary array in the int8_t FACTOR
specialization of MinSumCAlgorithm::finalp() with a std::vector buffer.
This removes reliance on compiler VLA extensions and uses standard C++
storage for the temporary reduction buffer.
Signed-off-by: Robin Getz <rgetz503@gmail.com>
Replace the variable length temporary array in the float FACTOR
specialization of MinSumCAlgorithm::finalp() with a std::vector buffer.
This removes reliance on compiler VLA extensions and uses standard C++
storage for the temporary reduction buffer.
Signed-off-by: Robin Getz <rgetz503@gmail.com>
Replace the variable length temporary array in MinSumCAlgorithm::finalp()
with a std::vector buffer.
This removes reliance on compiler VLA extensions and uses standard C++
storage for the temporary reduction buffer.
Signed-off-by: Robin Getz <rgetz503@gmail.com>
Replace variable length arrays in the int8_t FACTOR specialization of
OffsetMinSumAlgorithm::finalp() with a single std::vector scratch buffer.
This removes reliance on compiler VLA extensions while preserving the
existing contiguous temporary buffer layout.
Signed-off-by: Robin Getz <rgetz503@gmail.com>
Replace variable length arrays in OffsetMinSumAlgorithm::finalp() with a
std::vector buffers.
This removes reliance on compiler VLA extensions while preserving the
existing contiguous temporary buffer layout.
Signed-off-by: Robin Getz <rgetz503@gmail.com>
Replace variable length arrays in the int8_t specialization of
MinSumAlgorithm::finalp() with a single std::vector scratch buffer.
This removes reliance on compiler VLA extensions while preserving the
existing contiguous temporary buffer layout.
Signed-off-by: Robin Getz <rgetz503@gmail.com>
Replace variable length arrays in the float specialization of
MinSumAlgorithm::finalp() with std::vector storage.
This removes reliance on compiler VLA extensions and keeps the
temporary buffers managed by standard C++ containers.
Signed-off-by: Robin Getz <rgetz503@gmail.com>
The channel count comparison in getChannelsByDevice() accidentally used
the first plan's channel count for both operands. This caused the comparator
to always treat the channel counts as equal and sort only by bandwidth.
Use the second plan's channel count when comparing RRTurnPlans so plans are
ordered correctly by number of channels before applying the bandwidth
tie-breaker.
Signed-off-by: Robin Getz <rgetz503@gmail.com>
Replace variable length arrays in MinSumAlgorithm::finalp() with a
std::vector buffers.
Variable length arrays are a compiler extension and are not part of
standard C++. The replacement preserves the existing contiguous memory
layout while avoiding non-standard stack allocations.
Signed-off-by: Robin Getz <rgetz503@gmail.com>
Replace raw memset() initialization of hist with C++ value initialization.
This avoids bypassing std::complex object initialization and ensures the
history buffer contains valid constructed objects when HIST_FLOAT is enabled.
The previous memset() relied on the in-memory representation of
std::complex<float> and could leave non-trivial objects improperly
initialized. While this typically behaved as expected with common
implementations, it was not valid C++ object initialization.
pointed out by cppcheck as:
Using 'memset' on struct that contains a 'std::complex'
Signed-off-by: Robin Getz <rgetz503@gmail.com>
The gf2n implementation used a left shift on a potentially negative
value when masking field elements:
(~(Te)0) << N
This can result in undefined behavior for signed integer types and was
reported by static analysis (cppcheck).
Require the field element type to be unsigned and replace the mask
generation with an explicit N-bit mask constructed from the element type.
Also make the overflow check use the element type to avoid implicit
signed integer operations.
Add comments documenting the packed polynomial representation and the
GF(2^N) reduction steps to clarify the intent of the bit operations.
Fixes static analysis warning about shifting negative values.
Signed-off-by: Robin Getz <rgetz503@gmail.com>
cppcheck reported that the displayTableSettings() declaration argument
order differed from the function definition. The header declared the
arguments as (columnIndexes, columnSizes), while the implementation and
all call sites use (columnSizes, columnIndexes).
Update the declaration to match the implementation and remove ambiguity
between the table column width and ordering arrays.
Signed-off-by: Robin Getz <rgetz503@gmail.com>
cppcheck reported that the addToPowerFilter() declaration argument
order differed from the function definition. The header declared the
arguments as (y, x), while the implementation and all call sites use
(x, y).
Update the declaration to match the implementation and callers to avoid
confusion and potential misuse of the function arguments.
Signed-off-by: Robin Getz <rgetz503@gmail.com>
Jon Beniston
srcejon
Edouard Griffiths
Robin Getz