mirror of
https://github.com/f4exb/sdrangel.git
synced 2026-10-08 00:00:42 -04:00
norcal88andClaude Fable 5.1
0f8dbc2574
stop() tore the sample thread down with stopWork() + delete and only then cleared m_deviceShared.m_thread. The buddy's applySettings() suspends and resumes that thread through m_thread from another thread, without holding this device's mutex, so it could restart the thread between stopWork() and delete (QThread: Destroyed while thread is still running -> qFatal/abort), or call through the pointer after the delete. The device's own applySettings() had the same exposure on its own thread pointer, since it does not take m_mutex either. Seen when the Satellite Tracker loads presets into the Rx and Tx device sets of one Pluto at AOS: abort in PlutoSDRInputThread::~PlutoSDRInputThread <- PlutoSDRInput::stop <- DSPDeviceSourceEngine::gotoIdle. Add DevicePlutoSDRShared::m_threadsMutex (recursive, shared by all PlutoSDR device sets) and take it in start() around startWork()/publish, in stop() and handleError() around unpublish + teardown (unpublishing first), in suspendBuddies()/resumeBuddies(), and for the whole suspend -> apply -> resume sequence in applySettings(). Also wait() before deleting the thread and check the own-thread pointer before resuming it. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
SDRangel is an open-source Qt5 / OpenGL 3.0+ SDR and signal analyzer frontend to various hardware.
License : 
Source : 
Analysis : 
Issues : 
Wiki: Most of the information and documentation related to SDRangel can be found in the Wiki. Please make sure to check it in case of questions or trouble and before you post issues on GitHub. You may also seek help from other users using the discussion group below. Before running the program, make sure you read at least the Home and Quick Start pages.
Discussion group: You can ask other users for help or discuss subjects related to SDRangel and its ancillary projects here.
Ancillary projects
- SDRangelcli is a web application that can be used to control a headless (server flavor) instance of SDRangel. It can also be used as a remote control for the GUI flavor.
- SDRangel-Docker is a collection of Docker files and scripts to facilitate building and running SDRangel in a Docker container. Works for either the GUI (only on a Linux host) or the server.