mirror of
https://github.com/f4exb/sdrangel.git
synced 2026-10-08 00:00:42 -04:00
norcal88andClaude Fable 5.1
0f8dbc2574
stop() tore the sample thread down with stopWork() + delete and only then cleared m_deviceShared.m_thread. The buddy's applySettings() suspends and resumes that thread through m_thread from another thread, without holding this device's mutex, so it could restart the thread between stopWork() and delete (QThread: Destroyed while thread is still running -> qFatal/abort), or call through the pointer after the delete. The device's own applySettings() had the same exposure on its own thread pointer, since it does not take m_mutex either. Seen when the Satellite Tracker loads presets into the Rx and Tx device sets of one Pluto at AOS: abort in PlutoSDRInputThread::~PlutoSDRInputThread <- PlutoSDRInput::stop <- DSPDeviceSourceEngine::gotoIdle. Add DevicePlutoSDRShared::m_threadsMutex (recursive, shared by all PlutoSDR device sets) and take it in start() around startWork()/publish, in stop() and handleError() around unpublish + teardown (unpublishing first), in suspendBuddies()/resumeBuddies(), and for the whole suspend -> apply -> resume sequence in applySettings(). Also wait() before deleting the thread and check the own-thread pointer before resuming it. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
26 lines
1.7 KiB
C++
26 lines
1.7 KiB
C++
///////////////////////////////////////////////////////////////////////////////////
|
|
// Copyright (C) 2012 maintech GmbH, Otto-Hahn-Str. 15, 97204 Hoechberg, Germany //
|
|
// written by Christian Daniel //
|
|
// Copyright (C) 2015-2017, 2019 Edouard Griffiths, F4EXB <f4exb06@gmail.com> //
|
|
// //
|
|
// This program is free software; you can redistribute it and/or modify //
|
|
// it under the terms of the GNU General Public License as published by //
|
|
// the Free Software Foundation as version 3 of the License, or //
|
|
// (at your option) any later version. //
|
|
// //
|
|
// This program is distributed in the hope that it will be useful, //
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of //
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the //
|
|
// GNU General Public License V3 for more details. //
|
|
// //
|
|
// You should have received a copy of the GNU General Public License //
|
|
// along with this program. If not, see <http://www.gnu.org/licenses/>. //
|
|
///////////////////////////////////////////////////////////////////////////////////
|
|
|
|
#include "deviceplutosdrshared.h"
|
|
|
|
MESSAGE_CLASS_DEFINITION(DevicePlutoSDRShared::MsgCrossReportToBuddy, Message)
|
|
|
|
const unsigned int DevicePlutoSDRShared::m_sampleFifoMinRate = 48000;
|
|
QRecursiveMutex DevicePlutoSDRShared::m_threadsMutex;
|