Add unit tests for webchat

aprsd/utils/__init__.py

@@ -15,7 +15,7 @@ from .fuzzyclock import fuzzy  # noqa: F401
 from .ring_buffer import RingBuffer  # noqa: F401
 
 
-if sys.version_info.major == 3 and sys.version_info.minor >= 10:
+if sys.version_info.major == 3 and sys.version_info.minor >= 3:
     from collections.abc import MutableMapping
 else:
     from collections import MutableMapping

tests/cmds/test_webchat.py

@@ -0,0 +1,117 @@
+import typing as t
+import unittest
+from unittest import mock
+
+from click.testing import CliRunner
+import flask
+import flask_socketio
+
+from aprsd import config as aprsd_config
+from aprsd import messaging, packets
+from aprsd.cmds import webchat  # noqa
+
+from .. import fake
+
+
+F = t.TypeVar("F", bound=t.Callable[..., t.Any])
+
+
+class TestSendMessageCommand(unittest.TestCase):
+
+    def _build_config(self, login=None, password=None):
+        config = {
+            "aprs": {},
+            "aprsd": {
+                "trace": False,
+                "web": {
+                    "users": {"admin": "password"},
+                },
+                "watch_list": {"packet_keep_count": 1},
+            },
+        }
+        if login:
+            config["aprs"]["login"] = login
+
+        if password:
+            config["aprs"]["password"] = password
+
+        return aprsd_config.Config(config)
+
+    @mock.patch("aprsd.config.parse_config")
+    def test_missing_config(self, mock_parse_config):
+        CliRunner()
+        cfg = self._build_config()
+        del cfg["aprsd"]["web"]["users"]
+        mock_parse_config.return_value = cfg
+
+        server = webchat.WebChatFlask()
+        self.assertRaises(
+            KeyError,
+            server.set_config, cfg,
+        )
+
+    @mock.patch("aprsd.config.parse_config")
+    @mock.patch("aprsd.logging.log.setup_logging")
+    def test_init_flask(self, mock_logging, mock_parse_config):
+        """Make sure we get an error if there is no login and config."""
+
+        CliRunner()
+        cfg = self._build_config()
+        mock_parse_config.return_value = cfg
+
+        socketio, flask_app = webchat.init_flask(cfg, "DEBUG", False)
+        self.assertIsInstance(socketio, flask_socketio.SocketIO)
+        self.assertIsInstance(flask_app, flask.Flask)
+
+    @mock.patch("aprsd.messaging.log_message")
+    @mock.patch("aprsd.config.parse_config")
+    @mock.patch("aprsd.messaging.MsgTrack.remove")
+    @mock.patch("aprsd.cmds.webchat.socketio.emit")
+    def test_process_ack_packet(
+        self, mock_parse_config, mock_log_message,
+        mock_remove, mock_emit,
+    ):
+        config = self._build_config()
+        mock_parse_config.return_value = config
+        packet = fake.fake_packet(
+            message="blah",
+            msg_number=1,
+            message_format=packets.PACKET_TYPE_ACK,
+        )
+        socketio = mock.MagicMock()
+        packets.PacketList(config=config)
+        messaging.MsgTrack(config=config)
+        packets.WatchList(config=config)
+        packets.SeenList(config=config)
+        wcp = webchat.WebChatProcessPacketThread(config, packet, socketio)
+
+        wcp.process_ack_packet(packet)
+        mock_log_message.called_once()
+        mock_remove.called_once()
+        mock_emit.called_once()
+
+    @mock.patch("aprsd.config.parse_config")
+    @mock.patch("aprsd.packets.PacketList.add")
+    @mock.patch("aprsd.cmds.webchat.socketio.emit")
+    def test_process_non_ack_packet(
+        self, mock_parse_config,
+        mock_packet_add,
+        mock_emit,
+    ):
+        config = self._build_config()
+        mock_parse_config.return_value = config
+        packet = fake.fake_packet(
+            message="blah",
+            msg_number=1,
+            message_format=packets.PACKET_TYPE_MESSAGE,
+        )
+        socketio = mock.MagicMock()
+        packets.PacketList(config=config)
+        messaging.MsgTrack(config=config)
+        packets.WatchList(config=config)
+        packets.SeenList(config=config)
+        wcp = webchat.WebChatProcessPacketThread(config, packet, socketio)
+
+        wcp.process_non_ack_packet(packet)
+        mock_packet_add.called_once()
+        mock_emit.called_once()

tests/fake.py

@@ -16,7 +16,9 @@ def fake_packet(
     packet = {
         "from": fromcall,
         "addresse": tocall,
+        "to": tocall,
         "format": message_format,
+        "raw": "",
     }
     if message:
         packet["message_text"] = message