Move some class vars out of __init__

This ensures that connected doesn't change between calls
to the constructor.

aprsd/client/client.py

@@ -30,6 +30,13 @@ class APRSDClient(metaclass=trace.TraceWrapperMetaclass):
     driver = None
     lock = threading.Lock()
     filter = None
+    connected = False
+    running = False
+    auto_connect = True
+    login_status = {
+        'success': False,
+        'message': None,
+    }
 
     def __new__(cls, *args, **kwargs):
         """This magic turns this into a singleton."""
@@ -40,12 +47,6 @@ class APRSDClient(metaclass=trace.TraceWrapperMetaclass):
 
     def __init__(self, auto_connect: bool = True):
         self.auto_connect = auto_connect
-        self.connected = False
-        self.running = False
-        self.login_status = {
-            'success': False,
-            'message': None,
-        }
         if not self.driver:
             self.driver = DriverRegistry().get_driver()
         if self.auto_connect:
@@ -72,12 +73,6 @@ class APRSDClient(metaclass=trace.TraceWrapperMetaclass):
                 return True
         return False
 
-    # @property
-    # def is_connected(self):
-    #     if not self.driver:
-    #         return False
-    #     return self.driver.is_connected()
-
     @property
     def login_success(self):
         if not self.driver:
@@ -106,6 +101,7 @@ class APRSDClient(metaclass=trace.TraceWrapperMetaclass):
 
     @wrapt.synchronized(lock)
     def connect(self):
+        # log a stack trace here to find out who is calling us.
         if not self.driver:
             self.driver = DriverRegistry().get_driver()
         if not self.connected: