mirror of
https://github.com/craigerl/aprsd.git
synced 2026-08-29 15:28:56 -04:00
hemna
f83154b6e9
In the else-branch of USMetarPlugin.process(), 'fromcall = fromcall' is a self-assignment that does nothing. It was likely a leftover from an edit that intended to reassign fromcall but forgot to write the RHS. Remove the dead line. The variable is still used correctly on the next line (get_aprs_fi call). Closes #253
228 lines
8.4 KiB
Python
228 lines
8.4 KiB
Python
from unittest import mock
|
|
|
|
from oslo_config import cfg
|
|
|
|
from aprsd import conf # noqa: F401
|
|
from aprsd.plugins import weather as weather_plugin
|
|
|
|
from .. import fake, test_plugin
|
|
|
|
CONF = cfg.CONF
|
|
|
|
|
|
class TestUSWeatherPlugin(test_plugin.TestPlugin):
|
|
def test_not_enabled_missing_aprs_fi_key(self):
|
|
# When the aprs.fi api key isn't set, then
|
|
# the LocationPlugin will be disabled.
|
|
CONF.aprs_fi.apiKey = None
|
|
CONF.callsign = fake.FAKE_TO_CALLSIGN
|
|
wx = weather_plugin.USWeatherPlugin()
|
|
expected = "USWeatherPlugin isn't enabled"
|
|
packet = fake.fake_packet(message='weather')
|
|
actual = wx.filter(packet)
|
|
self.assertEqual(expected, actual)
|
|
|
|
@mock.patch('aprsd.plugin_utils.get_aprs_fi')
|
|
def test_failed_aprs_fi_location(self, mock_check):
|
|
# When the aprs.fi api key isn't set, then
|
|
# the Plugin will be disabled.
|
|
mock_check.side_effect = Exception
|
|
CONF.aprs_fi.apiKey = 'abc123'
|
|
CONF.callsign = fake.FAKE_TO_CALLSIGN
|
|
wx = weather_plugin.USWeatherPlugin()
|
|
expected = 'Failed to fetch aprs.fi location'
|
|
packet = fake.fake_packet(message='weather')
|
|
actual = wx.filter(packet)
|
|
self.assertEqual(expected, actual)
|
|
|
|
@mock.patch('aprsd.plugin_utils.get_aprs_fi')
|
|
def test_failed_aprs_fi_location_no_entries(self, mock_check):
|
|
# When the aprs.fi api key isn't set, then
|
|
# the Plugin will be disabled.
|
|
mock_check.return_value = {'entries': []}
|
|
CONF.aprs_fi.apiKey = 'abc123'
|
|
CONF.callsign = fake.FAKE_TO_CALLSIGN
|
|
wx = weather_plugin.USWeatherPlugin()
|
|
wx.enabled = True
|
|
expected = 'Failed to fetch aprs.fi location'
|
|
packet = fake.fake_packet(message='weather')
|
|
actual = wx.filter(packet)
|
|
self.assertEqual(expected, actual)
|
|
|
|
@mock.patch('aprsd.plugin_utils.get_aprs_fi')
|
|
@mock.patch('aprsd.plugin_utils.get_weather_gov_for_gps')
|
|
def test_unknown_gps(self, mock_weather, mock_check_aprs):
|
|
# When the aprs.fi api key isn't set, then
|
|
# the LocationPlugin will be disabled.
|
|
mock_check_aprs.return_value = {
|
|
'entries': [
|
|
{
|
|
'lat': 10,
|
|
'lng': 11,
|
|
'lasttime': 10,
|
|
},
|
|
],
|
|
}
|
|
mock_weather.side_effect = Exception
|
|
CONF.aprs_fi.apiKey = 'abc123'
|
|
CONF.callsign = fake.FAKE_TO_CALLSIGN
|
|
wx = weather_plugin.USWeatherPlugin()
|
|
wx.enabled = True
|
|
expected = 'Unable to get weather'
|
|
packet = fake.fake_packet(message='weather')
|
|
actual = wx.filter(packet)
|
|
self.assertEqual(expected, actual)
|
|
|
|
@mock.patch('aprsd.plugin_utils.get_aprs_fi')
|
|
@mock.patch('aprsd.plugin_utils.get_weather_gov_for_gps')
|
|
def test_working(self, mock_weather, mock_check_aprs):
|
|
# When the aprs.fi api key isn't set, then
|
|
# the LocationPlugin will be disabled.
|
|
mock_check_aprs.return_value = {
|
|
'entries': [
|
|
{
|
|
'lat': 10,
|
|
'lng': 11,
|
|
'lasttime': 10,
|
|
},
|
|
],
|
|
}
|
|
mock_weather.return_value = {
|
|
'currentobservation': {'Temp': '400'},
|
|
'data': {
|
|
'temperature': ['10', '11'],
|
|
'weather': ['test', 'another'],
|
|
},
|
|
'time': {'startPeriodName': ['ignored', 'sometime']},
|
|
}
|
|
CONF.aprs_fi.apiKey = 'abc123'
|
|
CONF.callsign = fake.FAKE_TO_CALLSIGN
|
|
wx = weather_plugin.USWeatherPlugin()
|
|
wx.enabled = True
|
|
expected = '400F(10F/11F) test. sometime, another.'
|
|
packet = fake.fake_packet(message='weather')
|
|
actual = wx.filter(packet)
|
|
self.assertEqual(expected, actual)
|
|
|
|
|
|
class TestUSMetarPlugin(test_plugin.TestPlugin):
|
|
def test_not_enabled_missing_aprs_fi_key(self):
|
|
# When the aprs.fi api key isn't set, then
|
|
# the LocationPlugin will be disabled.
|
|
CONF.aprs_fi.apiKey = None
|
|
wx = weather_plugin.USMetarPlugin()
|
|
expected = "USMetarPlugin isn't enabled"
|
|
packet = fake.fake_packet(message='metar')
|
|
actual = wx.filter(packet)
|
|
self.assertEqual(expected, actual)
|
|
|
|
@mock.patch('aprsd.plugin_utils.get_aprs_fi')
|
|
def test_failed_aprs_fi_location(self, mock_check):
|
|
# When the aprs.fi api key isn't set, then
|
|
# the Plugin will be disabled.
|
|
mock_check.side_effect = Exception
|
|
CONF.aprs_fi.apiKey = 'abc123'
|
|
CONF.callsign = fake.FAKE_TO_CALLSIGN
|
|
wx = weather_plugin.USMetarPlugin()
|
|
wx.enabled = True
|
|
expected = 'Failed to fetch aprs.fi location'
|
|
packet = fake.fake_packet(message='metar')
|
|
actual = wx.filter(packet)
|
|
self.assertEqual(expected, actual)
|
|
|
|
@mock.patch('aprsd.plugin_utils.get_aprs_fi')
|
|
def test_failed_aprs_fi_location_no_entries(self, mock_check):
|
|
# When the aprs.fi api key isn't set, then
|
|
# the Plugin will be disabled.
|
|
mock_check.return_value = {'entries': []}
|
|
CONF.aprs_fi.apiKey = 'abc123'
|
|
CONF.callsign = fake.FAKE_TO_CALLSIGN
|
|
wx = weather_plugin.USMetarPlugin()
|
|
wx.enabled = True
|
|
expected = 'Failed to fetch aprs.fi location'
|
|
packet = fake.fake_packet(message='metar')
|
|
actual = wx.filter(packet)
|
|
self.assertEqual(expected, actual)
|
|
|
|
@mock.patch('aprsd.plugin_utils.get_weather_gov_metar')
|
|
def test_gov_metar_fetch_fails(self, mock_metar):
|
|
mock_metar.side_effect = Exception
|
|
CONF.aprs_fi.apiKey = 'abc123'
|
|
CONF.callsign = fake.FAKE_TO_CALLSIGN
|
|
wx = weather_plugin.USMetarPlugin()
|
|
wx.enabled = True
|
|
expected = 'Unable to find station METAR'
|
|
packet = fake.fake_packet(message='metar KPAO')
|
|
actual = wx.filter(packet)
|
|
self.assertEqual(expected, actual)
|
|
|
|
@mock.patch('aprsd.plugin_utils.get_weather_gov_metar')
|
|
def test_airport_works(self, mock_metar):
|
|
class Response:
|
|
text = '{"properties": {"rawMessage": "BOGUSMETAR"}}'
|
|
|
|
mock_metar.return_value = Response()
|
|
|
|
CONF.aprs_fi.apiKey = 'abc123'
|
|
CONF.callsign = fake.FAKE_TO_CALLSIGN
|
|
wx = weather_plugin.USMetarPlugin()
|
|
wx.enabled = True
|
|
expected = 'BOGUSMETAR'
|
|
packet = fake.fake_packet(message='metar KPAO')
|
|
actual = wx.filter(packet)
|
|
self.assertEqual(expected, actual)
|
|
|
|
@mock.patch('aprsd.plugin_utils.get_weather_gov_metar')
|
|
@mock.patch('aprsd.plugin_utils.get_aprs_fi')
|
|
@mock.patch('aprsd.plugin_utils.get_weather_gov_for_gps')
|
|
def test_metar_works(self, mock_wx_for_gps, mock_check_aprs, mock_metar):
|
|
mock_wx_for_gps.return_value = {
|
|
'location': {'metar': 'BOGUSMETAR'},
|
|
}
|
|
|
|
class Response:
|
|
text = '{"properties": {"rawMessage": "BOGUSMETAR"}}'
|
|
|
|
mock_check_aprs.return_value = {
|
|
'entries': [
|
|
{
|
|
'lat': 10,
|
|
'lng': 11,
|
|
'lasttime': 10,
|
|
},
|
|
],
|
|
}
|
|
mock_metar.return_value = Response()
|
|
|
|
CONF.aprs_fi.apiKey = 'abc123'
|
|
CONF.callsign = fake.FAKE_TO_CALLSIGN
|
|
wx = weather_plugin.USMetarPlugin()
|
|
wx.enabled = True
|
|
expected = 'BOGUSMETAR'
|
|
packet = fake.fake_packet(message='metar')
|
|
actual = wx.filter(packet)
|
|
self.assertEqual(expected, actual)
|
|
|
|
@mock.patch('aprsd.plugins.weather.plugin_utils.get_aprs_fi')
|
|
def test_process_no_station_arg_uses_fromcall(self, mock_aprs_fi):
|
|
"""USMetarPlugin.process() must use packet.from_call when no station arg given.
|
|
|
|
Previously the else-branch contained the no-op 'fromcall = fromcall' which
|
|
was dead code. This test verifies that fromcall is still passed correctly
|
|
to get_aprs_fi after that line was removed.
|
|
"""
|
|
mock_aprs_fi.side_effect = Exception('aprs.fi down')
|
|
|
|
CONF.aprs_fi.apiKey = 'abc123'
|
|
CONF.callsign = fake.FAKE_TO_CALLSIGN
|
|
wx = weather_plugin.USMetarPlugin()
|
|
wx.enabled = True
|
|
|
|
# A message with no second word: regex will not match → else-branch
|
|
packet = fake.fake_packet(message='metar')
|
|
result = wx.filter(packet)
|
|
|
|
# Should call get_aprs_fi with the packet's from_call
|
|
mock_aprs_fi.assert_called_once_with('abc123', fake.FAKE_FROM_CALLSIGN)
|
|
self.assertIn('Failed', result)
|