Commit Graph

2143 Commits

Author SHA1 Message Date
yeshwanth sriram guntuka
f6059f280c qcacld-3.0: Add MBO ie in beacon template sent to fw
MBO ies sent in tail buffer of beacon params
structure are not sent in beacon template to
firmware.

Fix is to add MBO ies in beacon template sent to fw

Change-Id: I3987bd431f9a21218650499afa16eac2b59e6486
CRs-Fixed: 2087752
2017-08-06 11:48:36 -07:00
Hanumanth Reddy Pothula
0586014fbf qcacld-3.0: On PNO progress, issue PNO STOP during STA session close
In STA+AP concurrency case, driver fails to receive PNO STOP
indication from the upperlayer and thereby driver fails to send
same indication to FW, leading to a FW crash.
To mitigate this issue, during STA session close, issue PNO
stop indication to FW, if PNO is in progress.

Change-Id: If30e631fc5e8151cd5ecc66ff1d48627123a0a1e
CRs-Fixed: 2059793
2017-08-06 11:48:33 -07:00
Vidyullatha Kanchanapally
f9a0c38360 qcacld-3.0: Add support for the unified roam event
Add support for indicating the new unified roam event
"cfg80211_roamed" which takes a structure to give roam information
to cfg80211.

Change-Id: I71769666e2112e0f443cb36d7db03cb7bdbaf1f2
CRs-Fixed: 2084891
2017-08-06 05:00:07 -07:00
Nitesh Shah
45d6f33555 qcacld-3.0: Disable DBS Scan duty cycle by default
The default value for the ini gdbs_scan_selection is set
with 2 DBS and 2 non-DBS Scan for Module id WLAN_MODULE_
ROAM (5) and WLAN_MODULE_HOST (16). Thus, the scan policy
for full scan is kept getting change for DBS scan and
legacy scan.

This change is to make the default value for the ini
gdbs_scan_selection as NULL, thus disabling the DBS scan
duty cycle feature by default.

Change-Id: I8dd304628b729e11a63aaa2b6dea972cff1798d7
CRs-Fixed: 2062420
2017-08-06 00:59:57 -07:00
Naveen Rawat
3184dd846e qcacld-3.0: Fix implicit conversion error for nl80211_chan_width
Explicitly convert nl80211_chan_width to phy_ch_width in function
__wlan_hdd_cfg80211_set_mon_ch.

Change-Id: I3a35a417b1155db430d6f06444b42664365b02db
CRs-Fixed: 2071677
2017-08-06 00:59:55 -07:00
Naveen Rawat
d9dd4b33f6 qcacld-3.0: Fix implicit conversion error for sme_QosWmmDirType
Replace sme_tspec_dir_type and sme_QosWmmDirType with sme_qos_wmm_dir_type
to avoid implicit conversion warnings/errors and to conform with linux coding
guidelines.

Change-Id: I1567ebbe7ec8adab3344d96f0d2aa93367975926
CRs-Fixed: 2071677
2017-08-06 00:59:54 -07:00
Varun Reddy Yeturu
ed1215ed10 qcacld-3.0: Fix conversion from enum tSirResultCodes
Fix implicit conversion from enumeration type 'tSirResultCodes' (aka
'enum eSirResultCodes') to different enumeration type 'QDF_STATUS'
[-Wenum-conversioni]

Change-Id: I72cbfb99d22d4747890b14d474a36b3c36d1c655
CRs-Fixed: 2071677
2017-08-06 00:59:43 -07:00
jiad
d91a6840f6 qcacld-3.0: fix a double-free in ipa uc ready callback
hdd_ipa_uc_loaded_uc_cb() allocates a msg buffer and passes it to
workqueue handler. Both hdd_ipa_uc_loaded_uc_cb() and workqueue
handler free the msg buffer, which leads to wrong memory dereference.

Fix is to return directly in hdd_ipa_uc_loaded_uc_cb() and let workqueue
handler free the msg buffer.

Change-Id: I842700e7fe94dc9a77fba966d918a054bc79f36a
CRs-Fixed: 2069189
2017-08-05 23:53:31 -07:00
Sridhar Selvaraj
48c4709f8d qcacld-3.0: Move sme_config local variables to dynamic allocations
sme_config is used as local variables with struct tSmeConfigParams
in multiple places causing stack frame size to increase. This is
causing build issues with 32 bit systems where the stack frame
size is limited to 1024 bytes for each frame.

Move multiple sme_config local variables to dynamic allocations to
reduce stack frame size.

Change-Id: I86a93546adf40bbbc19438c3b1e3a7ec0d38f39f
CRs-Fixed: 2074224
2017-08-05 23:53:29 -07:00
Srinivas Girigowda
35b003149c qcacld-3.0: Fix clang warning: implicit conversion enum tDriverType
warning: implicit conversion from enumeration type 'tDriverType'
to different enumeration type 'enum driver_type' [-Wenum-conversion].

Move enum driver_type to QDF.

Change-Id: Ic89e4ee512a2d70c27324446257286aaafd49839
CRs-Fixed: 2055487
2017-08-03 19:48:58 -07:00
Srinivas Girigowda
4ffe7c8643 qcacld-3.0: Use the proper attribute PARAM_A_BAND_PELT_THLD
Due to the Change-Id: I3ad995636127a5fda0635549551a24cc5b1bd2c5
PARAM_A_BAND_PELT_THLD was incorrectly replaced with
PARAM_A_BAND_BOOST_THLD.

Fix this and bring back the attribute PARAM_A_BAND_PELT_THLD.

Change-Id: I83d21c2b4662c82d2f26f3bcd10a549889f6df1e
CRs-Fixed: 2055487
2017-08-03 19:48:56 -07:00
Srinivas Girigowda
72f3039ec5 qcacld-3.0: Split __wlan_hdd_cfg80211_set_ext_roam_params()
Split __wlan_hdd_cfg80211_set_ext_roam_params() into
multiple functions to improve readability of the code and
fix clang warning (-Wframe-larger-than).

Change-Id: I3ad995636127a5fda0635549551a24cc5b1bd2c5
CRs-Fixed: 2055487
2017-08-03 19:48:53 -07:00
Srinivas Girigowda
a8f66581e7 qcacld-3.0: Fix to set roaming capability in get_supported_features()
Because of obsolete macros FEATURE_WLAN_LFR and WLAN_FEATURE_ROAM_SCAN_OFFLOAD
roaming capability is not properly set in get_supported_features.

Fix this by using the proper macros.

Change-Id: I4dec8c32c71fde01b663e11e60f1da171adee3e4
CRs-Fixed: 2067126
2017-08-03 19:48:51 -07:00
Srinivas Girigowda
8df27eacb6 qcacld-3.0: Enable feature bits in get_supported_features()
This is a qcacld-2.0 to qcacld-3.0 propagation.

Enable feature bits WIFI_FEATURE_CONTROL_ROAMING,
WIFI_FEATURE_IE_WHITELIST and WIFI_FEATURE_SCAN_RAND.

Change-Id: Ia0f136e038e7da040faae04eaa11bcf56bb72443
CRs-Fixed: 1102187
2017-08-03 19:48:49 -07:00
Srinivas Girigowda
9eb807b939 qcacld-3.0: Fix array out-of-bounds & integer underflow in _iw_set_genie
This is a qcacld-2.0 to qcacld-3.0 propagation

'wrqu->data.length' holds the total number of IE data buffer.
Add a check to make sure the number of remaining data to be read is
greater than or equal to IE length.

Also, advance the buffer pointer to point to the next element only
if next element is present.

Change-Id: Ic60f3e0650f365955dab4099eb8740e9789e00cc
CRs-Fixed: 1100132
2017-08-03 19:48:47 -07:00
Mohit Khanna
ceb9778bfc qcacld-3.0: Dump DPTRACE on cfg8011 disconnect
Dump the last few (100) DPTRACE records when a cfg80211 disconnect is
received from the userspace with reason code WLAN_REASON_DEAUTH_LEAVING.

Change-Id: Ib370f8d8b71f20364e0da73a1aee5673c0fc4ca4
CRs-Fixed: 2029713
2017-08-03 16:34:41 -07:00
Mahesh Kumar Kalikot Veetil
aff9486ae9 qcacld-3.0: Refactor hdd_register_interface()
Unify hdd_register_interface() and hdd_register_hostapd(). Update
failure log with error status and device name in case of
register_netdevice(), register_netdev() or dev_alloc_name() failures.

Change-Id: I428c73d473de6dc2e61567129e9f2a7996631729
CRs-Fixed: 2085098
2017-08-03 16:34:39 -07:00
jiad
9d472c9da0 qcacld-3.0: fix possible race condition in hdd IPA
hdd_ipa->sta_connected in WLAN_CLIENT_DISCONNECT case is not under lock
protection and is prone to race conditions.

Fix is to release event_lock after checking sta_connected so as to avoid
possible race conditions.

Change-Id: I6206d5d0cc2cf5df02ab4caf0de810961da21006
CRs-Fixed: 2082525
2017-08-03 16:34:37 -07:00
Hanumanth Reddy Pothula
30645a805e qcacld-3.0: Resolve out of bound memory access, while processing setpno
propagation from qcacld-2.0 to qcacld-3.0.

While processing setpno ioctl, there is an out of bound memory
issue when Host is copying ioctl arguments to a local buffer.

While copying ioctl arguments, make sure valid indices are used.

Change-Id: I03078df7135f5f1daf1d9bead7d4410e58fb848a
CRs-Fixed: 1112355
2017-08-02 14:04:37 -07:00
Kapil Gupta
aa902a74fe qcacld-3.0: Enable PER roam by default
Add changes to enabled PER based roaming by default.

Change-Id: I72f0d4826b2841038e609dd0afcb771bcb715d49
CRs-Fixed: 2026668
2017-08-01 00:57:26 -07:00
Dustin Brown
84411b0e45 qcacld-3.0: Flush pending powersave timers during suspend
Currently, auto powersave timers are deferrable. This means any pending
auto powersave timers will not fire while the device is supended, which
can have a negative impact on wlan power usage. Instead, flush any
pending auto powersave timers during the suspend process, to ensure
powersave is enabled while the device is suspended.

Change-Id: I5911ee30eaf770909b728af73958ba1bbaa8457f
CRs-Fixed: 2080812
2017-07-31 18:53:15 -07:00
Sravan Kumar Kairam
6b92adff7d qcacld-3.0: Disconnect TX pipe when RX pipe connect fails
Currently when IPA RX WDI pipe connect fails during start modules
host does not clean up the TX pipe which is allocated before the
RX pipe. As part of proper clean up from host in this change
disconnect the TX pipe handle when RX pipe connect returns failure.

Change-Id: Ic037dd2415ab5be497a0617d8151d63219868fd1
CRs-Fixed: 2040146
2017-07-31 18:53:14 -07:00
Nachiket Kukade
4fa80f430a qcacld-3.0: Enable Force 1x1 WAR by default
Setting gForce1x1Exception=1 in ini forces DUT to associate to
buggy AP's which are identified via OUI. Enable this feature by
default on all platforms by setting CFG_FORCE_1X1_DEFAULT=1.

Change-Id: Ic459d821f4aedba966beab8ca8ca977b7b639e34
CRs-Fixed: 2084927
2017-07-31 17:52:49 -07:00
Ravi Kumar Bokka
0bfdd98432 qcacld-3.0: Modify default ini value for EGAP feature
Change default gEnableGreenAp ini value from zero to one

Change-Id: Id9d28ea69f6369d0e23576873177da9d0e6641ad
CRs-Fixed: 2036858
2017-07-31 07:14:22 -07:00
SaidiReddy Yenuga
8c85acb5e8 qcacld-3.0: Validate NLA attr in hdd_extscan_passpoint_fill_network_list
NLA attribute
QCA_WLAN_VENDOR_ATTR_PNO_PASSPOINT_LIST_PARAM_NETWORK_ARRAY
used without validation.

validate NLA attribute.

CRs-Fixed: 2025685
Change-Id: I141d5e6b3872df70b18797a99c943fca1cc5d31e
2017-07-31 07:14:21 -07:00
SaidiReddy Yenuga
3db3877f07 qcacld-3.0: Validate NLA attr in wlan_hdd_cfg80211_ocb_set_config API
NLA attributes QCA_WLAN_VENDOR_ATTR_OCB_SET_CONFIG_NDL_CHANNEL_ARRAY,
QCA_WLAN_VENDOR_ATTR_OCB_SET_CONFIG_NDL_ACTIVE_STATE_ARRAY,
QCA_WLAN_VENDOR_ATTR_OCB_SET_CONFIG_CHANNEL_ARRAY used without
validation.

validate NLA attributes.

CRs-Fixed: 2025619
Change-Id: Ib5aae0d89b06913ec57ce446a2bd8925d125dfea
2017-07-31 07:14:19 -07:00
SaidiReddy Yenuga
32fa740c85 qcacld-3.0: validate NLA attr in wlan_hdd_cfg80211_set_ext_roam_params
NLA attr QCA_WLAN_VENDOR_ATTR_ROAMING_PARAM_SET_BSSID_PREFS
used without validation.

validate NLA attribute.

CRs-Fixed: 2025636
Change-Id: I810f6a15b425638330211919c606e52de562cf9c
2017-07-31 07:14:17 -07:00
SaidiReddy Yenuga
a56dc1e5b0 qcacld-3.0: Trim operation classes to max supported in change station
qcacld-2.0 to qcacld-3.0 Propagation.

Operation classes supported can be controlled by user, which can
be sent greater than the max supported operations. This results
in stack overflow in change station command.

Add check to validate operations supported param given by user
and if it exceeds max supported value, set it to max supported
value.

CRs-Fixed: 2002052
Change-Id: Idd3a35e38b091546a17d7ec6329f19429e5c289c
2017-07-31 07:14:15 -07:00
SaidiReddy Yenuga
0b2c9f4d02 qcacld-3.0: Add bounday check for multicastAddr array
qcacld-2.0 to qcacld-3.0 propagation.

In hdd_set_rx_filter API multicastAddr array being accessed beyond
its size.

Add boundary check for multicastAddr.

CRs-Fixed: 1104565
Change-Id: I8e1543a8f42ac40c04d2c6a17e69718d13cbd706
2017-07-31 07:14:13 -07:00
Manjeet Singh
00b2a567ad qcacld-3.0: Add buf len check in wlan_hdd_cfg80211_testmode
qcacld-2.0 to qcacld-3.0 propagation.

In __wlan_hdd_cfg80211_testmode API no checks are in place that
ensure that buflen is smaller or equal the size of the stack
variable hb_params. Hence, the vos_mem_copy() call can overflow
stack memory.

Add buf len check to avoid stack overflow

CRs-Fixed: 1105085
Change-Id: I6af6a74cc38ebce3337120adcf7e9595f22d3d8c
2017-07-31 03:52:14 -07:00
Nachiket Kukade
dbffab89f6 qcacld-3.0: Do not allow ns offload in IBSS mode
NS Offload is not supported in IBSS mode. Configuring it while
in IBSS mode causes crash in firmware.

Do not allow ns offload in IBSS mode.

Change-Id: I1f6cf7b6c65238a9335f828321487ea784a4512b
CRs-Fixed: 2035449
2017-07-31 00:35:24 -07:00
Manjeet Singh
a5acc16871 qcacld-3.0: Add INI template for SSR feature
Add INI template for ssr feature for documentation.

CRs-Fixed: 1108400
Change-Id: I4c14205aab5d3ab353eb39cc0c04e18a2d6fe576
2017-07-30 14:00:47 -07:00
Nachiket Kukade
e4d8644dac qcacld-3.0: Populate the remaining addresses from tha wlan_mac.bin address
Currently if only one address is provided in wlan_mac.bin, it is updated
for interface wlan0. It will be copied to interface p2p0 if a specific
configuration is present. softap0 retains its mac address either generated
from serial number or given through Firmware ready event. This doesn't
guarentee a unique mac address to both these interfaces.
Regardless of configuration Both softap0 and p2p0 should have a unique
mac address with locally administered bit set.

Change-Id: I64299f5c2e2376c8dbdb26ea34ba0187d5d1f28d
CRs-Fixed: 2066086
2017-07-30 14:00:45 -07:00
Sravan Kumar Kairam
4e82af92a9 qcacld-3.0: Fix 32 bit host arch wlan crash during load
Currently during IPA pipes connect host is passing size of each TX
completion ring size as 4 bytes instead of 8 bytes which is expected
by IPA driver. Reason is host passes size of each ring as size of
dma_addr_t which is 4 bytes for 32 bit host architecture where as
bus addresses are of 8 bytes on MAC and IPA. Fix this by passing the
size which is correct and expected by the IPA driver.

Change-Id: Ib081a3819d3a5e4f7ac61606d5ecb9aa5f3242c8
CRs-Fixed: 2037661
2017-07-30 13:02:29 -07:00
Ashish Kumar Dhanotiya
0fa8ee06b3 qcacld-3.0: Fix Uninitialized memory issue
Propagation from qcacld-2.0 to qcacld-3.0.

There is a possibility to read uninitialized memory within api
__wlan_hdd_cfg80211_testmode.
To resolve this issue, initilaize buffer hb_params with zero.

Change-Id: Ia8061610a8c35aa7290177c0dcd2c5c36d9fcb35
CRs-Fixed: 2075796
2017-07-30 13:02:28 -07:00
Manjeet Singh
3abd7300a5 qcacld-3.0: Accept gscan request only if netdev is up
The vendor command QCA_NL80211_VENDOR_SUBCMD_EXTSCAN_GET_VALID_CHANNELS
coming in netdev down state resulting in crash.

Add WIPHY_VENDOR_CMD_NEED_RUNNING flag to reject the vendor command
QCA_NL80211_VENDOR_SUBCMD_EXTSCAN_GET_VALID_CHANNELS if netdev is down.

CRs-Fixed: 1109145
Change-Id: I007341a51ccdd1b5cf5b6e2319c8b71d4f26f9ce
2017-07-30 13:02:26 -07:00
Manjeet Singh
91b7bb8a20 qcacld-3.0: Enable QPOWER only for STA modes
Currently sending qpower to FW in softap mode causes device to crash as
qpower config is not supported.
Enable QPOWER config in STA and P2P-CLI modes.

Change-Id: Idb8b3ac79e6c93533b752ac42d6ab57bb0c86579
CRs-Fixed: 2003839
2017-07-30 13:02:24 -07:00
Agrawal Ashish
569ad261ac qcacld-3.0: Correct NSS in case of DBS hw mode
In case of DBS hw mode, NSS should be reduce by 1

Change-Id: I3d3f0dbd23a7336eb448628ade763668041a640d
CRs-Fixed: 2038087
2017-07-30 13:02:18 -07:00
Nachiket Kukade
33c34e3228 qcacld-3.0: Update missing vht capabilities in wiphy before registering
Currently while registering wiphy, supported Beamformee STS Capability
and Number of Sounding Dimensions are not updated in the vhtcap field.
This results in hostapd failing to start if above two configurations
are enabled in the conf file.
Update missing vht capabilities in wiphy before registering.

Change-Id: I8db376fe1f14fd5b722e67a5889addf4c2fb7f28
CRs-Fixed: 2062520
2017-07-30 12:01:54 -07:00
SaidiReddy Yenuga
c0c34cfd5d qcacld-3.0: Fix uninitialised variables in HDD
In packet log header, element type_specific_data used uninitialised.

Initialise type_specific_data.

CRs-Fixed: 2015997
Change-Id: Ifa2bdc4c10528c8e9781249058e1767d64bec60e
2017-07-30 12:01:52 -07:00
Agrawal Ashish
87ec5d48c8 qcacld-3.0: Indicate HB failure, HO failure and no scan result as FATAL
In packet logs currently HB failure, HO failure and No scan results
are marked as Non Fatal and because of that, these failures are not captured
in packet logs.
Fix this by making these events as FATAL.

Change-Id: I6db2f3cd843b7f84081332f2385fbfb0a2992078
CRs-Fixed: 2061842
2017-07-30 11:00:09 -07:00
Nachiket Kukade
c34d4a3352 qcacld-3.0: Set timer expiry on queued HDD scan requests
In certain cases HDD fails to receive callbacks for the scan requests
queued to SME. Kernel may free up these scan requests due to timeout.
During driver shutdown and exit if scan done is performed on these
stale scan requests, kernel crash may occur.

Set a timer of 60 seconds on queued scan requests, after expiry BUG_ON
for debugging purposes.

Change-Id: I6db155b17a8a5ae87208ec84eaab221a53623a63
CRs-Fixed: 2070594
2017-07-30 11:00:06 -07:00
Ganesh Kondabattini
0dc1a6e77a qcacld-3.0: Handle error cases while registering frames
If registration of callback 'hdd_send_action_cnf_cb' fails with PE due
to some error case, then PE is not going give the ack confirmation
for action frames which can lead to in p2p connection failure.

CRs-Fixed: 2075708
Change-Id: Ia7b670f186975f5139e37e79230de56bc8ab868b
2017-07-30 10:04:17 -07:00
SaidiReddy Yenuga
28dc327cfe qcacld-3.0: Move log level to info if host fails to get valid STA-ID
During wlan disconnect before disabling tx queues, observed continuous
logs in ndo_start_xmit, because of invalid station ID, leading to WD bark.

Move log level to info from error, if driver fails to find valid station
ID while processing ndo_start_xmit.

CRs-Fixed: 2022473
Change-Id: I122219d22e2e19ddb3ca6aa60c38177f2a95ac43
2017-07-30 10:04:15 -07:00
Manjeet Singh
a9cae43599 qcacld-3.0: Add support for band specific preference
Add support for 5Ghz network RSSI boost/penalty preference
based on ini values.

Change-Id: Ia3ae5dcc35b9a85fde5a609f8f27ff8b4bc35cec
CRs-fixed: 1085554
2017-07-30 09:09:12 -07:00
Agrawal Ashish
bafaff128b qcacld-3.0: Add INI and IOCTL template for SAP ACS feature
Add INI and IOCTL template for SAP ACS feature for documentation.

Change-Id: Id8088ee9b1f79c975d15d71c10aca1e05e35f82b
CRs-Fixed: 1105602
2017-07-30 09:09:10 -07:00
Agrawal Ashish
b114b6726b qcacld-3.0: Don't update MBO IEs twice
Driver should not send MBO IEs if MBO Ies come from supplicant.

Change-Id: I7ad27759ba2454465f3e204d207cb58eaf8804a9
CRs-Fixed: 2044567
2017-07-30 09:09:08 -07:00
Agrawal Ashish
e030f78aef qcacld-3.0: Add INI template for P2P feature
Add INI template for P2P feature for documentation.

Change-Id: I7d9fcb2272e0d105fd81bbeea9e387ce40ffa5b5
CRs-Fixed: 1116847
2017-07-30 07:50:15 -07:00
SaidiReddy Yenuga
c533202e26 qcacld-3.0: Validate NLA attr in hdd_extscan_epno_fill_network_list
NLA attribute
QCA_WLAN_VENDOR_ATTR_PNO_SET_LIST_PARAM_EPNO_NETWORKS_LIST
used without validation.

validate NLA attribute.

CRs-Fixed: 2025680
Change-Id: I4da7dbe44325b0ed6346b363b71b558250996f8c
2017-07-29 23:39:01 -07:00
Ashish Kumar Dhanotiya
0f2ef95a2a qcacld-3.0: Fix kernel checkpatch warnings in wlan_hdd_scan.c
Fix kernel checkpatch warnings in wlan_hdd_scan.c

Change-Id: Iadace9583f8396a11de64682b95e1f63073f67f6
CRs-Fixed: 2024274
2017-07-27 16:59:40 -07:00