The driver currently defines two different data structures to hold
Delete Tspec parameters:
- tDelTsParams
- struct del_ts_param
In this case having two different structures to provide the same
functionality is pointless. Furthermore, due to the way in which these
structures are used, there is an implicit requirement that they be
exactly identical. This approach is very fragile. To align with the
converged software architecture and to improve code maintainability
remove the legacy typedef and exclusively use the unified WMI
structure.
Change-Id: Ia70b1e17e4446259ff32107ffbc11646d078e1c0
CRs-Fixed: 2371915
The driver currently defines two different data structures to hold
Add Tspec parameters:
- tAddTsParams
- struct add_ts_param
In this case having two different structures to provide the same
functionality is pointless. Furthermore, due to the way in which these
structures are used, there is an implicit requirement that they be
exactly identical. This approach is very fragile. To align with the
converged software architecture and to improve code maintainability
remove the legacy typedef and exclusively use the unified WMI
structure.
Change-Id: I298202748b8a0f6c2a9f8a36ca7cdee071d000bf
CRs-Fixed: 2371914
The driver currently defines two different data structures to hold
Delete Tspec Request parameters:
- tSirDeltsReqInfo
- struct delts_req_info
In this case having two different structures to provide the same
functionality is pointless. Furthermore, due to the way in which these
structures are used, there is an implicit requirement that they be
exactly identical. This approach is very fragile. To align with the
converged software architecture and to improve code maintainability
remove the legacy typedef and exclusively use the unified WMI
structure.
Change-Id: I0951c8da636bcbf81a335c0ea1250d721ca5c573
CRs-Fixed: 2371913
The driver currently defines two different data structures to hold
aggregate AddTspec parameters:
- tAggrAddTsParams
- struct aggr_add_ts_param
In this case having two different structures to provide the same
functionality is pointless. Furthermore, due to the way in which these
structures are used, there is an implicit requirement that they be
exactly identical. This approach is very fragile. To align with the
converged software architecture and to improve code maintainability
remove the legacy typedef and exclusively use the unified WMI
structure.
Change-Id: I960bd79b04838ac675ad49e332a47671faccaaa7
CRs-Fixed: 2371912
The driver currently defines two different data structures to hold
a TSpec IE field:
- tSirMacTspecIE
- struct mac_tspec_ie
In this case having two different structures to provide the same
functionality is pointless. Furthermore, due to the way in which these
structures are used, there is an implicit requirement that they be
exactly identical. This approach is very fragile. To align with the
converged software architecture and to improve code maintainability
remove the legacy typedef and exclusively use the unified WMI
structure.
Change-Id: I2e9da1d72dae3c4b0baa13306ee7ec127895a4f2
CRs-Fixed: 2371911
Add host support for db2dbm RSSI changes. Firmware
indicates this capability when underlying hardware
has RSSI reporting feature. Based on this capability
host will know if firmware sends SNR or RSSI. If no
capablity is present then host will convert SNR to
rssi using a fixed offset of -96. If capability is
present host will directly use the rssi as it is.
Change-Id: I9058f16c6280d466feb96cf88a8a0d8cd7b02032
CRs-Fixed: 2364023
In wma_hold_req_timer(), if wma_crash_on_fw_timeout()
is true, SSR will be triggered, but allocated memory
such as user_data, params and resp are not freed,
result in memory leak.
Fix is to still do wma_send_msg_high_priority() when
wma_crash_on_fw_timeout()is true, so allocated memory
can be freed.
Change-Id: I798bb864e8ad6dc7eb67401a820dc0896892e65e
CRs-Fixed: 2370594
The driver currently defines three different data structures to hold
mobility domain information:
- tSirMobilityDomainInfo
- tCsrMobilityDomainInfo
- struct mobility_domain_info
To align with the converged software architecture remove the two
legacy typedefs and exclusively use the unified WMI structure.
Change-Id: I317b90e47c3db8b74a76c297f6bc42301fa2f80e
CRs-Fixed: 2369476
Replace legacy isRoamOffloadEnabled from csr_config with
converged flag lfr3_roaming_offload.
Fix CamelCase issues for roam offload part.
Change-Id: I89ceda876d5549e9b0959e7e25e317c9667594b5
CRs-Fixed: 2367873
After replace CONFIG_MCL with WLAN_FEATURE_ROAM_OFFLOAD in
struct roam_offload_scan_params, roam_offload_params is only
defined under MACRO WLAN_FEATURE_ROAM_OFFLOAD, any access to
roam_offload_params should be under WLAN_FEATURE_ROAM_OFFLOAD.
Refactor function wma_roam_scan_offload_mode, separate roam scan
offload parameters config to another function.
Change-Id: I3b9306ef3c3ad9c451ffb450df9521cde609bca4
CRs-Fixed: 2367841
Change Ib9cdaf7e8aa019002b9fc02d8ffacfcdb28fc121 ("qcacld-3.0:
Remove sme_ipa_uc_stat_request()") removed the last client of
wma_ipa_uc_stat_request(). Since this function is now obsolete,
remove it.
Change-Id: I965ccad2e94246c0d7d57e85c1fa433eeb5c136e
CRs-Fixed: 2371196
Change Ief51bcf611d5d5759fa04e05c0bb4d96e44c7a29 ("qcacld-3.0:
Remove sme_get_wcnss_*_version()") removed the last client of
wma_get_wcnss_software_version(). Since this function is obsolete,
remove it.
Change-Id: Ie3e8fcb48e45deebc750c9886f268d5306a7b705
CRs-Fixed: 2371195
The is_nan_enabled flag in wma_handle_t is written but never read.
Since it is unused, remove it along with the logic that writes it.
Change-Id: I3e7d09ac1ab77427d37a8a45ca5f1612b05c5339
CRs-Fixed: 2370875
The current version of the driver does not have an implementation of
wma_wow_tx_complete(), so remove the obsolete prototype.
Change-Id: Ieb91ebeade812ed4ba4ba25f93a63e4e33cad8ff
CRs-Fixed: 2370020
WMA_UPDATE_CF_IND message (aka SIR_HAL_UPDATE_CF_IND) is dead code, because
it is not processed anywhere.
Remove dead code WMA_UPDATE_CF_IND. The only use of tUpdateCFParams is in
lim_send_cf_params() which only creates a WMA_UPDATE_CF_IND message, so
remove tUpdateCFParams and lim_send_cf_params().
Change-Id: I1b613300cdd7eeeb33825e319977ff941cae548c
CRs-Fixed: 2367931
NAN component has been moved to CLD. It includes implementation
of the new NAN command QCA_NL80211_VENDOR_SUBCMD_NAN_EXT.
Change the legacy NAN implementation of vendor cmd
QCA_NL80211_VENDOR_SUBCMD_NAN so that the requests go
through the NAN component. Clean up the legacy path.
Functionality remains unchanged for legacy command.
Route the legacy NAN commands through the NAN component.
Change-Id: I542e5afe832619f8c088220cc4456aa7fe4416fd
CRs-Fixed: 2356772
Host will receive the NAN related service capabilities from
the SERVICE_AVAILABLE event. In the HDD callback that gets
called afterwards, set the NAN related capabilities into
the NAN's private PSOC object.
Store the NAN target capabilities inside its private object.
Change-Id: If398b6f253613fc424b7821cfc62b0984ad34b6c
CRs-Fixed: 2356709
Previously change I5828002d2363e01f63b0a643a0c59abd52bc4f19
("qcacld-3.0: NAN datapath cleanup") removed the code that uses
the pe_ndp_event_handler but did not remove the field from the
t_wma_handle structure, so remove it now.
Change-Id: I4b23e55fcdb8178d6a272fd46094af5505b94cc7
CRs-Fixed: 2365061
During channel switch if the new channel's phymode is different
than the old channel the host will update its phymode and
send vdev restart to firmware. Once vdev restart resp is received,
host sends new phymode and channel width to the firmware.
If host process beacon with opmode IE while waiting for vdev restart
response, it check if new channel width in bcn is valid for new
phymode and send channel width to firmware. If channel width changed
is greater than allowed value for older phymode, firmware is not able
to handle it.
Fix is to ignore any opmode IE during channel switch. Also ignore
the beacons with CSA/ECSA IE if channel switch detection is
offloaded. The opmode or any other change in beacon will be detected
with the beacons on new channel once AP moves to new channel.
Change-Id: If3bfb555dfa7b63dc997bbdf2fe6a0836bcf17fd
CRs-Fixed: 2361553
wma_remove_bss_peer doesn't need req_msg, as only vdev id is
needed. So refine the function definition of wma_remove_bss_peer.
Remove calls to wma_cleanup_target_req_param() if
wma_remove_bss_peer succeeds, as it posts the req->user_data to
firmware. Add debugs in wma_remove_bss path to get more info.
Change-Id: I0d8f0bd74784f0a4542e8ae6301471804285752d
CRs-Fixed: 2363696
After gerrit#2436786, vdev in monitor mode is removed from vdev
list of pdev. So it is needed to use the new cdp api, which is
cdp_get_mon_vdev_from_pdev in stead of cdp_get_vdev_from_vdev_id
in monitor mode to register vdev.
CRs-Fixed: 2359997
Change-Id: I75cad531e161748a3830104516e44079dee636ec
WLAN Latency Manager support is one of the capabilities that is sent
along with the service bits by firmware. Currently, driver is not
exposing this feature to the user space.
Create and add support for a feature flag to expose this feature to the
userspace.
Change-Id: Ica8213bdaeb32c7be01b6a71a7d8b7a32dc8611b
CRs-Fixed: 2363704
The file cds_ieee80211_common.h contains a large number of macros that
are used to describe most fields in IEEE 802.11 frames. Despite that,
currently WMA has an enum ds_mode to represent the Distribution System
Mode settings. In order to avoid unnecessary duplicate definitions
remove enum ds_mode and instead use the cds_ieee80211_common macros.
Change-Id: I0dc722009e063a1eac0da4afbe77f96772c583b2
CRs-Fixed: 2365060
Previously change I750870ccbe84e817954a3ee1a50e2e8daa5ab661
("qcacld-3.0: Remove obsolete P2P Listen Offload from WMA") removed
the only code that used the p2p_lo_in_progress field in struct
wma_txrx_node. Since it is now obsolete, remove it.
Change-Id: I9e9247a578fb07ef8089f2b5eb544e4e6595244a
CRs-Fixed: 2365059
Previously change Iba16643adf1cbd997138c740345e40c00c8e81f6
("qcacld-3.0: Add Suspend and Resume support in PMO") relocated
Suspend/Resume support from WMA to PMO. However that change left
behind in WMA some remnants that are no longer useful such as the
wma_resume_event, so remove them.
Change-Id: Icf35bafd8fdacdbdc71cfb4309a8bd15bfb1a244
CRs-Fixed: 2365057
Currently some of the parameter names used in the implementation of
wma_mcs_rate_match() do not match the names used in the prototype.
This can be confusing to both humans and to code analysis tools, so
change the camelCase names used in the implementation to match the
prototype.
Change-Id: I87a85a7f1affa6bcad75f33f2bca6aa67475aa47
CRs-Fixed: 2365056
Previously change Id965dd8ee0fbddfa563335fd2fe225dcd20cd162
("qcacld-3.0: Port modulated dtim and override listen interval")
relocated support for configuring Modulated DTIM and Listen Offload
from WMA to PMO. The associated enumerations in enum GEN_PARAM are now
obsolete, so remove them, along with their default value macros.
Change-Id: Iac88c4b5578c24b6fcaefb935459f6e988892a1a
CRs-Fixed: 2365055
The driver contains a prototype for wma_map_channel() but no
implementation, so remove the prototype.
Change-Id: I1a8794c103ac78df8ef4fd1c181ee60350c88058
CRs-Fixed: 2365054
wma_api.h contains two prototypes for functions that are no longer
a part of the driver, so remove them.
Change-Id: I79c96320a23471e0c21cc04ec1b207cda76db199
CRs-Fixed: 2365053
Both tEnablePsParams and tDisablePsParams contain unused fields, so
remove them.
Change-Id: I148c065ac5425a7695ef7bf1d54bf7975b1ef10e
CRs-Fixed: 2364269
Currently the prototype and the implementation of wma_tx_packet() use
different identifiers for some of the parameters, which is confusing
to both programmers and to tools. In addition currently the
implementation is documented instead of the interface. Therefore move
the documentation to the header file, and changed the prototype to
match the implementation.
Change-Id: I2c2e36c5b85935c37271336970c6532495c20fa6
CRs-Fixed: 2364268
The original definition of struct wmi_unified_pmk_cache had several
anomalies:
1) It contains an unnecessary tlv_header field. Only the fw-api
structs should contain TLV headers.
2) It contains a mis-named session_id field. Common structures should
use converged terminology, in this case vdev_id
qca-wifi-host-cmn change If4be27111c604c16ea437aa654210cdff28220a7
("qcacmn: Refine struct wmi_unified_pmk_cache (phase 1)") completely
addressed the first issue, and as the first phase of fixing the second
issue it replaced the session_id field with an anonymous union which
contains both the existing session_id field and a new vdev_id field.
Being part of a union these field will overlay each other.
For the current phase replace the reference to session_id with a
reference to vdev_id in sme_set_del_pmkid_cache().
Change-Id: Ief4bcb819cb3c842adb74904f2cb2483476eaeb9
CRs-Fixed: 2363433
Implementation of Host driver support to collect per Vdev Beacon
reception Stats from firmware and display the stats in sysfs.
"adb shell cat /sys/class/net/wlan0/beacon_stats"
vdev id: 0
Total Beacon Count: 255
Total Beacon Miss Count: 21
Beacon Miss Bit map [0x800] [0x10000000] [0x22000400] [0x100]
[0x84000000] [0x4030002] [0x5034000] [0x28084]
Change-Id: Iadd31042320f7815a6a6f4733f5393dba93b5b3e
CRs-Fixed: 2360913
Previously change I7faaf646df363a74954defbef103afbb4b72af92
("qcacld-3.0: Add extended IBSS feature on qcacld-3.0") introduced two
different typedefs to serve the same purpose, txFailIndCallback which
is in use, and wma_txFailIndCallback which is unused, so remove the
unused one.
Change-Id: Icc3e016337500e4899d6bc2dc257a61d82f0ec65
CRs-Fixed: 2364267
Previously change I6786ce42d99d6a3f29561c24dea7e3018fb0f3e9
("qcacld-3.0: Refactor formation of wmi scan roaming commands")
removed all of the clients of wma_get_hotlist_entries_per_page(),
so now remove this unused function.
Change-Id: I2a8931a9152b84f589e0b41a7c5138112db22985
CRs-Fixed: 2364106
In wma_process_pdev_hw_mode_trans_ind() vdev_mac_entry is used to copy the
pdev_id and vdev_id values from a for loop.
vdev_mac_entry is never checked before if it is allocated and can lead to
null pointer dereference.
Change-Id: I44ea6f5262bf39116af33a4d833a2c77d7963626
CRs-Fixed: 2359250
The PERE_IP_HDR_ALIGNMENT_WAR feature does not apply to hardware
supported by this driver, and the code would not build correctly
if the feature was enabled, so completely remove the feature.
Change-Id: I4697e798dc57ab7e51c88d40e4d0f9a26a98de6d
CRs-Fixed: 2363232
The following functions are unused, so remove them:
- wma_is_sap_active()
- wma_is_p2p_go_active()
- wma_is_p2p_cli_active()
- wma_is_sta_active()
Change-Id: I801176fb2b4df9308744fcde27dc789e88e1e550
CRs-Fixed: 2361895
Although the implementation has been removed, the prototype for
wma_update_vdev_tbl() is still present, so remove it as well.
Change-Id: Ifcf10e97d0bc24bdf88c69f936e998b228ec945b
CRs-Fixed: 2361930
