Craig Gallek b922622ec6 sock_diag: don't broadcast kernel sockets ... Kernel sockets do not hold a reference for the network namespace to which they point. Socket destruction broadcasting relies on the network namespace and will cause the splat below when a kernel socket is destroyed. This fix simply ignores kernel sockets when they are destroyed. Reported as: general protection fault: 0000 [#1] PREEMPT SMP DEBUG_PAGEALLOC CPU: 1 PID: 9130 Comm: kworker/1:1 Not tainted 4.1.0-gelk-debug+ #1 Workqueue: sock_diag_events sock_diag_broadcast_destroy_work Stack: ffff8800b9c586c0 ffff8800b9c586c0 ffff8800ac4692c0 ffff8800936d4a90 ffff8800352efd38 ffffffff8469a93e ffff8800352efd98 ffffffffc09b9b90 ffff8800352efd78 ffff8800ac4692c0 ffff8800b9c586c0 ffff8800831b6ab8 Call Trace: [<ffffffff8469a93e>] ? mutex_unlock+0xe/0x10 [<ffffffffc09b9b90>] ? inet_diag_handler_get_info+0x110/0x1fb [inet_diag] [<ffffffff845c868d>] netlink_broadcast+0x1d/0x20 [<ffffffff8469a93e>] ? mutex_unlock+0xe/0x10 [<ffffffff845b2bf5>] sock_diag_broadcast_destroy_work+0xd5/0x160 [<ffffffff8408ea97>] process_one_work+0x147/0x420 [<ffffffff8408f0f9>] worker_thread+0x69/0x470 [<ffffffff8409fda3>] ? preempt_count_sub+0xa3/0xf0 [<ffffffff8408f090>] ? rescuer_thread+0x320/0x320 [<ffffffff84093cd7>] kthread+0x107/0x120 [<ffffffff84093bd0>] ? kthread_create_on_node+0x1b0/0x1b0 [<ffffffff8469d31f>] ret_from_fork+0x3f/0x70 [<ffffffff84093bd0>] ? kthread_create_on_node+0x1b0/0x1b0 Tested: Using a debug kernel while 'ss -E' is running: ip netns add test-ns ip netns delete test-ns Fixes: eb4cb00852 sock_diag: define destruction multicast groups Fixes: 26abe14379 net: Modify sk_alloc to not reference count the netns of kernel sockets. Reported-by: Dave Jones <davej@codemonkey.org.uk> Suggested-by: Eric Dumazet <eric.dumazet@gmail.com> Signed-off-by: Craig Gallek <kraig@google.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2015-06-30 10:00:26 -07:00
..
datagram.c
dev_addr_lists.c
dev_ioctl.c
dev.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2015-06-08 20:06:56 -07:00
drop_monitor.c
dst.c
ethtool.c	net/ethtool: Add current supported tunable options	2015-06-11 00:36:37 -07:00
fib_rules.c
filter.c	bpf: disallow bpf tc programs access current->pid,uid	2015-06-15 20:51:20 -07:00
flow_dissector.c	flow_dissector: Pre-initialize ip_proto in __skb_flow_dissect()	2015-06-28 16:53:54 -07:00
flow.c
gen_estimator.c
gen_stats.c
link_watch.c
Makefile
neighbour.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2015-06-24 02:58:51 -07:00
net_namespace.c	netns: make nsid_lock per net	2015-05-17 23:41:11 -04:00
net-procfs.c
net-sysfs.c	switchdev: don't use anonymous union on switchdev attr/obj structs	2015-05-13 14:20:59 -04:00
net-sysfs.h
net-traces.c
netclassid_cgroup.c
netevent.c	netevent: remove automatic variable in register_netevent_notifier()	2015-05-31 00:03:21 -07:00
netpoll.c
netprio_cgroup.c
pktgen.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next	2015-06-24 16:49:49 -07:00
ptp_classifier.c
request_sock.c
rtnetlink.c	switchdev; add VLAN support for port's bridge_getlink	2015-06-23 06:56:18 -07:00
scm.c
secure_seq.c	net: remove a sparse error in secure_dccpv6_sequence_number()	2015-05-25 22:55:37 -04:00
skbuff.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2015-06-13 23:56:52 -07:00
sock_diag.c	sock_diag: define destruction multicast groups	2015-06-15 19:49:22 -07:00
sock.c	sock_diag: don't broadcast kernel sockets	2015-06-30 10:00:26 -07:00
stream.c	tcp: set SOCK_NOSPACE under memory pressure	2015-05-09 17:38:36 -04:00
sysctl_net_core.c
timestamping.c
tso.c
utils.c	net: fix inet_proto_csum_replace4() sparse errors	2015-05-25 22:56:47 -04:00