exts/study: fix in DMs

fixes #442

CHANGELOG.md

@@ -9,6 +9,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 - Migrated to Pycord.
 ### Removed
 - Long-deprecated aliases for `?solarweather`.
+### Fixed
+- Issue where ?hamstudy would not work in direct messages (#442).
 
 
 ## [2.8.0] - 2022-06-24

exts/study.py

@@ -159,13 +159,13 @@ class StudyCog(commands.Cog):
             await cmn.add_react(q_msg, list(self.choices.values())[i])
         await cmn.add_react(q_msg, cmn.emojis.question)
 
-        def check(reaction, user):
+        def check(ev):
-            return (user.id != self.bot.user.id
+            return (ev.user_id != self.bot.user.id
-                    and reaction.message.id == q_msg.id
+                    and ev.message_id == q_msg.id
-                    and (str(reaction.emoji) in self.choices.values() or str(reaction.emoji) == cmn.emojis.question))
+                    and (str(ev.emoji) in self.choices.values() or str(ev.emoji) == cmn.emojis.question))
 
         try:
-            reaction, user = await self.bot.wait_for("reaction_add", timeout=300.0, check=check)
+            ev = await self.bot.wait_for("raw_reaction_add", timeout=300.0, check=check)
         except asyncio.TimeoutError:
             embed.set_field_at(1, name="Answers", value=answers_str_bolded, inline=False)
             embed.set_field_at(2, name="Answer",
@@ -174,16 +174,18 @@ class StudyCog(commands.Cog):
             embed.colour = cmn.colours.timeout
             await q_msg.edit(embed=embed)
         else:
-            if str(reaction.emoji) == cmn.emojis.question:
+            if str(ev.emoji) == cmn.emojis.question:
                 embed.set_field_at(1, name="Answers", value=answers_str_bolded, inline=False)
                 embed.set_field_at(2, name="Answer",
                                    value=f"The correct answer was {self.choices[question['answer']]}", inline=False)
-                embed.add_field(name="Answer Requested By", value=str(user), inline=False)
+                # only available in guilds, but it only makes sense there
+                if ev.member:
+                    embed.add_field(name="Answer Requested By", value=str(ev.member), inline=False)
                 embed.colour = cmn.colours.timeout
                 await q_msg.edit(embed=embed)
             else:
                 answers_str_checked = ""
-                chosen_ans = self.choices_inv[str(reaction.emoji)]
+                chosen_ans = self.choices_inv[str(ev.emoji)]
                 for letter, ans in answers.items():
                     answers_str_checked += f"{self.choices[letter]}"
                     if letter == question["answer"] == chosen_ans:
@@ -195,19 +197,23 @@ class StudyCog(commands.Cog):
                     else:
                         answers_str_checked += f" {ans}\n"
 
-                if self.choices[question["answer"]] == str(reaction.emoji):
+                if self.choices[question["answer"]] == str(ev.emoji):
                     embed.set_field_at(1, name="Answers", value=answers_str_checked, inline=False)
                     embed.set_field_at(2, name="Answer", value=(f"{cmn.emojis.check_mark} "
-                                                                f"**Correct!** The answer was {reaction.emoji}"))
+                                                                f"**Correct!** The answer was {ev.emoji}"))
-                    embed.add_field(name="Answered By", value=str(user), inline=False)
+                    # only available in guilds, but it only makes sense there
+                    if ev.member:
+                        embed.add_field(name="Answered By", value=str(ev.member), inline=False)
                     embed.colour = cmn.colours.good
                     await q_msg.edit(embed=embed)
                 else:
                     embed.set_field_at(1, name="Answers", value=answers_str_checked, inline=False)
                     embed.set_field_at(2, name="Answer",
                                        value=(f"{cmn.emojis.x} **Incorrect!** The correct answer was "
-                                              f"{self.choices[question['answer']]}, not {reaction.emoji}"))
+                                              f"{self.choices[question['answer']]}, not {ev.emoji}"))
-                    embed.add_field(name="Answered By", value=str(user), inline=False)
+                    # only available in guilds, but it only makes sense there
+                    if ev.member:
+                        embed.add_field(name="Answered By", value=str(ev.member), inline=False)
                     embed.colour = cmn.colours.bad
                     await q_msg.edit(embed=embed)
 

main.py

@@ -49,8 +49,7 @@ connector = loop.run_until_complete(conn.new_connector())
 # Defining the intents
 intents = discord.Intents.none()
 intents.guilds = True
-intents.guild_messages = True
+intents.messages = True
-intents.dm_messages = True
 intents.reactions = True
 intents.message_content = True