Commit Graph

1095 Commits

Author SHA1 Message Date
Steffen Jaeckel 1a3880fda5 Revert "re-factor size checks in blake2 implementations"
This reverts commit af38b1830e.
2017-06-27 12:33:40 +02:00
Steffen Jaeckel af38b1830e re-factor size checks in blake2 implementations 2017-06-26 14:02:52 +02:00
Steffen Jaeckel 907d5301ee update coverity build script to use makefile.unix
it seems like the regular makefile is somehow broken...
2017-06-23 16:46:31 +02:00
Steffen Jaeckel 3cfb2a5e2e hide some of the 'new since 1.17' internal functions 2017-06-23 14:14:05 +02:00
Steffen Jaeckel a80d3c00a8 no need for DH_BUF_SIZE 2017-06-23 14:05:57 +02:00
Steffen Jaeckel c15d656a23 crypt{,.exe} is now ltcrypt{,.exe} 2017-06-23 14:05:57 +02:00
Steffen Jaeckel e68d846429 hopefully finally fix usage of $(DESTDIR)
This closes #232
2017-06-23 14:05:57 +02:00
Steffen Jaeckel cd6e602b48 Merge pull request #240 from fperrad/20170622_lint
more linting
2017-06-23 10:06:13 +02:00
Francois Perrad 446fec1bc4 refactor switch with default 2017-06-22 17:13:40 +02:00
Steffen Jaeckel 1725b87098 Merge pull request #234 from libtom/cleanup/3
Third general clean-up
2017-06-22 16:01:14 +02:00
Steffen Jaeckel 5ce602558f Revert "also use DESTDIR in makefile.m{ingw,svc}"
This reverts commit 1655e63c49.

As of @karel-m [1]

"I am not sure whether DESTDIR concept make sense for MS Windows
paths. For example: `make -f makefile.mingw DESTDIR=c:\builddir\
PREFIX=c:\installdir` means that `"$(DESTDIR)$(PREFIX)\bin"` will
expand to `"c:\builddir\c:\installdir\bin"` which is obviously
invalid.
I propose reverting `also use DESTDIR in makefile.m{ingw,svc}`."

[1] https://github.com/libtom/libtomcrypt/pull/234#issuecomment-310366602
2017-06-22 14:41:37 +02:00
Steffen Jaeckel 09c4d4c93b proper use of $(DESTDIR)
@rofl0r @ [1]

"...still it's unusual/unexpected to embed DESTDIR in LIBPATH
etc. where this could hickup is when for example hardcoded paths need
to be embedded into the resulting binary. for example, in the
netbsd-curses makefile i linked earlier, such a case would be reference
to the terminfo DB location, which is derived from PREFIX.
other possible cases might be stuff that dlopen()s its own libs using an
absolute path, or uses other data files. for such a case a contributor
would typically re-use DATAPATH oslt and put it into CPPFLAGS or write
it into a header, to find the required files. when now these paths have
DESTDIR in them too, this will not work. thus it is good practice to use
$(DESTDIR) only in install targets, and keep it out of other vars."


[1] https://github.com/libtom/libtomcrypt/commit/8e29a6061f3ad7bc7c5c2aeae73705e890ce1ea9#commitcomment-22678488

This closes #232
2017-06-22 14:21:14 +02:00
Steffen Jaeckel e3937a2906 fix compile warning when building w/o tests 2017-06-22 14:21:14 +02:00
Steffen Jaeckel 11338d2496 introduce XMEMMOVE and check for its usage 2017-06-22 14:21:14 +02:00
Steffen Jaeckel e9c90e7f63 no need to use XMEM_NEQ() in PK crypto 2017-06-22 14:21:14 +02:00
Steffen Jaeckel ae698927ff improve mem_neq() documentation 2017-06-22 14:21:14 +02:00
Steffen Jaeckel 1655e63c49 also use DESTDIR in makefile.m{ingw,svc} 2017-06-22 14:21:14 +02:00
Steffen Jaeckel af984dc33e exclude more sources from "static function check" 2017-06-22 14:21:14 +02:00
Steffen Jaeckel 1bf42ea99a update some of the static functions 2017-06-22 14:21:14 +02:00
Karel Miko 8f433f1a36 add check for static function names 2017-06-22 14:21:14 +02:00
Steffen Jaeckel 27b3ffc627 use compare_testvector() instead of XMEMCMP() in tests 2017-06-22 14:21:14 +02:00
Steffen Jaeckel 05e28d6cfa fix potential timing attacks in rsa, eax, ocb and ocb3 2017-06-22 14:21:14 +02:00
Steffen Jaeckel b03b93099d allow to give only a part as parameter to ./test 2017-06-22 14:21:14 +02:00
Steffen Jaeckel 36132b016f update title page of pdf doc 2017-06-22 14:21:14 +02:00
karel-m 316450c20e Merge pull request #237 from libtom/pr/dh-facelift-part1
DH facelift part 1
2017-06-22 14:16:36 +02:00
Karel Miko 243a1dc33e drop _dh_make_key_ex 2017-06-22 13:19:48 +02:00
Karel Miko cba1569c82 fix tomcrypt_pk.h 2017-06-22 13:19:48 +02:00
Karel Miko a0257df999 update makefiles 2017-06-22 13:19:47 +02:00
Karel Miko 5eaff56d90 remove dh_export_radix.c dh_import_radix.c 2017-06-22 13:19:47 +02:00
Karel Miko f4ce5a21c8 helper.pl - enable check_comments for --check-all 2017-06-22 13:19:47 +02:00
Karel Miko f9802359c9 update makefiles 2017-06-22 13:19:47 +02:00
Karel Miko 771d67e102 DH facelift part1 2017-06-22 13:19:47 +02:00
Steffen Jaeckel 5e71ac27e2 Merge pull request #230 from libtom/math/miller-rabin
Fix number of Miller-Rabin rounds
2017-06-22 12:44:33 +02:00
Steffen Jaeckel 26b57032e7 use correct amount of M-R tests in dsa_make_params() 2017-06-22 11:55:08 +02:00
Steffen Jaeckel 7453eddae9 improve ltc_math_descriptor a bit
* introduce LTC_MILLER_RABIN_REPS which is used as default value
  in the isprime() implementations
2017-06-22 11:55:08 +02:00
karel-m 6f85293672 Merge pull request #235 from libtom/pr/ecc_sign+verify_hash_rfc7518
ECC ecc_sign+verify_hash_raw > ecc_sign+verify_hash_rfc7518
2017-06-21 14:33:37 +02:00
Karel Miko ac02f7422b ecc_sign+verify_hash_rfc7518 tests 2017-06-21 13:43:25 +02:00
Karel Miko b8f22157b3 PK_MAX_RETRIES 2017-06-21 13:38:39 +02:00
Karel Miko 0c115a162d whitespace 2017-06-21 13:26:52 +02:00
Karel Miko fff832091f ecc_sign_hash max_iterations 2017-06-21 13:25:06 +02:00
Karel Miko cdf04b6140 fix mp_montgomery_setup 2017-06-21 13:01:22 +02:00
Karel Miko a937f23821 static functions name fix 2017-06-21 12:49:19 +02:00
Karel Miko 67200b641d ecc_sign+verify_hash_raw > ecc_sign+verify_hash_rfc7518 2017-06-21 12:11:35 +02:00
Steffen Jaeckel c14bcf4d30 Merge pull request #233 from libtom/cleanup/2
Second general clean-up
2017-06-20 17:51:16 +02:00
Steffen Jaeckel 18c00ddcd6 better usage of find() 2017-06-20 15:16:11 +02:00
Steffen Jaeckel 5246c7de64 fix links in pdf doc 2017-06-20 15:16:11 +02:00
Steffen Jaeckel 8e29a6061f use {BIN,DATA,INC,LIB}PATH in makefile.unix 2017-06-20 15:16:11 +02:00
Steffen Jaeckel 6fc0a90a1e fix headers & footers in demos & tests 2017-06-20 15:16:11 +02:00
Steffen Jaeckel 4cd1355b8f more clean-up of headers/footers 2017-06-20 15:16:11 +02:00
Steffen Jaeckel fe19dad623 replace SVN tags 2017-06-20 15:16:11 +02:00