Commit Graph

1123 Commits

Author SHA1 Message Date
Steffen Jaeckel
35e0c5fc71 clean-up a bit around DSA
* comments
* dsa_test()
* order of alloc/free of key parts
2017-06-28 16:07:32 +02:00
Steffen Jaeckel
1cce065676 Update makefiles 2017-06-28 14:44:17 +02:00
Steffen Jaeckel
0aad68c20d clean-up some PK tests
no need to test the same functionality multiple times
these tests were multiplied for the XX_import_radix() functions which
are gone now.
2017-06-28 14:44:06 +02:00
Steffen Jaeckel
cfff656e25 re-factor dsa_make_key() etc. 2017-06-28 14:40:30 +02:00
Steffen Jaeckel
24946d08b7 use mp_cleanup_multi() 2017-06-28 14:40:30 +02:00
Steffen Jaeckel
ed149c9396 add tests for radix_to_bin() 2017-06-28 14:40:30 +02:00
Steffen Jaeckel
76b9bba857 introduce mp_cleanup_multi() 2017-06-28 14:40:30 +02:00
Steffen Jaeckel
292f42d3c0 Merge pull request #227 from libtom/pr/dh_make_key_ex
DH facelift part 2 (dh_make_key_ex & co.)
2017-06-27 22:25:00 +02:00
Steffen Jaeckel
37ce78fdc8 Update makefiles 2017-06-27 22:10:10 +02:00
Steffen Jaeckel
f2f113880b also rename file 2017-06-27 22:10:07 +02:00
Steffen Jaeckel
c493a2a0a3 re-factor dh_export_radix() to dh_export_key() 2017-06-27 22:09:21 +02:00
Steffen Jaeckel
f226efc9a9 Update makefiles 2017-06-27 22:00:13 +02:00
Steffen Jaeckel
9d6689fc08 re-factor dh_make_key() and variants 2017-06-27 22:00:13 +02:00
Steffen Jaeckel
fbc54756c1 replace dh_import_radix() by dh_set_{pg,key} 2017-06-27 21:53:02 +02:00
Karel Miko
b3e535f933 update makefiles 2017-06-27 20:11:52 +02:00
Karel Miko
f60e2902ed dh_make_key_ex dh_export_radix dh_import_radix 2017-06-27 20:11:52 +02:00
Steffen Jaeckel
a42f467ff1 Update makefiles 2017-06-27 20:05:36 +02:00
Steffen Jaeckel
ae7d4d2947 re-factor rsa_test() to new rsa_set_X() API 2017-06-27 20:05:36 +02:00
Steffen Jaeckel
627f6696cb add radix_to_bin() 2017-06-27 20:05:36 +02:00
Steffen Jaeckel
6b798ca6a6 replace rsa_import_radix() by rsa_set_{key,factors,crt_params}() 2017-06-27 20:05:36 +02:00
Steffen Jaeckel
05e9f0ee79 Revert "use ltc_pk_part in rsa_import_radix()"
This reverts commit 023e4a2c23641d852cf47000948fa29a53249457.
2017-06-27 20:05:36 +02:00
Steffen Jaeckel
083e8af78b Revert "also test binary import"
This reverts commit 8b6f8c8cce325fa1ce3b61805aa80cdabc1826b4.
2017-06-27 20:05:36 +02:00
Steffen Jaeckel
4afc024f6a also test binary import 2017-06-27 20:05:36 +02:00
Steffen Jaeckel
bfae92e4ab use compare_testvector() in rsa_test() 2017-06-27 20:05:36 +02:00
Steffen Jaeckel
00a5212d99 use ltc_pk_part in rsa_import_radix() 2017-06-27 20:05:36 +02:00
Steffen Jaeckel
51ac4da8fc Merge pull request #241 from libtom/cleanup/4
Fourth general clean-up
2017-06-27 20:04:59 +02:00
Steffen Jaeckel
0a6af8d333 rsa_exptmod(): verify that p and q are valid before going the CRT path 2017-06-27 19:01:56 +02:00
Steffen Jaeckel
f5b8cc9dae this should really implement a patch for the illegal access 2017-06-27 12:35:39 +02:00
Steffen Jaeckel
1a3880fda5 Revert "re-factor size checks in blake2 implementations"
This reverts commit af38b1830e.
2017-06-27 12:33:40 +02:00
Steffen Jaeckel
af38b1830e re-factor size checks in blake2 implementations 2017-06-26 14:02:52 +02:00
Steffen Jaeckel
907d5301ee update coverity build script to use makefile.unix
it seems like the regular makefile is somehow broken...
2017-06-23 16:46:31 +02:00
Steffen Jaeckel
3cfb2a5e2e hide some of the 'new since 1.17' internal functions 2017-06-23 14:14:05 +02:00
Steffen Jaeckel
a80d3c00a8 no need for DH_BUF_SIZE 2017-06-23 14:05:57 +02:00
Steffen Jaeckel
c15d656a23 crypt{,.exe} is now ltcrypt{,.exe} 2017-06-23 14:05:57 +02:00
Steffen Jaeckel
e68d846429 hopefully finally fix usage of $(DESTDIR)
This closes #232
2017-06-23 14:05:57 +02:00
Steffen Jaeckel
cd6e602b48 Merge pull request #240 from fperrad/20170622_lint
more linting
2017-06-23 10:06:13 +02:00
Francois Perrad
446fec1bc4 refactor switch with default 2017-06-22 17:13:40 +02:00
Steffen Jaeckel
1725b87098 Merge pull request #234 from libtom/cleanup/3
Third general clean-up
2017-06-22 16:01:14 +02:00
Steffen Jaeckel
5ce602558f Revert "also use DESTDIR in makefile.m{ingw,svc}"
This reverts commit 1655e63c49.

As of @karel-m [1]

"I am not sure whether DESTDIR concept make sense for MS Windows
paths. For example: `make -f makefile.mingw DESTDIR=c:\builddir\
PREFIX=c:\installdir` means that `"$(DESTDIR)$(PREFIX)\bin"` will
expand to `"c:\builddir\c:\installdir\bin"` which is obviously
invalid.
I propose reverting `also use DESTDIR in makefile.m{ingw,svc}`."

[1] https://github.com/libtom/libtomcrypt/pull/234#issuecomment-310366602
2017-06-22 14:41:37 +02:00
Steffen Jaeckel
09c4d4c93b proper use of $(DESTDIR)
@rofl0r @ [1]

"...still it's unusual/unexpected to embed DESTDIR in LIBPATH
etc. where this could hickup is when for example hardcoded paths need
to be embedded into the resulting binary. for example, in the
netbsd-curses makefile i linked earlier, such a case would be reference
to the terminfo DB location, which is derived from PREFIX.
other possible cases might be stuff that dlopen()s its own libs using an
absolute path, or uses other data files. for such a case a contributor
would typically re-use DATAPATH oslt and put it into CPPFLAGS or write
it into a header, to find the required files. when now these paths have
DESTDIR in them too, this will not work. thus it is good practice to use
$(DESTDIR) only in install targets, and keep it out of other vars."


[1] 8e29a6061f (commitcomment-22678488)

This closes #232
2017-06-22 14:21:14 +02:00
Steffen Jaeckel
e3937a2906 fix compile warning when building w/o tests 2017-06-22 14:21:14 +02:00
Steffen Jaeckel
11338d2496 introduce XMEMMOVE and check for its usage 2017-06-22 14:21:14 +02:00
Steffen Jaeckel
e9c90e7f63 no need to use XMEM_NEQ() in PK crypto 2017-06-22 14:21:14 +02:00
Steffen Jaeckel
ae698927ff improve mem_neq() documentation 2017-06-22 14:21:14 +02:00
Steffen Jaeckel
1655e63c49 also use DESTDIR in makefile.m{ingw,svc} 2017-06-22 14:21:14 +02:00
Steffen Jaeckel
af984dc33e exclude more sources from "static function check" 2017-06-22 14:21:14 +02:00
Steffen Jaeckel
1bf42ea99a update some of the static functions 2017-06-22 14:21:14 +02:00
Karel Miko
8f433f1a36 add check for static function names 2017-06-22 14:21:14 +02:00
Steffen Jaeckel
27b3ffc627 use compare_testvector() instead of XMEMCMP() in tests 2017-06-22 14:21:14 +02:00
Steffen Jaeckel
05e28d6cfa fix potential timing attacks in rsa, eax, ocb and ocb3 2017-06-22 14:21:14 +02:00