Change I64d0b71853004679ae694bcd6ca7a2f2347adc84 ("qcacld-3.0:
Remove legacy P2P codes in MAC") removed the implementation of
lim_p2p_action_cnf(). However it left the prototype, so remove
it as well.
Change-Id: I9586624c2353ab675ba540771335e5b68ce527bf
CRs-Fixed: 2376113
The lim_strip_extcap_ie() prototype has no corresponding
implementation. Since it is obsolete, remove it.
Change-Id: Ic19df6825039ce63747deb61bac5821407436836
CRs-Fixed: 2376112
The limUpdateStaRunTimeHTSwtichChnlParams() prototype has no
corresponding implementation. Since it is obsolete, remove it.
Change-Id: I968d0a601570f62317a7d1d551e63db456ac450c
CRs-Fixed: 2376111
The parameter identifiers used in the implementation of
lim_process_add_sta_rsp() differ from the ones used in the prototype.
Since this can be confusing for both humans and code analysis tools,
harmonize on the parameters used in the implementation. In addition,
relocate the documentation so that it is the interface that is
documented and not the implementation.
Change-Id: I221b4fd0a643770b46adf06776b16fa85a6de03c
CRs-Fixed: 2376110
The parameter identifiers used in the implementation of
sys_build_message_header() differ from the ones used in the
prototype. Since this can be confusing for both humans and code
analysis tools, harmonize on a good set of identifiers. In addition,
consolidate the two distince documentation blocks so that it is the
interface that is fully and correctly documented, and not the
implementation.
Change-Id: Iaeee04ec918fad20a43c5804f9e50b7b208dfb94
CRs-Fixed: 2376109
Function populate_dot11f_supp_rates() contains #if 0 code that is
obsolete, so remove it.
Change-Id: Ib0c87186aac5bfc48ecf7dd50f5547d85920c62b
CRs-Fixed: 2376107
Change "I9d05cd7b8e051c4e9e4912cf866206ae32ec293d" ("qcacld-3.0:
Define data structures for new AP requirements") added the
vendor_ie_access_policy field to struct sap_config, but subsequently
no code was added which actually utilizes this field. Since it is
unused, remove it, along with the underlying enumeration.
Change-Id: I7a3661a50ef17b0452e87e0ed86c3826b3bd199d
CRs-Fixed: 2375528
Change I9d83f66bce4ec66bc131747254a45d8b6afb5cbb ("qcacld-3.0:
Remove eSAP_GET_WPSPBC_SESSION_EVENT") removed the references
to the sapGetWPSPBCSessionEvent field in typedef tSap_Event.
Since this field is obsolete, remove it, along with the underlying
tSap_GetWPSPBCSessionEvent typedef which is also now obsolete.
Change-Id: I20dbc1635430f8148f997aeb15df4ddb7e06ceef
CRs-Fixed: 2375527
Change I5a07c44ca4138af5494d1a6f6e1d08158d244be2 ("qcacld-3.0: Remove
SapAllChnlList from struct sap_context") removed the last reference to
typedef tChannelInfo. Since this typedef is now obsolete, remove it.
Change-Id: Ib38c9744c9419ce91b94956b5da78cc7bcc440c5
CRs-Fixed: 2375526
Change I2c3b96e1f2ee44c9f1158108d4b5e48495222080 ("qcacld-3.0: Make
SAP open()-close() & start()-stop() symmetrical") removed the last
reference to typedef tSapChannelListInfo. Since the typedef is
obsolete, remove it.
Change-Id: I4fc7cf83f41ad0192b971513f0456cf211fabb54
CRs-Fixed: 2375525
The parameter identifiers used in the implementation of
sap_get_channel_list() differ from the ones used in the forward
reference. Since this can be confusing for both humans and code
analysis tools, harmonize on the parameters used in the
implementation.
Change-Id: I356740677e790e48b0c28d5ca694be3ae3835d59
CRs-Fixed: 2375524
Change I3c4f8da14dbc70a3102fb1892bb101eb1a90a00d ("qcacld-3.0: Fix
firmware assertion caused by vdev delete") removed all usage of field
isScanSessionOpen in struct sap_context. Since it is obsolete, remove
it.
Change-Id: I30eb9d3b4ca39a5f14dafe9559d025cb361372b5
CRs-Fixed: 2375522
The implementation of sap_channel_matrix_check() is no longer part of
the driver, but the prototype is still present. Since the prototype is
obsolete, remove it.
Change-Id: I689c4360776a2b46d723c48dd5bb8a61da5c95cd
CRs-Fixed: 2375521
Change I76e78824cdc7acad87e60310d53225596630ea94 ("qcacld-3.0: Remove
SAP FSM dependency from CSA") removed all logic which used the
stop_bss_in_progress field in struct sap_context. Since this field is
now obsolete, remove it.
Change-Id: I9867bcf7d8021e7173c679d3e20e16ca8bdbc5cc
CRs-Fixed: 2375520
Change I097c67da517e86b4d44901a01b0fe65e1a53b0a9 ("qcacld-3.0:
Cleanup SME APIs") removed all references to typedef
tCsrUpdateConfigParam. Since the typedef is obsolete, remove it.
Change-Id: Idd33f42930c181d1c79c2cdf72adde0a4af2e9fa
CRs-Fixed: 2375517
Change I63442b1c2f0033c50ab94d4dcf4288eae5fb4d9d ("qcacld-3.0:
Remove typedef tCsrStaParams") removed the last reference to
typedef tSirHTCap. Since the typedef is obsolete, remove it.
Change-Id: I0b10d832c81fb43ee052df5cab1eccd30e657454
CRs-Fixed: 2375516
Change I8ba344ce5593df44bd15527e2ff68e872b6d23b8 ("qcacld-3.0: TDLS:
remove legacy core functions") removed the last references to typedef
tCsrStaParams. Since the typedef is obsolete, remove it.
Change-Id: I63442b1c2f0033c50ab94d4dcf4288eae5fb4d9d
CRs-Fixed: 2375515
The roamOffloadSynchParams field in struct csr_roam_session
is unused, so remove it, along with the underlying struct
csr_roam_offload_synch_params.
Change-Id: I7a1c7bad6090404fde9a97ce0ca3a3b36cb8299a
CRs-Fixed: 2375514
The uRTSThresh and uDeferThresh fields in struct bss_config_param are
obsolete, so remove them.
Change-Id: I79144e36d661fac7136fbb7b941b7772addf7f25
CRs-Fixed: 2375513
The parameter identifiers used in the implementation of
csr_validate_mcc_beacon_interval() differ from the ones used in the
prototype. Since this can be confusing for both humans and code
analysis tools, harmonize on the parameters used in the
implementation. In addition, relocate the documentation so that it is
the interface that is documented and not the implementation.
Change-Id: I817c836fe07a8add1e3588d9b5eeded027ee6f26
CRs-Fixed: 2375512
Change I71de90d5fb88462e52148a434d43ea80c41cfe36 ("qcacld-3.0: Move
Channel convert and frame indication logic to lim_utils.c") removed
the implementation of p2p_process_remain_on_channel_cmd() but left
behind the prototype. Since the prototype is obsolete, remove it.
Change-Id: I34caafa9cc2731f3a21e0200e520118a10740d3b
CRs-Fixed: 2375511
Change Ibea328196a9453ebaae887aa4068e78c47296762 ("qcacld-3.0:
Scan cleanup in lim and csr") removed the implementation of
csr_process_scan_command() but left the prototype. Since the
prototype is obsolete, remove it.
Change-Id: I937ef951045be638fccce8902fbaed510350f029
CRs-Fixed: 2375510
Change Ibea328196a9453ebaae887aa4068e78c47296762 ("qcacld-3.0:
Scan cleanup in lim and csr") removed the last references to
struct tag_scanreq_param. Since it is now obsolete, remove it.
Change-Id: I3c4d929696a8e70b14c3a0a7f706b5665a90532e
CRs-Fixed: 2375435
Fix implicit tdls connection issue. Correct usage of qdf_mem_set.
DUT could receive multicast frames after tdls connection tear down,
add check condition of frames with multicast dest address in
tdls_update_rx_pkt_cnt.
Change-Id: Ia1d7bbf2c129e9aebc98f7fcdea263b745c221ec
CRs-Fixed: 2375043
Remove wepType field from struct tSetStaKeyParams, as
it is an obsolete WEP configuration.
Change-Id: I895541bef0cc08a75ba7c54e792ad15002ff0b0c
CRs-Fixed: 2373003
If FW offload cfg object is not initialized before invoking
the ucfg APIs use the cfg defaults for the values.
Change-Id: Ibbfe22a833ab217f670058e504ec80971c98e049
CRs-fixed: 2376983
currently freq is sent as 0 in send auth mgmt frame
request to firmware(WMI_MGMT_TX_SEND_CMDID). In SAP 2G
+ STA doing LFR2 DBS roam from 5G to 2G scenario, the
preauth request get sent in 5g band rather than 2G.
So LFR2 preauth send request should have the exact
frequency parameter. only then FW can send the auth req
in appropriate frequency.
Change-Id: I17f47ee559768fee1fd5055d953791117e7b04c5
RSSI absolute threshold value sent to firmware in the
default case is 0 even when hw db2dbm capability is
enabled which can break firmware roaming.
Fix is to send min rssi value of -128dbm when hw db2dbm
service capability is enabled.
Change-Id: I0a595e9f4af170411a0813a3390ddbb57d26bce1
CRs-Fixed: 2376606
If target doesn't support AES_GMAC BIP cipher,
skip the key install wmi command.
Host will do the BIP MMIE validation.
Change-Id: I7536a0bb8a2dab653eae8f729e57bdcb5fef5e19
CRs-Fixed: 2370637
The following macros are unused, so remove them:
- WMA_DEFAULT_QPOWER_MAX_PSPOLL_BEFORE_WAKE
- WMA_DEFAULT_QPOWER_TX_WAKE_THRESHOLD
Change-Id: I9b0f760ebbadbdecf9549a813a9b72e07a97a9e8
CRs-Fixed: 2375433
Change I654e53fa2441e03723f150d973c124985c67f2b4 ("qcacld-3.0: Add new
params in ACS calc process") introduced macros WMA_CHAN_START_RESP and
WMA_CHAN_END_RESP, but did not add any code which uses them. Since
they are unused, remove them.
Change-Id: I7a5f20cb8e72c19f52d5a44afb3b480eaa84c06b
CRs-Fixed: 2375431
When gEnableDFSChnlScan is configured as 0, it is incorrect that DFS
channels are not skipped when scanning.
Android O/P framework always enables DFS flag for station interface, then
gEnableDFSChnlScan is always overwritten currently.
Only support DFS flag configuration when gEnableDFSChnlScan is set as 1.
Change-Id: I4c819c4cc8c44d95ebe1ce074e67f3f1d9b254e0
CRs-Fixed: 2368131
Change I840c6a5f83c6cdc479e6746f36a29c2a7970c964 ("qcacld-3.0: Remove
wma_get_buf_extscan_start_cmd()") removed the only usage of macro
WMA_SCAN_NPROBES_DEFAULT. Since it is now obsolete, remove it.
Change-Id: If4907fcc397ba77bd58d8423b1695896a7197597
CRs-Fixed: 2375430
It alloc memory with structures in sir_api.h, and process/parse them
with structures in tdls component, which will cause memory corruption
potentially. So, this change refacor these functions and let them use
unified structures. Remove unused structures in sir_api.h
Here are these functions:
- lim_send_sme_tdls_add_sta_rsp
- lim_send_tdls_comp_mgmt_rsp
- lim_send_sme_tdls_del_sta_rsp
- lim_send_sme_mgmt_tx_completion
Remove below unused tdls structures:
- tSirTdlsDelAllPeerInd
- tSirTdlsDelStaInd
- tSirTdlsEventnotify
- tSirTdlsLinkEstablishReq
- tSirTdlsLinkEstablishReqRsp
- tSirTdlsAddStaRsp
- tSirTdlsDelStaRsp
- tSirMgmtTxCompletionInd
Change-Id: Ic595cadefcdbeb2df44f97563c4652db409213a2
CRs-Fixed: 2373706
Change I33b56bb627ac914ca6fe96949de373b015853fc9 ("qcacld-3.0:
Decrease tx drain wait time during del bss") removed the only
usage of macro WMA_TX_Q_RECHECK_TIMER_MAX_WAIT. Since it is
obsolete, remove it.
Change-Id: Iec4ad45efcd7bc407f639226f7aa21ed39d753e9
CRs-Fixed: 2375429
The legacy typedef tBeaconFilterIe is unused, so remove it, along with
the underlying tEidByteInfo typedef.
Change-Id: Id02c67ff49892d63cd2443a2639f4bc7d4253a7f
CRs-Fixed: 2375428
The typedefs for struct sAniProbeRspStruct are unused. Since the Linux
coding style discourages the use of typedefs, remove these so that
they won't possibly be used in the future.
Change-Id: I71965804bd32e3413314e81447ee004e6e663e49
CRs-Fixed: 2375427
The following legacy scan typedefs are obsolete, so remove them:
- tStartScanParams
- tEndScanParams
- tAbortScanParams
Change-Id: Ie106be72b2ff1d1969018d0db14da9408df97747
CRs-Fixed: 2375426
Code componentization relocated large portions of protocol code from
HDD to protocol-specific components. Left behind were quite a few
macros that are now no longer used, so remove the following:
- WLAN_HDD_P2P_SINGLE_CHANNEL_SCAN
- WLAN_HDD_P2P_SOCIAL_CHANNELS
- WLAN_HDD_PUBLIC_ACTION_FRAME
- WLAN_HDD_PUBLIC_ACTION_FRAME_ACTION_OFFSET
- WLAN_HDD_PUBLIC_ACTION_FRAME_BODY_OFFSET
- WLAN_HDD_PUBLIC_ACTION_FRAME_CATEGORY_OFFSET
- WLAN_HDD_PUBLIC_ACTION_FRAME_OUI_OFFSET
- WLAN_HDD_PUBLIC_ACTION_FRAME_OUI_TYPE_OFFSET
- WLAN_HDD_PUBLIC_ACTION_FRAME_SUB_TYPE_OFFSET
- WLAN_HDD_PUBLIC_ACTION_FRAME_TYPE_OFFSET
- WLAN_HDD_SA_QUERY_ACTION_FRAME
- WLAN_HDD_TDLS_ACTION_FRAME
- WLAN_HDD_VENDOR_SPECIFIC_ACTION
- WLAN_HDD_WFA_OUI
- WLAN_HDD_WFA_P2P_OUI_TYPE
Change-Id: I74611f7db2c2d3a6fa50c2719986cba2c33b41b3
CRs-Fixed: 2375425
Macro HTT_TX_DESC_PADDR() is unused. Furthermore, it references
tx_descs fields which do not exist. Since it couldn't possibly be
used in its current form, remove the macro.
Change-Id: I62b2d7bc3291ba6c2dc486196076827cfc22d8ec
CRs-Fixed: 2375421
Change I8ba344ce5593df44bd15527e2ff68e872b6d23b8 ("qcacld-3.0: TDLS:
remove legacy core functions") removed all uses of macro
TDLS_STA_INDEX_VALID. Since it is now unused, remove it.
Change-Id: Iefec2b4565f4a387778ccd5a4ed7e0d9eb9b732e
CRs-Fixed: 2375416
Change Ic72243b918f4a8385a92b803a1ca3c5305423b52 ("qcacld-3.0: Add
support for Android Packet Filter v3") introduced macro
WLAN_WAIT_TIME_APF_GET_CAPS, but didn't actually introduce any code
that uses it. Since it is unused, remove it.
Change-Id: Iad513163ee32ea542b5f1ba22ec349385cfe9457
CRs-Fixed: 2374850
The QCSAP_IOCTL_CLR_STATS ioctl is no longer supported, so remove the
associated macro.
Change-Id: Icc7462005c3ce97833c7309a70f51cf54722660f
CRs-Fixed: 2374849
Change Id235d6303ce7c740f907147afc7248d833772067 ("qcacld-3.0:
Cleanup eWNI_SME_SET_BCN_FILTER_REQ") removed the usage of typedef
tBeaconFilterMsg, but didn't actually remove the obsolete typedef,
so remove it now.
Change-Id: Id7a24e18a6aa4fb7cfa6747f264bd3e6eeaa1ad8
CRs-Fixed: 2374845
The enable_mhf_offload and last_mhf_entries_timestamp fields of
t_wma_handle are unused, so remove them.
Change-Id: If07fa52f93caa0c2f2bb191603c6a96830dad469
CRs-Fixed: 2374844
Change Ie891eddad2b536e43f5f933c8683d41b096bf578 ("qcacld-3.0: Remove
obsolete code in SME QOS module") removed the only references to
typedef uapsd_start_indication_cb. Since it is obsolete, remove it.
Change-Id: I940608cf59b4f9f5f68cffb68b9ee45606461ded
CRs-Fixed: 2374843
Change Ia44acd9a3e31bf0d1098f7d423f0c28a2b7fe5fa ("qcacld-3.0: Cleanup
WMA and SME code related to DISA") removed the SME DISA code, but it
left behind the encrypt_decrypt_cb and encrypt_decrypt_context fields
in tSmeStruct. Since these are now obsolete, remove them, along with
their underlying type definitions.
Change-Id: I7bf5d737b89cc9604310b7c18c510f42f73ec971
CRs-Fixed: 2374842
Change I6cb9fe12bee3702556c9b52e7ccb7c69c762d8de ("qcacld-3.0: Remove
legacy code for policy manager restructuring") removed the client of
wlan_hdd_check_custom_con_channel_rules(). Since this is no longer
used, remove it.
Change-Id: I2e43eec1f2ee7a7916630b1099cf7de000a06a6a
CRs-Fixed: 2374841
Function csr_roamGetConcurrencyConnectStatusForBmps() no longer
exists, but the prototype is still present. Since it is obsolete,
remove it.
Change-Id: I6e1f0206957a828a1041659e7d5f3ac9e97dc843
CRs-Fixed: 2374840
Function sme_ConfigureAppsCpuWakeupState() no longer exists, but the
prototype is still present. Since it is obsolete, remove it.
Change-Id: I91c26c2e3ec67c61ff55efbf24b2716e3ff35675
CRs-Fixed: 2374839
Function csr_get_phy_mode_from_bssDesc() no longer exists, but the
prototype is still present. Since it is obsolete, remove it.
Change-Id: Ib5a37e0468d3f6f2f5ed862c99d508aadb3afda0
CRs-Fixed: 2374838
The following channel-related fields in struct csr_roamstruct are
unused, so remove them:
- baseChannels
- channelList24
- channelList5G
- numChannelsEeprom
Change-Id: Ia44e386496e36ba15bcb1c39c6190d0331603903
CRs-Fixed: 2374836
Change I7994a9038d5bd094ce23bcd525ef8f5282974bfc ("qcacld-3.0: Apply
second part of LFR INIs changes") removed the logic that utilized the
csr_hi_rssi_scan_id enumerations. Since these are now unused, remove
the definition.
Change-Id: Ia72aabdfa672c8012f952967c7f67b1bc8024514
CRs-Fixed: 2374835
Change Ia0fa016b174ef4b50e2cc339e4e476ec65642dbf ("qcacld-3.0: Use dfs
component support") removed the logic that utilized the SapAllChnlList
in struct sap_context. Since this field is now obsolete, remove it,
along with the underlying tAll5GChannelList typedef that is also now
obsolete.
Change-Id: I5a07c44ca4138af5494d1a6f6e1d08158d244be2
CRs-Fixed: 2374834
The ap_table_max_size and ap_table_expiration_time fields in struct
sap_config are unused, so remove them.
Change-Id: I24aabe78b0da45c3dde19b444f94222eb874477d
CRs-Fixed: 2374831
Change I12a1d0cf37db22ff0bcb8165cb3f6b3847f8bf5b ("qcacld-3.0: Add
interface changes for supporting NAN data path") introduced struct
ndp_peer_node, but did not actually add code which uses it. Since
this struct is unused, remove it.
Change-Id: I36b333287de19e42855a596d25ba489e9cfb3241
CRs-Fixed: 2374293
Change I5828002d2363e01f63b0a643a0c59abd52bc4f19 ("qcacld-3.0:
NAN datapath cleanup") removed all code that called
lim_handle_ndp_event_message(), but inexplicably left behind an
inline stub function. Since the stub is unused, remove it.
Change-Id: I283c5e4ad8f285fc0452d8efbdc77960e420cf0b
CRs-Fixed: 2374292
LIM exposes a prototype for limGetBssidFromPkt(), but the actual
function no longer exists. Since this is an obsolete prototype,
remove it.
Change-Id: Idef628f4de18d4b4cc9a12c1cfb184eb2eadfdf1
CRs-Fixed: 2374291
LIM exposes a prototype for limWPSPBCTimeout(), but the actual
function no longer exists. Since this is an obsolete prototype,
remove it.
Change-Id: I31cbeae9dfa9fb561506bbd5ca16771ec9c566d8
CRs-Fixed: 2374290
The driver contains remnant support for Proprietary IEs that were
inherited from the original "Pre-n" version of the driver. Since
these IEs are no longer parsed or used, remove all references to them.
Change-Id: Iac7c3176682ce0054b7f06827fa6b6ec7be1e6a5
CRs-Fixed: 2374289
There are a large number of legacy byte swap APIs in utils_api.h that
are unused, so remove them.
Change-Id: I1adbb82820e4b325ed2843a87a201250978ce04c
CRs-Fixed: 2374286
Change I71de90d5fb88462e52148a434d43ea80c41cfe36 ("qcacld-3.0: Move
Channel convert and frame indication logic to lim_utils.c") removed
the last reference to typedef tSirMbMsgP2p. Since it is obsolete,
remove it.
Change-Id: I009aa479ffddeceebb3bd26af5ae48c32a43240c
CRs-Fixed: 2374285
Change Ia664f815759142e7f4ad8e648a469c63ddd003f5 ("qcacld-3.0:
Cleanup unused scan code") removed the last reference to
tSirBackgroundScanMode. Since it is now obsolete, remove it.
Change-Id: I2faab5487988b1941601f2befdb570ecab8651ed
CRs-Fixed: 2374282
Typedefs tInitScanParams and tFinishScanParams are unused, so remove
them, along with tSirScanEntry and tSirLinkTrafficCheck that is used
just by them.
Change-Id: I5f9c58236f8c5fe639c5b896a66b9dc290e54ab1
CRs-Fixed: 2374281
Change I38900a4c786b5ba5f31006e6e29332c081a565cf ("qcacld-3.0:
cleanup legacy scan code") removed the last reference to macro
HDD_SCAN_INACTIVITY_TIMEOUT. Since this macro is now unused,
remove it.
Change-Id: I9cb1370b6284a76c073594760bd857f666426e84
CRs-Fixed: 2374280
The timWaitCount field in tAniSirDph is initialized but never read.
Since it is ultimately unused, remove it.
Change-Id: I98795820caf8087f225b3835e531790d2d1f167e
CRs-Fixed: 2374279
The txRateFlags field in tSirIbssPeerInfoParams is initialized to zero
but is otherwise unused, so remove it.
Change-Id: I8efcb18869dfe1c5e2a42395bb40c281391b3bfa
CRs-Fixed: 2374278
Field ucPatternIdBitmap in tSirDelPeriodicTxPtrn serves no purpose, so
remove it.
Change-Id: I966983c3dea674e61ccf4d06473ea21448484a4c
CRs-Fixed: 2374277
